All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia@diku.dk>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: kernel-janitors@vger.kernel.org,
	Linus Walleij <linus.walleij@stericsson.com>,
	Rob Herring <rob.herring@calxeda.com>,
	linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org
Subject: [PATCH 1/6] drivers/gpio/gpio-tegra.c: use devm_request_and_ioremap
Date: Tue, 27 Dec 2011 14:01:26 +0000	[thread overview]
Message-ID: <1324994491-21828-2-git-send-email-julia@diku.dk> (raw)
In-Reply-To: <1324994491-21828-1-git-send-email-julia@diku.dk>

From: Julia Lawall <julia@diku.dk>

Reimplement a call to devm_request_mem_region followed by a call to ioremap
or ioremap_nocache by a call to devm_request_and_ioremap.

The semantic patch that makes this transformation is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@nm@
expression myname;
identifier i;
@@

struct platform_driver i = { .driver = { .name = myname } };

@@
expression dev,res,size;
expression nm.myname;
@@

-if (!devm_request_mem_region(dev, res->start, size,
-                              \(res->name\|dev_name(dev)\|myname\))) {
-   ...
-   return ...;
-}
... when != res->start
(
-devm_ioremap(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
|
-devm_ioremap_nocache(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
)
... when any
    when != res->start
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/gpio/gpio-tegra.c |    9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index 61044c8..bdc2937 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -361,14 +361,7 @@ static int __devinit tegra_gpio_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	if (!devm_request_mem_region(&pdev->dev, res->start,
-				     resource_size(res),
-				     dev_name(&pdev->dev))) {
-		dev_err(&pdev->dev, "Couldn't request MEM resource\n");
-		return -ENODEV;
-	}
-
-	regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));
+	regs = devm_request_and_ioremap(&pdev->dev, res);
 	if (!regs) {
 		dev_err(&pdev->dev, "Couldn't ioremap regs\n");
 		return -ENODEV;


WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia@diku.dk>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: kernel-janitors@vger.kernel.org,
	Linus Walleij <linus.walleij@stericsson.com>,
	Rob Herring <rob.herring@calxeda.com>,
	linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org
Subject: [PATCH 1/6] drivers/gpio/gpio-tegra.c: use devm_request_and_ioremap
Date: Tue, 27 Dec 2011 15:01:26 +0100	[thread overview]
Message-ID: <1324994491-21828-2-git-send-email-julia@diku.dk> (raw)
In-Reply-To: <1324994491-21828-1-git-send-email-julia@diku.dk>

From: Julia Lawall <julia@diku.dk>

Reimplement a call to devm_request_mem_region followed by a call to ioremap
or ioremap_nocache by a call to devm_request_and_ioremap.

The semantic patch that makes this transformation is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@nm@
expression myname;
identifier i;
@@

struct platform_driver i = { .driver = { .name = myname } };

@@
expression dev,res,size;
expression nm.myname;
@@

-if (!devm_request_mem_region(dev, res->start, size,
-                              \(res->name\|dev_name(dev)\|myname\))) {
-   ...
-   return ...;
-}
... when != res->start
(
-devm_ioremap(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
|
-devm_ioremap_nocache(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
)
... when any
    when != res->start
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/gpio/gpio-tegra.c |    9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index 61044c8..bdc2937 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -361,14 +361,7 @@ static int __devinit tegra_gpio_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	if (!devm_request_mem_region(&pdev->dev, res->start,
-				     resource_size(res),
-				     dev_name(&pdev->dev))) {
-		dev_err(&pdev->dev, "Couldn't request MEM resource\n");
-		return -ENODEV;
-	}
-
-	regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));
+	regs = devm_request_and_ioremap(&pdev->dev, res);
 	if (!regs) {
 		dev_err(&pdev->dev, "Couldn't ioremap regs\n");
 		return -ENODEV;

  reply	other threads:[~2011-12-27 14:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-27 14:01 [PATCH 0/6] use devm_request_and_ioremap Julia Lawall
2011-12-27 14:01 ` Julia Lawall
2011-12-27 14:01 ` Julia Lawall [this message]
2011-12-27 14:01   ` [PATCH 1/6] drivers/gpio/gpio-tegra.c: " Julia Lawall
     [not found]   ` <1324994491-21828-2-git-send-email-julia-dAYI7NvHqcQ@public.gmane.org>
2012-01-02  8:44     ` [PATCH 1/6] drivers/gpio/gpio-tegra.c: use Grant Likely
2012-01-02  8:44       ` [PATCH 1/6] drivers/gpio/gpio-tegra.c: use devm_request_and_ioremap Grant Likely
2012-01-02  8:44       ` Grant Likely
2011-12-27 14:01 ` [PATCH 3/6] drivers/watchdog/imx2_wdt.c: " Julia Lawall
2011-12-27 14:01   ` Julia Lawall
2011-12-27 14:01 ` [PATCH 4/6] drivers/watchdog/dw_wdt.c: " Julia Lawall
2011-12-27 14:01   ` Julia Lawall
2011-12-27 14:01 ` [PATCH 5/6] drivers/char/hw_random/tx4939-rng.c: " Julia Lawall
2011-12-27 14:01   ` Julia Lawall
2012-01-13  5:36   ` Herbert Xu
2012-01-13  5:36     ` Herbert Xu
2011-12-27 14:01 ` [PATCH 6/6] drivers/mtd/nand/txx9ndfmc.c: " Julia Lawall
2011-12-27 14:01   ` Julia Lawall
2011-12-27 14:01   ` Julia Lawall
2011-12-27 14:45   ` [PATCH 6/6] drivers/mtd/nand/txx9ndfmc.c: use Artem Bityutskiy
2011-12-27 14:45     ` [PATCH 6/6] drivers/mtd/nand/txx9ndfmc.c: use devm_request_and_ioremap Artem Bityutskiy
2011-12-27 14:45     ` Artem Bityutskiy
2011-12-27 14:46     ` [PATCH 6/6] drivers/mtd/nand/txx9ndfmc.c: use Julia Lawall
2011-12-27 14:46       ` [PATCH 6/6] drivers/mtd/nand/txx9ndfmc.c: use devm_request_and_ioremap Julia Lawall
2011-12-27 14:46       ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324994491-21828-2-git-send-email-julia@diku.dk \
    --to=julia@diku.dk \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.