* [PATCH 0/7][PULL] Hob2 related oe-core changes
@ 2012-01-06 9:04 Dongxiao Xu
[not found] ` <cover.1325840474.git.dongxiao.xu@intel.com>
2012-01-06 16:27 ` [PATCH 0/7][PULL] Hob2 related oe-core changes Richard Purdie
0 siblings, 2 replies; 16+ messages in thread
From: Dongxiao Xu @ 2012-01-06 9:04 UTC (permalink / raw)
To: openembedded-core
Hi Richard,
This pull request is the hob2 related oe-core changes.
Please help to review and pull.
Note that this pull request has dependency on the hob related bitbake changes.
Thanks,
Dongxiao
The following changes since commit 4a85312568a6bb052cc511c15b4ae842ff7f8e59:
Richard Purdie (1):
image-mklibs/package_ipk: Remove bashisms
are available in the git repository at:
git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore-changes
Dongxiao Xu (6):
bblayers.conf.sample: Use ?= to set BBLAYERS
image.bbclass: Use ?= to set LINGUAS_INSTALL
packageinfo.bbclass: add a new bbclass to pass package information
hob.bb: Add a empty image template
hob-toolchain: add a new recipe hob-toolchain
layers: add a new folder to put user added layers
Shane Wang (1):
package.bbclass: set package size into pkgdata for hob2's use
layers/README | 1 +
meta/classes/image.bbclass | 2 +-
meta/classes/package.bbclass | 8 ++++++++
meta/classes/packageinfo.bbclass | 30 ++++++++++++++++++++++++++++++
meta/conf/bblayers.conf.sample | 2 +-
meta/recipes-core/images/hob.bb | 1 +
meta/recipes-core/meta/hob-toolchain.bb | 10 ++++++++++
7 files changed, 52 insertions(+), 2 deletions(-)
create mode 100644 layers/README
create mode 100644 meta/classes/packageinfo.bbclass
create mode 100644 meta/recipes-core/images/hob.bb
create mode 100644 meta/recipes-core/meta/hob-toolchain.bb
^ permalink raw reply [flat|nested] 16+ messages in thread[parent not found: <cover.1325840474.git.dongxiao.xu@intel.com>]
* [PATCH 1/7] bblayers.conf.sample: Use ?= to set BBLAYERS [not found] ` <cover.1325840474.git.dongxiao.xu@intel.com> @ 2012-01-06 9:04 ` Dongxiao Xu 2012-01-06 9:05 ` [PATCH 2/7] image.bbclass: Use ?= to set LINGUAS_INSTALL Dongxiao Xu ` (5 subsequent siblings) 6 siblings, 0 replies; 16+ messages in thread From: Dongxiao Xu @ 2012-01-06 9:04 UTC (permalink / raw) To: openembedded-core Hob may dynamically sets BBLAYERS to bitbake server, thus we need a flexible way to load BBLAYERS value. Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> --- meta/conf/bblayers.conf.sample | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/meta/conf/bblayers.conf.sample b/meta/conf/bblayers.conf.sample index 339a421..222b03a 100644 --- a/meta/conf/bblayers.conf.sample +++ b/meta/conf/bblayers.conf.sample @@ -3,6 +3,6 @@ LCONF_VERSION = "4" BBFILES ?= "" -BBLAYERS = " \ +BBLAYERS ?= " \ ##COREBASE##/meta \ " -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/7] image.bbclass: Use ?= to set LINGUAS_INSTALL [not found] ` <cover.1325840474.git.dongxiao.xu@intel.com> 2012-01-06 9:04 ` [PATCH 1/7] bblayers.conf.sample: Use ?= to set BBLAYERS Dongxiao Xu @ 2012-01-06 9:05 ` Dongxiao Xu 2012-01-06 9:05 ` [PATCH 3/7] package.bbclass: set package size into pkgdata for hob2's use Dongxiao Xu ` (4 subsequent siblings) 6 siblings, 0 replies; 16+ messages in thread From: Dongxiao Xu @ 2012-01-06 9:05 UTC (permalink / raw) To: openembedded-core Hob may dynamically sets BBLAYERS to bitbake server, thus we need a flexible way to load LINGUAS_INSTALL value. Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> --- meta/classes/image.bbclass | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index 275b28f..295b653 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -119,7 +119,7 @@ ROOTFS_POSTPROCESS_COMMAND ?= "" # some default locales IMAGE_LINGUAS ?= "de-de fr-fr en-gb" -LINGUAS_INSTALL = "${@" ".join(map(lambda s: "locale-base-%s" % s, d.getVar('IMAGE_LINGUAS', 1).split()))}" +LINGUAS_INSTALL ?= "${@" ".join(map(lambda s: "locale-base-%s" % s, d.getVar('IMAGE_LINGUAS', 1).split()))}" PSEUDO_PASSWD = "${IMAGE_ROOTFS}" -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/7] package.bbclass: set package size into pkgdata for hob2's use [not found] ` <cover.1325840474.git.dongxiao.xu@intel.com> 2012-01-06 9:04 ` [PATCH 1/7] bblayers.conf.sample: Use ?= to set BBLAYERS Dongxiao Xu 2012-01-06 9:05 ` [PATCH 2/7] image.bbclass: Use ?= to set LINGUAS_INSTALL Dongxiao Xu @ 2012-01-06 9:05 ` Dongxiao Xu 2012-01-06 9:05 ` [PATCH 4/7] packageinfo.bbclass: add a new bbclass to pass package information Dongxiao Xu ` (3 subsequent siblings) 6 siblings, 0 replies; 16+ messages in thread From: Dongxiao Xu @ 2012-01-06 9:05 UTC (permalink / raw) To: openembedded-core From: Shane Wang <shane.wang@intel.com> Write the size of a package into its pkgdata for hob2 to get the size and show on the UI for image making. Signed-off-by: Shane Wang <shane.wang@intel.com> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> --- meta/classes/package.bbclass | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index 9040eb4..8bde0b3 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -1042,6 +1042,13 @@ python emit_pkgdata() { f.write('%s: %s\n' % (var, encode(val))) return + def get_directory_size(dir): + if os.listdir(dir): + size = int(os.popen('du -sk %s' % dir).readlines()[0].split('\t')[0]) + else: + size = 0 + return size + packages = d.getVar('PACKAGES', True) pkgdest = d.getVar('PKGDEST', 1) pkgdatadir = d.getVar('PKGDESTWORK', True) @@ -1090,6 +1097,7 @@ python emit_pkgdata() { for dfile in (d.getVar('FILERDEPENDSFLIST_' + pkg, True) or "").split(): write_if_exists(sf, pkg, 'FILERDEPENDS_' + dfile) + sf.write('%s_%s: %s\n' % ('PKGSIZE', pkg, get_directory_size(pkgdest + "/%s" % pkg))) sf.close() -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/7] packageinfo.bbclass: add a new bbclass to pass package information [not found] ` <cover.1325840474.git.dongxiao.xu@intel.com> ` (2 preceding siblings ...) 2012-01-06 9:05 ` [PATCH 3/7] package.bbclass: set package size into pkgdata for hob2's use Dongxiao Xu @ 2012-01-06 9:05 ` Dongxiao Xu 2012-01-06 10:32 ` Koen Kooi 2012-01-06 9:05 ` [PATCH 5/7] hob.bb: Add a empty image template Dongxiao Xu ` (2 subsequent siblings) 6 siblings, 1 reply; 16+ messages in thread From: Dongxiao Xu @ 2012-01-06 9:05 UTC (permalink / raw) To: openembedded-core packageinfo.bbclass is to pass the accurate package information to clients (e.g. Hob), including PN, PV, RDEPENDS, PKGSIZE, etc. Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> --- meta/classes/packageinfo.bbclass | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) create mode 100644 meta/classes/packageinfo.bbclass diff --git a/meta/classes/packageinfo.bbclass b/meta/classes/packageinfo.bbclass new file mode 100644 index 0000000..644b482 --- /dev/null +++ b/meta/classes/packageinfo.bbclass @@ -0,0 +1,30 @@ +inherit packagedata + +python do_package_info () { + bb.build.exec_func("read_subpackage_metadata", d) + pn = d.getVar('PN', True) or "" + pv = d.getVar('PV', True) or "" + pr = d.getVar('PR', True) or "" + recipe = pn + '-' + pv + '-' + pr + + packages = d.getVar('PACKAGES', True) or "" + pkginfolist = [] + for pkg in packages.split(): + pkginfo = {} + pkginfo['pkg'] = pkg + pkginfo['pkgv'] = d.getVar('PKGV', True) or "" + pkginfo['pkgr'] = d.getVar('PKGR', True) or "" + pkginfo['pkg_rename'] = d.getVar('PKG_%s' % pkg, True) or "" + pkginfo['section'] = d.getVar('SECTION', True) or "" + pkginfo['summary'] = d.getVar('SUMMARY', True) or "" + pkginfo['rdep'] = d.getVar('RDEPENDS_%s' % pkg, True) or "" + pkginfo['rrec'] = d.getVar('RRECOMMENDS_%s' % pkg, True) or "" + pkginfo['rprov'] = d.getVar('RPROVIDES_%s' % pkg, True) or "" + pkginfo['size'] = d.getVar('PKGSIZE_%s' % pkg, True) or "" + pkginfo['allow_empty'] = d.getVar('ALLOW_EMPTY_%s' % pkg, True) or d.getVar('ALLOW_EMPTY', True) or "" + pkginfolist.append(pkginfo) + + bb.event.fire(bb.event.PackageInfo(recipe, pkginfolist), d) +} +do_package_info[nostamp] = "1" +addtask package_info after do_package_write -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 4/7] packageinfo.bbclass: add a new bbclass to pass package information 2012-01-06 9:05 ` [PATCH 4/7] packageinfo.bbclass: add a new bbclass to pass package information Dongxiao Xu @ 2012-01-06 10:32 ` Koen Kooi 2012-01-07 8:00 ` Xu, Dongxiao 0 siblings, 1 reply; 16+ messages in thread From: Koen Kooi @ 2012-01-06 10:32 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Op 6 jan. 2012, om 10:05 heeft Dongxiao Xu het volgende geschreven: > packageinfo.bbclass is to pass the accurate package information to > clients (e.g. Hob), including PN, PV, RDEPENDS, PKGSIZE, etc. Why not reuse buildhistory for this? ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 4/7] packageinfo.bbclass: add a new bbclass to pass package information 2012-01-06 10:32 ` Koen Kooi @ 2012-01-07 8:00 ` Xu, Dongxiao 0 siblings, 0 replies; 16+ messages in thread From: Xu, Dongxiao @ 2012-01-07 8:00 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Hi Koen, > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of > Koen Kooi > Sent: Friday, January 06, 2012 6:32 PM > To: Patches and discussions about the oe-core layer > Subject: Re: [OE-core] [PATCH 4/7] packageinfo.bbclass: add a new bbclass to > pass package information > > > Op 6 jan. 2012, om 10:05 heeft Dongxiao Xu het volgende geschreven: > > > packageinfo.bbclass is to pass the accurate package information to > > clients (e.g. Hob), including PN, PV, RDEPENDS, PKGSIZE, etc. > > Why not reuse buildhistory for this? I didn't aware the existence of buildhistory.bbclass when I wrote my code. I will have a look at that. Thanks, Dongxiao > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 5/7] hob.bb: Add a empty image template [not found] ` <cover.1325840474.git.dongxiao.xu@intel.com> ` (3 preceding siblings ...) 2012-01-06 9:05 ` [PATCH 4/7] packageinfo.bbclass: add a new bbclass to pass package information Dongxiao Xu @ 2012-01-06 9:05 ` Dongxiao Xu 2012-01-06 9:05 ` [PATCH 6/7] hob-toolchain: add a new recipe hob-toolchain Dongxiao Xu 2012-01-06 9:05 ` [PATCH 7/7] layers: add a new folder to put user added layers Dongxiao Xu 6 siblings, 0 replies; 16+ messages in thread From: Dongxiao Xu @ 2012-01-06 9:05 UTC (permalink / raw) To: openembedded-core This recipe serves as the target when using Hob to generate image. Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> --- meta/recipes-core/images/hob.bb | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-core/images/hob.bb diff --git a/meta/recipes-core/images/hob.bb b/meta/recipes-core/images/hob.bb new file mode 100644 index 0000000..c4d9210 --- /dev/null +++ b/meta/recipes-core/images/hob.bb @@ -0,0 +1,3 @@ +LICENSE = "MIT" + +inherit image -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 6/7] hob-toolchain: add a new recipe hob-toolchain [not found] ` <cover.1325840474.git.dongxiao.xu@intel.com> ` (4 preceding siblings ...) 2012-01-06 9:05 ` [PATCH 5/7] hob.bb: Add a empty image template Dongxiao Xu @ 2012-01-06 9:05 ` Dongxiao Xu 2012-01-06 9:05 ` [PATCH 7/7] layers: add a new folder to put user added layers Dongxiao Xu 6 siblings, 0 replies; 16+ messages in thread From: Dongxiao Xu @ 2012-01-06 9:05 UTC (permalink / raw) To: openembedded-core This is a dummy recipe to build toolchain in Hob Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> --- meta/recipes-core/meta/hob-toolchain.bb | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-core/meta/hob-toolchain.bb diff --git a/meta/recipes-core/meta/hob-toolchain.bb b/meta/recipes-core/meta/hob-toolchain.bb new file mode 100644 index 0000000..36aaef1 --- /dev/null +++ b/meta/recipes-core/meta/hob-toolchain.bb @@ -0,0 +1,10 @@ +DESCRIPTION = "Hob toolchain" +LICENSE = "MIT" + +PR = "r0" + +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \ + file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" + +IMAGETEST ?= "dummy" +inherit populate_sdk imagetest-${IMAGETEST} -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 7/7] layers: add a new folder to put user added layers [not found] ` <cover.1325840474.git.dongxiao.xu@intel.com> ` (5 preceding siblings ...) 2012-01-06 9:05 ` [PATCH 6/7] hob-toolchain: add a new recipe hob-toolchain Dongxiao Xu @ 2012-01-06 9:05 ` Dongxiao Xu 6 siblings, 0 replies; 16+ messages in thread From: Dongxiao Xu @ 2012-01-06 9:05 UTC (permalink / raw) To: openembedded-core This is helpful for remote users to find the available layers in the bitbake server machine. Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> --- layers/README | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) create mode 100644 layers/README diff --git a/layers/README b/layers/README new file mode 100644 index 0000000..88747f4 --- /dev/null +++ b/layers/README @@ -0,0 +1 @@ +Please put extra layers (besides meta and meta-yocto) in this folder. -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 0/7][PULL] Hob2 related oe-core changes 2012-01-06 9:04 [PATCH 0/7][PULL] Hob2 related oe-core changes Dongxiao Xu [not found] ` <cover.1325840474.git.dongxiao.xu@intel.com> @ 2012-01-06 16:27 ` Richard Purdie 2012-01-06 16:37 ` Mark Hatle ` (2 more replies) 1 sibling, 3 replies; 16+ messages in thread From: Richard Purdie @ 2012-01-06 16:27 UTC (permalink / raw) To: Patches and discussions about the oe-core layer On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote: > Hi Richard, > > This pull request is the hob2 related oe-core changes. > Please help to review and pull. > > Note that this pull request has dependency on the hob related bitbake changes. > > Thanks, > Dongxiao > > The following changes since commit 4a85312568a6bb052cc511c15b4ae842ff7f8e59: > Richard Purdie (1): > image-mklibs/package_ipk: Remove bashisms > > are available in the git repository at: > > git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes > http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore-changes > > Dongxiao Xu (6): > bblayers.conf.sample: Use ?= to set BBLAYERS > image.bbclass: Use ?= to set LINGUAS_INSTALL I merged these. > packageinfo.bbclass: add a new bbclass to pass package information I still have quite a strong dislike of this code, its rather nasty to require this and I wish we could come up with a less ugly way to collect up this information. > hob.bb: Add a empty image template > hob-toolchain: add a new recipe hob-toolchain > layers: add a new folder to put user added layers I don't like these three. They're horribly hob specific and IMO shouldn't be in the general metadata. If there is no way to avoid them, they should perhaps go into a meta-hob layer directory to keep them separate from the rest of the system. I'm still puzzled how the layers directory helps. We deliberately support generic layer locations so forcing the user to place them in a particular place seems like a bit of a backwards step? :/. Cheers, Richard ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/7][PULL] Hob2 related oe-core changes 2012-01-06 16:27 ` [PATCH 0/7][PULL] Hob2 related oe-core changes Richard Purdie @ 2012-01-06 16:37 ` Mark Hatle 2012-01-06 16:41 ` Koen Kooi 2012-01-07 7:40 ` Xu, Dongxiao 2 siblings, 0 replies; 16+ messages in thread From: Mark Hatle @ 2012-01-06 16:37 UTC (permalink / raw) To: openembedded-core On 1/6/12 10:27 AM, Richard Purdie wrote: > On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote: >> Hi Richard, >> >> This pull request is the hob2 related oe-core changes. >> Please help to review and pull. >> >> Note that this pull request has dependency on the hob related bitbake changes. >> >> Thanks, >> Dongxiao >> >> The following changes since commit 4a85312568a6bb052cc511c15b4ae842ff7f8e59: >> Richard Purdie (1): >> image-mklibs/package_ipk: Remove bashisms >> >> are available in the git repository at: >> >> git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes >> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore-changes >> >> Dongxiao Xu (6): >> bblayers.conf.sample: Use ?= to set BBLAYERS >> image.bbclass: Use ?= to set LINGUAS_INSTALL > > I merged these. > >> packageinfo.bbclass: add a new bbclass to pass package information > > I still have quite a strong dislike of this code, its rather nasty to > require this and I wish we could come up with a less ugly way to collect > up this information. > >> hob.bb: Add a empty image template >> hob-toolchain: add a new recipe hob-toolchain >> layers: add a new folder to put user added layers > > I don't like these three. They're horribly hob specific and IMO > shouldn't be in the general metadata. If there is no way to avoid them, > they should perhaps go into a meta-hob layer directory to keep them > separate from the rest of the system. > > I'm still puzzled how the layers directory helps. We deliberately > support generic layer locations so forcing the user to place them in a > particular place seems like a bit of a backwards step? :/. I think the layer directory is useful for distributions based on oe-core. But I agree, it seems wrong to have it in OE-core itself -- unless there is a strong demand from the users of a "standard place" to put layers in their tree. (So far I've not heard such a request.) --Mark > Cheers, > > Richard > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/7][PULL] Hob2 related oe-core changes 2012-01-06 16:27 ` [PATCH 0/7][PULL] Hob2 related oe-core changes Richard Purdie 2012-01-06 16:37 ` Mark Hatle @ 2012-01-06 16:41 ` Koen Kooi 2012-01-07 7:47 ` Xu, Dongxiao 2012-01-07 7:53 ` Xu, Dongxiao 2012-01-07 7:40 ` Xu, Dongxiao 2 siblings, 2 replies; 16+ messages in thread From: Koen Kooi @ 2012-01-06 16:41 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Op 6 jan. 2012, om 17:27 heeft Richard Purdie het volgende geschreven: > On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote: >> Hi Richard, >> >> This pull request is the hob2 related oe-core changes. >> Please help to review and pull. >> >> Note that this pull request has dependency on the hob related bitbake changes. >> >> Thanks, >> Dongxiao >> >> The following changes since commit 4a85312568a6bb052cc511c15b4ae842ff7f8e59: >> Richard Purdie (1): >> image-mklibs/package_ipk: Remove bashisms >> >> are available in the git repository at: >> >> git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes >> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore-changes >> >> Dongxiao Xu (6): >> bblayers.conf.sample: Use ?= to set BBLAYERS >> image.bbclass: Use ?= to set LINGUAS_INSTALL > > I merged these. > >> packageinfo.bbclass: add a new bbclass to pass package information > > I still have quite a strong dislike of this code, its rather nasty to > require this and I wish we could come up with a less ugly way to collect > up this information. > >> hob.bb: Add a empty image template >> hob-toolchain: add a new recipe hob-toolchain >> layers: add a new folder to put user added layers > > I don't like these three. They're horribly hob specific and IMO > shouldn't be in the general metadata. If there is no way to avoid them, > they should perhaps go into a meta-hob layer directory to keep them > separate from the rest of the system. And I still don't get why hob can't load local.conf to load the defaults instead of ignoring it completely. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/7][PULL] Hob2 related oe-core changes 2012-01-06 16:41 ` Koen Kooi @ 2012-01-07 7:47 ` Xu, Dongxiao 2012-01-07 7:53 ` Xu, Dongxiao 1 sibling, 0 replies; 16+ messages in thread From: Xu, Dongxiao @ 2012-01-07 7:47 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Hi Koen, > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of > Koen Kooi > Sent: Saturday, January 07, 2012 12:42 AM > To: Patches and discussions about the oe-core layer > Subject: Re: [OE-core] [PATCH 0/7][PULL] Hob2 related oe-core changes > > > Op 6 jan. 2012, om 17:27 heeft Richard Purdie het volgende geschreven: > > > On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote: > >> Hi Richard, > >> > >> This pull request is the hob2 related oe-core changes. > >> Please help to review and pull. > >> > >> Note that this pull request has dependency on the hob related bitbake > changes. > >> > >> Thanks, > >> Dongxiao > >> > >> The following changes since commit > 4a85312568a6bb052cc511c15b4ae842ff7f8e59: > >> Richard Purdie (1): > >> image-mklibs/package_ipk: Remove bashisms > >> > >> are available in the git repository at: > >> > >> git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes > >> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore > >> -changes > >> > >> Dongxiao Xu (6): > >> bblayers.conf.sample: Use ?= to set BBLAYERS > >> image.bbclass: Use ?= to set LINGUAS_INSTALL > > > > I merged these. > > > >> packageinfo.bbclass: add a new bbclass to pass package information > > > > I still have quite a strong dislike of this code, its rather nasty to > > require this and I wish we could come up with a less ugly way to > > collect up this information. > > > >> hob.bb: Add a empty image template > >> hob-toolchain: add a new recipe hob-toolchain > >> layers: add a new folder to put user added layers > > > > I don't like these three. They're horribly hob specific and IMO > > shouldn't be in the general metadata. If there is no way to avoid > > them, they should perhaps go into a meta-hob layer directory to keep > > them separate from the rest of the system. > > And I still don't get why hob can't load local.conf to load the defaults instead of > ignoring it completely. The new Hob doesn't ignore local.conf, it will load all its values (except BB_NUMBER_THREADS and PARALLEL_MAKE) as the default configuration. Thanks, Dongxiao > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/7][PULL] Hob2 related oe-core changes 2012-01-06 16:41 ` Koen Kooi 2012-01-07 7:47 ` Xu, Dongxiao @ 2012-01-07 7:53 ` Xu, Dongxiao 1 sibling, 0 replies; 16+ messages in thread From: Xu, Dongxiao @ 2012-01-07 7:53 UTC (permalink / raw) To: Patches and discussions about the oe-core layer > -----Original Message----- > From: Xu, Dongxiao > Sent: Saturday, January 07, 2012 3:48 PM > To: Patches and discussions about the oe-core layer > Subject: RE: [OE-core] [PATCH 0/7][PULL] Hob2 related oe-core changes > > Hi Koen, > > > -----Original Message----- > > From: openembedded-core-bounces@lists.openembedded.org > > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of > > Koen Kooi > > Sent: Saturday, January 07, 2012 12:42 AM > > To: Patches and discussions about the oe-core layer > > Subject: Re: [OE-core] [PATCH 0/7][PULL] Hob2 related oe-core changes > > > > > > Op 6 jan. 2012, om 17:27 heeft Richard Purdie het volgende geschreven: > > > > > On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote: > > >> Hi Richard, > > >> > > >> This pull request is the hob2 related oe-core changes. > > >> Please help to review and pull. > > >> > > >> Note that this pull request has dependency on the hob related > > >> bitbake > > changes. > > >> > > >> Thanks, > > >> Dongxiao > > >> > > >> The following changes since commit > > 4a85312568a6bb052cc511c15b4ae842ff7f8e59: > > >> Richard Purdie (1): > > >> image-mklibs/package_ipk: Remove bashisms > > >> > > >> are available in the git repository at: > > >> > > >> git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes > > >> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oeco > > >> re > > >> -changes > > >> > > >> Dongxiao Xu (6): > > >> bblayers.conf.sample: Use ?= to set BBLAYERS > > >> image.bbclass: Use ?= to set LINGUAS_INSTALL > > > > > > I merged these. > > > > > >> packageinfo.bbclass: add a new bbclass to pass package information > > > > > > I still have quite a strong dislike of this code, its rather nasty > > > to require this and I wish we could come up with a less ugly way to > > > collect up this information. > > > > > >> hob.bb: Add a empty image template > > >> hob-toolchain: add a new recipe hob-toolchain > > >> layers: add a new folder to put user added layers > > > > > > I don't like these three. They're horribly hob specific and IMO > > > shouldn't be in the general metadata. If there is no way to avoid > > > them, they should perhaps go into a meta-hob layer directory to keep > > > them separate from the rest of the system. > > > > And I still don't get why hob can't load local.conf to load the > > defaults instead of ignoring it completely. > > The new Hob doesn't ignore local.conf, it will load all its values (except > BB_NUMBER_THREADS and PARALLEL_MAKE) as the default configuration. Make some clarification here: Actually new HOB will also load the BB_NUMBER_THREADS and PARALLEL_MAKE from local.conf. But if the two values are not set in the local.conf (thus the default value is "1"), HOB will set a proper value for them according to the server's CPU information. Thanks, Dongxiao > > Thanks, > Dongxiao > > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/7][PULL] Hob2 related oe-core changes 2012-01-06 16:27 ` [PATCH 0/7][PULL] Hob2 related oe-core changes Richard Purdie 2012-01-06 16:37 ` Mark Hatle 2012-01-06 16:41 ` Koen Kooi @ 2012-01-07 7:40 ` Xu, Dongxiao 2 siblings, 0 replies; 16+ messages in thread From: Xu, Dongxiao @ 2012-01-07 7:40 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Hi Richard, > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of > Richard Purdie > Sent: Saturday, January 07, 2012 12:28 AM > To: Patches and discussions about the oe-core layer > Subject: Re: [OE-core] [PATCH 0/7][PULL] Hob2 related oe-core changes > > On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote: > > Hi Richard, > > > > This pull request is the hob2 related oe-core changes. > > Please help to review and pull. > > > > Note that this pull request has dependency on the hob related bitbake > changes. > > > > Thanks, > > Dongxiao > > > > The following changes since commit > 4a85312568a6bb052cc511c15b4ae842ff7f8e59: > > Richard Purdie (1): > > image-mklibs/package_ipk: Remove bashisms > > > > are available in the git repository at: > > > > git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes > > > > http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore- > > changes > > > > Dongxiao Xu (6): > > bblayers.conf.sample: Use ?= to set BBLAYERS > > image.bbclass: Use ?= to set LINGUAS_INSTALL > > I merged these. Thanks! > > > packageinfo.bbclass: add a new bbclass to pass package information > > I still have quite a strong dislike of this code, its rather nasty to require this and I > wish we could come up with a less ugly way to collect up this information. I am sorry if this patch makes you feel uncomfortable. Actually this approach was brought out early in the HOB2 design phase, and that time I didn't get explicit objection about it. Refer to bug http://bugzilla.pokylinux.org/show_bug.cgi?id=1750, which is a M2 task. Later we had some discussions of finding new way to dump all the available packages from server side. Due to the schedule reason, we have to put it into M3. Refer to bug http://bugzilla.pokylinux.org/show_bug.cgi?id=1871. But I think this approach is similar with buildhistory.bbclass. (Actually I am not aware there is buildhistory.bbclass exists when I wrote my code). What the main difference is, buildhistory.bbclass writes the information into a local file, but packageinfo.bbclass emit the info as an event. > > > hob.bb: Add a empty image template > > hob-toolchain: add a new recipe hob-toolchain > > layers: add a new folder to put user added layers > > I don't like these three. They're horribly hob specific and IMO shouldn't be in the > general metadata. If there is no way to avoid them, they should perhaps go into > a meta-hob layer directory to keep them separate from the rest of the system. If we need to support the split of client and server, there is a principle that client GUI should not access any server directories or files. Therefore HOB will not automatically generate any image bb files and copy it to meta directory. This is the reason why we need to generate two empty image/toolchain files for the GUI to use. If you do not like the name of hob.bb or hob-toolchain.bb, I can rename it to a generic one, like dummy-image.bb and dummy-toolchain.bb. Actually putting them into meta-hob layer also works, but this requires the hob user to manually add meta-hob layer each time when he launches the HOB GUI. Of course we can defaultly add meta-hob layer into bblayers.conf.sample in meta-yocto layer if you think it is feasible. > > I'm still puzzled how the layers directory helps. We deliberately support generic > layer locations so forcing the user to place them in a particular place seems like > a bit of a backwards step? :/. We do not need the "layers" directory if users know where the layers are and then they can edit bblayers.conf. And in non-split HOB case, users can still put their layers anywhere. HOB supports file browser and user can add layer by that. But one new situation is, client GUI and server may run in different machines. How could a client GUI user get the information what are the available layers in server? I definitely welcome good suggestions. Thanks, Dongxiao > > Cheers, > > Richard > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2012-01-07 8:08 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-06 9:04 [PATCH 0/7][PULL] Hob2 related oe-core changes Dongxiao Xu
[not found] ` <cover.1325840474.git.dongxiao.xu@intel.com>
2012-01-06 9:04 ` [PATCH 1/7] bblayers.conf.sample: Use ?= to set BBLAYERS Dongxiao Xu
2012-01-06 9:05 ` [PATCH 2/7] image.bbclass: Use ?= to set LINGUAS_INSTALL Dongxiao Xu
2012-01-06 9:05 ` [PATCH 3/7] package.bbclass: set package size into pkgdata for hob2's use Dongxiao Xu
2012-01-06 9:05 ` [PATCH 4/7] packageinfo.bbclass: add a new bbclass to pass package information Dongxiao Xu
2012-01-06 10:32 ` Koen Kooi
2012-01-07 8:00 ` Xu, Dongxiao
2012-01-06 9:05 ` [PATCH 5/7] hob.bb: Add a empty image template Dongxiao Xu
2012-01-06 9:05 ` [PATCH 6/7] hob-toolchain: add a new recipe hob-toolchain Dongxiao Xu
2012-01-06 9:05 ` [PATCH 7/7] layers: add a new folder to put user added layers Dongxiao Xu
2012-01-06 16:27 ` [PATCH 0/7][PULL] Hob2 related oe-core changes Richard Purdie
2012-01-06 16:37 ` Mark Hatle
2012-01-06 16:41 ` Koen Kooi
2012-01-07 7:47 ` Xu, Dongxiao
2012-01-07 7:53 ` Xu, Dongxiao
2012-01-07 7:40 ` Xu, Dongxiao
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.