From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Ilya Yanok <yanok@emcraft.com>, Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
grinberg@compulab.co.il, sasha_d@emcraft.com,
Archit Taneja <archit@ti.com>
Subject: Re: [PATCH V2] OMAP3: hwmod_data: register dss hwmods after dss_core
Date: Thu, 12 Jan 2012 11:13:38 +0200 [thread overview]
Message-ID: <1326359618.2065.4.camel@deskari> (raw)
In-Reply-To: <1325028693-14728-1-git-send-email-yanok@emcraft.com>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
Hi,
On Wed, 2011-12-28 at 00:31 +0100, Ilya Yanok wrote:
> dss_core has to be initialized before any other DSS hwmod. Currently
> this is broken as dss_core is listed in chip/revision specific hwmod
> lists while other DSS hwmods are listed in common list which is
> registered first.
>
> This patch moves DSS hwmods (except for dss_core) to the separate list
> which is registered last to ensure that dss_core is already registered.
>
> This solves the problem with BUG() in L3 interrupt handler on boards
> with DSS enabled in bootloader.
I can ack this patch as a concept. The dss_core has to be initialized
before other dss hw modules. I can't say if the implementation here is
good or not, I don't know enough about hwmod.
Paul?
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] OMAP3: hwmod_data: register dss hwmods after dss_core
Date: Thu, 12 Jan 2012 11:13:38 +0200 [thread overview]
Message-ID: <1326359618.2065.4.camel@deskari> (raw)
In-Reply-To: <1325028693-14728-1-git-send-email-yanok@emcraft.com>
Hi,
On Wed, 2011-12-28 at 00:31 +0100, Ilya Yanok wrote:
> dss_core has to be initialized before any other DSS hwmod. Currently
> this is broken as dss_core is listed in chip/revision specific hwmod
> lists while other DSS hwmods are listed in common list which is
> registered first.
>
> This patch moves DSS hwmods (except for dss_core) to the separate list
> which is registered last to ensure that dss_core is already registered.
>
> This solves the problem with BUG() in L3 interrupt handler on boards
> with DSS enabled in bootloader.
I can ack this patch as a concept. The dss_core has to be initialized
before other dss hw modules. I can't say if the implementation here is
good or not, I don't know enough about hwmod.
Paul?
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120112/3af45e9a/attachment.sig>
next prev parent reply other threads:[~2012-01-12 9:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 14:02 [PATCH] OMAP3: hwmod_data: register dss hwmods after dss_core Ilya Yanok
2011-12-22 14:02 ` Ilya Yanok
2011-12-22 15:10 ` Igor Grinberg
2011-12-22 15:10 ` Igor Grinberg
2011-12-27 23:31 ` [PATCH V2] " Ilya Yanok
2011-12-27 23:31 ` Ilya Yanok
2011-12-30 10:02 ` Archit Taneja
2011-12-30 10:02 ` Archit Taneja
2012-01-11 21:19 ` Ilya Yanok
2012-01-11 21:19 ` Ilya Yanok
2012-01-12 9:13 ` Tomi Valkeinen [this message]
2012-01-12 9:13 ` Tomi Valkeinen
2012-01-25 21:23 ` Paul Walmsley
2012-01-25 21:23 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326359618.2065.4.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=grinberg@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=sasha_d@emcraft.com \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.