* [PATCH] UBI: Handle empty string in verify_mkvol_req()
@ 2012-01-13 14:07 ` Richard Weinberger
0 siblings, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2012-01-13 14:07 UTC (permalink / raw)
To: dedekind1; +Cc: linux-mtd, dwmw2, linux-kernel, stable, Richard Weinberger
Currently it's possible to create a volume without a name.
E.g:
ubimkvol -n 32 -s 2MiB -t static /dev/ubi0 -N ""
After that vtbl_check() will always fail because it does not permit
empty strings.
Cc: <stable@vger.kernel.org>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/cdev.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 3320a50..ad76592 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -632,6 +632,9 @@ static int verify_mkvol_req(const struct ubi_device *ubi,
if (req->alignment != 1 && n)
goto bad;
+ if (!req->name[0] || !req->name_len)
+ goto bad;
+
if (req->name_len > UBI_VOL_NAME_MAX) {
err = -ENAMETOOLONG;
goto bad;
--
1.7.7.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] UBI: Handle empty string in verify_mkvol_req()
@ 2012-01-13 14:07 ` Richard Weinberger
0 siblings, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2012-01-13 14:07 UTC (permalink / raw)
To: dedekind1; +Cc: dwmw2, linux-mtd, linux-kernel, Richard Weinberger, stable
Currently it's possible to create a volume without a name.
E.g:
ubimkvol -n 32 -s 2MiB -t static /dev/ubi0 -N ""
After that vtbl_check() will always fail because it does not permit
empty strings.
Cc: <stable@vger.kernel.org>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/cdev.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 3320a50..ad76592 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -632,6 +632,9 @@ static int verify_mkvol_req(const struct ubi_device *ubi,
if (req->alignment != 1 && n)
goto bad;
+ if (!req->name[0] || !req->name_len)
+ goto bad;
+
if (req->name_len > UBI_VOL_NAME_MAX) {
err = -ENAMETOOLONG;
goto bad;
--
1.7.7.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] UBI: Handle empty string in verify_mkvol_req()
2012-01-13 14:07 ` Richard Weinberger
@ 2012-01-15 13:13 ` Artem Bityutskiy
-1 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2012-01-15 13:13 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-mtd, dwmw2, linux-kernel, stable
On Fri, 2012-01-13 at 15:07 +0100, Richard Weinberger wrote:
> Currently it's possible to create a volume without a name.
> E.g:
> ubimkvol -n 32 -s 2MiB -t static /dev/ubi0 -N ""
>
> After that vtbl_check() will always fail because it does not permit
> empty strings.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Well-spotted, thank you! I'll send it to Linus soon, as well as the
other patch of yours.
Artem.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] UBI: Handle empty string in verify_mkvol_req()
@ 2012-01-15 13:13 ` Artem Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2012-01-15 13:13 UTC (permalink / raw)
To: Richard Weinberger; +Cc: dwmw2, linux-mtd, linux-kernel, stable
On Fri, 2012-01-13 at 15:07 +0100, Richard Weinberger wrote:
> Currently it's possible to create a volume without a name.
> E.g:
> ubimkvol -n 32 -s 2MiB -t static /dev/ubi0 -N ""
>
> After that vtbl_check() will always fail because it does not permit
> empty strings.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Well-spotted, thank you! I'll send it to Linus soon, as well as the
other patch of yours.
Artem.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-15 13:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-13 14:07 [PATCH] UBI: Handle empty string in verify_mkvol_req() Richard Weinberger
2012-01-13 14:07 ` Richard Weinberger
2012-01-15 13:13 ` Artem Bityutskiy
2012-01-15 13:13 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.