All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <michael@walle.cc>
Cc: js07.lee@gmail.com, linux-mtd@lists.infradead.org,
	vigneshr@ti.com, js07.lee@samsung.com
Subject: Re: [PATCH v3 2/3] mtd: spi-nor: add 4bit block protection support
Date: Mon, 10 Feb 2020 11:26:06 +0000	[thread overview]
Message-ID: <132665276.5Rxbr4LpEM@localhost.localdomain> (raw)
In-Reply-To: <23efafdb8c439838338eef421e341f4a@walle.cc>

On Monday, February 10, 2020 12:29:34 PM EET Michael Walle wrote:
> > It's bytes. Take a look at W25Q128JV. The sector size for this flash is
> > 64KByte. The flash has 256 sectors. For this specific case:
> > bp_slots_available = 6;
> > bp_slots_needed = 8;
> > 
> > The if condition is true, so
> > bp_slot_count = 6;
> > bp_min_slot_size = 64k << (8 - 6); //256k
> 
> But nor->info->n_sectors is not 64k, its 256. Do you mean sector_size
> (like in
> my example below? Then we are on the same page 

Indeed, there is a typo in the pseudo code; I'm happy that the example is 
correct at least. I meant sector_size, not sectors. Now we should exercise the 
logic to all the known (corner) cases. Maybe Jungseung will tell us if he 
spots a flaw in the overall logic.

Cheers,
ta


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-02-10 11:26 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200113055910epcas1p4f97dfeb465b00d66649d6321cffc7b5a@epcas1p4.samsung.com>
2020-01-13  5:59 ` [PATCH v3 1/3] mtd: spi-nor: introduce SR_BP_SHIFT define Jungseung Lee
2020-01-13  5:59   ` [PATCH v3 2/3] mtd: spi-nor: add 4bit block protection support Jungseung Lee
2020-01-14 10:49     ` Tudor.Ambarus
2020-01-17 15:06       ` Jungseung Lee
2020-01-22 11:42         ` Jungseung Lee
2020-01-22 14:31           ` Tudor.Ambarus
2020-01-22 17:14             ` Michael Walle
2020-01-23  3:59               ` Jungseung Lee
2020-01-23  8:15                 ` Michael Walle
2020-02-11  7:52         ` chenxiang (M)
2020-03-04  5:20           ` Jungseung Lee
2020-03-04  8:36             ` chenxiang (M)
2020-03-07  7:40               ` Jungseung Lee
2020-01-22 19:36     ` Michael Walle
2020-01-23  6:22       ` Jungseung Lee
2020-01-23  8:10         ` Michael Walle
2020-01-23  8:53           ` Jungseung Lee
2020-01-23  9:31             ` Michael Walle
2020-01-28 11:01               ` Jungseung Lee
2020-01-28 12:29                 ` [SPAM] " Michael Walle
2020-01-30  8:17                   ` Jungseung Lee
2020-01-30  8:36                     ` [SPAM] " Michael Walle
2020-01-30 10:07                       ` Jungseung Lee
2020-02-03 13:56                     ` Vignesh Raghavendra
2020-02-03 14:38                       ` [SPAM] " Michael Walle
2020-02-03 14:58                         ` Jungseung Lee
2020-02-03 17:31                         ` Vignesh Raghavendra
2020-02-07 12:17                       ` Tudor.Ambarus
2020-02-10  8:33                         ` Michael Walle
2020-02-10  9:47                           ` Tudor.Ambarus
2020-02-10  9:59                             ` Tudor.Ambarus
2020-02-10 10:40                               ` Michael Walle
2020-02-10 11:27                                 ` Tudor.Ambarus
2020-02-10 12:14                                   ` Michael Walle
2020-02-10 15:50                                     ` Tudor.Ambarus
2020-02-10 10:29                             ` Michael Walle
2020-02-10 11:26                               ` Tudor.Ambarus [this message]
2020-02-19 10:50                                 ` Jungseung Lee
2020-02-19 11:08                                   ` Michael Walle
2020-02-19 11:23                                     ` Jungseung Lee
2020-02-19 11:36                                       ` Michael Walle
2020-02-20 19:09                                   ` Michael Walle
2020-02-21  9:30                                     ` Tudor.Ambarus
2020-02-25  8:20                                       ` Tudor.Ambarus
2020-02-25  9:25                                         ` Jungseung Lee
2020-01-13  5:59   ` [PATCH v3 3/3] mtd: spi-nor: support lock/unlock for a few Micron chips Jungseung Lee
2020-01-13 12:30     ` John Garry
2020-01-13 12:40       ` Jungseung Lee
2020-01-13 12:45       ` Jungseung Lee
2020-01-13 13:00         ` John Garry
2020-02-17  0:18   ` [PATCH v3 1/3] mtd: spi-nor: introduce SR_BP_SHIFT define Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=132665276.5Rxbr4LpEM@localhost.localdomain \
    --to=tudor.ambarus@microchip.com \
    --cc=js07.lee@gmail.com \
    --cc=js07.lee@samsung.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.