Re: [PATCH v4 1/5] net: Introduce new feature setting ops

[Ben Hutchings <bhutchings@solarflare.com>]

On Tue, 2012-01-24 at 14:54 +0100, Eric Dumazet wrote:
> Le lundi 07 février 2011 à 19:39 +0000, Ben Hutchings a écrit :
> > On Thu, 2011-02-03 at 15:21 +0100, Michał Mirosław wrote:
> > > This introduces a new framework to handle device features setting.
> > > It consists of:
> > >   - new fields in struct net_device:
> > > 	+ hw_features - features that hw/driver supports toggling
> > > 	+ wanted_features - features that user wants enabled, when possible
> > >   - new netdev_ops:
> > > 	+ feat = ndo_fix_features(dev, feat) - API checking constraints for
> > > 		enabling features or their combinations
> > > 	+ ndo_set_features(dev) - API updating hardware state to match
> > > 		changed dev->features
> > >   - new ethtool commands:
> > > 	+ ETHTOOL_GFEATURES/ETHTOOL_SFEATURES: get/set dev->wanted_features
> > > 		and trigger device reconfiguration if resulting dev->features
> > > 		changed
> > > 	+ ETHTOOL_GSTRINGS(ETH_SS_FEATURES): get feature bits names (meaning)
> > > 
> > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> > Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
> > 
> 
> 
> Hi guys
> 
> Do we have any ethtool patch to use these 'new' features ?

I have some unfinished changes to support this.  What I don't want to do
is to add an entirely separate set of options; I want -k/-K to work with
old and new kernel versions, supporting named features as an extension
where available.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.