All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: netdev@vger.kernel.org
Cc: Ben Hutchings <bhutchings@solarflare.com>
Subject: [PATCH v4 0/5] net: Unified offload configuration
Date: Thu,  3 Feb 2011 15:21:21 +0100 (CET)	[thread overview]
Message-ID: <cover.1296741561.git.mirq-linux@rere.qmqm.pl> (raw)

Here's a v4 of the ethtool unification patch series.

What's in it?
 1:
	the patch - implement unified ethtool setting ops
 2..3:
	implement interoperation between old and new ethtool ops
 4:
	include RX checksum in features and plug it into new framework
 5:
	convert loopback device to new framework

What is it good for?
 - unifies driver behaviour wrt hardware offloads
 - removes a lot of boilerplate code from drivers
 - allows better fine-grained control over used offloads

I'm testing this on ARM Gemini arch now. Patch to ethtool userspace tool
will follow this series. I'm not fond of the GFEATURES output I implemented -
please throw some suggestions on it if you can.

Driver conversions stay the same as in v2 - as for v3, I'll keep them
from resending until after the core code gets accepted.

Patches 2,4,5 are unchanged from v3.

Best Regards,
Michał Mirosław


v1: http://marc.info/?l=linux-netdev&m=129245188832643&w=3

Changes from v3:
 - fixed kernel-doc and other comments
 - added HIGHDMA to never-changeable features
 - changed GFEATURES .size interpretation
 - changed feature strings
 - change __ethtool_set_flags() to reject invalid changes

Changes from v2:
 - rebase to net-next after merging v2 leading patches
 - fix missing comma in feature name table
 - force NETIF_F_SOFT_FEATURES in hw_features for simpler code
   (fixes a bug that disallowed changing GSO and GRO state)

Changes from v1:
 - split structures for GFEATURES/SFEATURES
 - naming of feature bits using GSTRINGS ETH_SS_FEATURES
 - strict checking of bits used in SFEATURES call
 - more comments and kernel-doc
 - rebased to net-next after 2.6.37


---

Michał Mirosław (5):
  net: Introduce new feature setting ops
  net: ethtool: use ndo_fix_features for offload setting
  net: use ndo_fix_features for ethtool_ops->set_flags
  net: introduce NETIF_F_RXCSUM
  loopback: convert to hw_features

 drivers/net/loopback.c    |    9 +-
 include/linux/ethtool.h   |   86 ++++++++-
 include/linux/netdevice.h |   48 +++++-
 net/core/dev.c            |   49 ++++-
 net/core/ethtool.c        |  481 ++++++++++++++++++++++++++++-----------------
 5 files changed, 480 insertions(+), 193 deletions(-)

-- 
1.7.2.3


             reply	other threads:[~2011-02-03 14:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03 14:21 Michał Mirosław [this message]
2011-02-03 14:21 ` [PATCH v4 2/5] net: ethtool: use ndo_fix_features for offload setting Michał Mirosław
2011-02-07 21:01   ` David Miller
2011-02-03 14:21 ` [PATCH v4 1/5] net: Introduce new feature setting ops Michał Mirosław
2011-02-07 19:39   ` Ben Hutchings
2011-02-07 20:51     ` David Miller
2011-02-07 20:55       ` David Miller
2012-01-24 13:54     ` Eric Dumazet
2012-01-24 15:30       ` Ben Hutchings
2012-01-24 15:47         ` Eric Dumazet
2012-01-24 19:05         ` Michał Mirosław
2012-01-28  8:30           ` [RFC PATCH] ethtool: implement [GS]FEATURES handling Michał Mirosław
2012-01-28  8:37             ` [RFC PATCH v2] " Michał Mirosław
2012-01-28 10:02               ` Eric Dumazet
2011-02-03 14:21 ` [PATCH v4 3/5] net: use ndo_fix_features for ethtool_ops->set_flags Michał Mirosław
2011-02-07 19:46   ` Ben Hutchings
2011-02-07 21:03     ` David Miller
2011-02-03 14:21 ` [PATCH v4 5/5] loopback: convert to hw_features Michał Mirosław
2011-02-07 21:18   ` David Miller
2011-02-03 14:21 ` [PATCH v4 4/5] net: introduce NETIF_F_RXCSUM Michał Mirosław
2011-02-07 21:12   ` David Miller
2011-02-03 14:21 ` [PATCH v2] ethtool: implement G/SFEATURES calls Michał Mirosław
2011-02-07 21:37 ` [PATCH v4 0/5] net: Unified offload configuration David Miller
2011-02-07 22:49   ` Michał Mirosław
2011-02-07 22:52     ` David Miller
2011-02-07 23:12       ` Michał Mirosław
2011-02-08 19:40   ` David Miller
2011-02-08 23:55     ` Michał Mirosław
2011-02-08 23:58       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1296741561.git.mirq-linux@rere.qmqm.pl \
    --to=mirq-linux@rere.qmqm.pl \
    --cc=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.