* [PATCH] gcc-cross: Don't reference machine specific variables
@ 2012-01-24 17:09 Richard Purdie
2012-01-24 17:11 ` Khem Raj
2012-01-25 13:57 ` Martin Jansa
0 siblings, 2 replies; 3+ messages in thread
From: Richard Purdie @ 2012-01-24 17:09 UTC (permalink / raw)
To: openembedded-core
gcc-cross is installed into a package architecture specific directory
and is not meant to be machine specific. This patch replaces MACHINE_ARCH
with PACKAGE_ARCH to ensure this is really the case.
This was found by examining sstate checksums.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc
index 0b31a8c..6acf8c5 100644
--- a/meta/recipes-devtools/gcc/gcc-cross.inc
+++ b/meta/recipes-devtools/gcc/gcc-cross.inc
@@ -87,12 +87,12 @@ then
exit 1
fi
echo "lappend boards_dir [pwd]/../../.." > ${B}/site.exp
- echo "load_generic_config \"unix\"" > ${B}/${MACHINE_ARCH}.exp
- echo "set_board_info username \$user" >> ${B}/${MACHINE_ARCH}.exp
- echo "set_board_info rsh_prog ssh" >> ${B}/${MACHINE_ARCH}.exp
- echo "set_board_info rcp_prog scp" >> ${B}/${MACHINE_ARCH}.exp
- echo "set_board_info hostname \$target" >> ${B}/${MACHINE_ARCH}.exp
- DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${MACHINE_ARCH}\$@"
+ echo "load_generic_config \"unix\"" > ${B}/${PACKAGE_ARCH}.exp
+ echo "set_board_info username \$user" >> ${B}/${PACKAGE_ARCH}.exp
+ echo "set_board_info rsh_prog ssh" >> ${B}/${PACKAGE_ARCH}.exp
+ echo "set_board_info rcp_prog scp" >> ${B}/${PACKAGE_ARCH}.exp
+ echo "set_board_info hostname \$target" >> ${B}/${PACKAGE_ARCH}.exp
+ DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${PACKAGE_ARCH}\$@"
STOP
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gcc-cross: Don't reference machine specific variables
2012-01-24 17:09 [PATCH] gcc-cross: Don't reference machine specific variables Richard Purdie
@ 2012-01-24 17:11 ` Khem Raj
2012-01-25 13:57 ` Martin Jansa
1 sibling, 0 replies; 3+ messages in thread
From: Khem Raj @ 2012-01-24 17:11 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On Tue, Jan 24, 2012 at 9:09 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> gcc-cross is installed into a package architecture specific directory
> and is not meant to be machine specific. This patch replaces MACHINE_ARCH
> with PACKAGE_ARCH to ensure this is really the case.
>
> This was found by examining sstate checksums.
This change is fine. Since its only a script name it does not matter
what its called.
Acked-by: Khem Raj <raj.khem@gmail.com>
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc
> index 0b31a8c..6acf8c5 100644
> --- a/meta/recipes-devtools/gcc/gcc-cross.inc
> +++ b/meta/recipes-devtools/gcc/gcc-cross.inc
> @@ -87,12 +87,12 @@ then
> exit 1
> fi
> echo "lappend boards_dir [pwd]/../../.." > ${B}/site.exp
> - echo "load_generic_config \"unix\"" > ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info username \$user" >> ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info rsh_prog ssh" >> ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info rcp_prog scp" >> ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info hostname \$target" >> ${B}/${MACHINE_ARCH}.exp
> - DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${MACHINE_ARCH}\$@"
> + echo "load_generic_config \"unix\"" > ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info username \$user" >> ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info rsh_prog ssh" >> ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info rcp_prog scp" >> ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info hostname \$target" >> ${B}/${PACKAGE_ARCH}.exp
> + DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${PACKAGE_ARCH}\$@"
>
> STOP
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gcc-cross: Don't reference machine specific variables
2012-01-24 17:09 [PATCH] gcc-cross: Don't reference machine specific variables Richard Purdie
2012-01-24 17:11 ` Khem Raj
@ 2012-01-25 13:57 ` Martin Jansa
1 sibling, 0 replies; 3+ messages in thread
From: Martin Jansa @ 2012-01-25 13:57 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1968 bytes --]
On Tue, Jan 24, 2012 at 05:09:30PM +0000, Richard Purdie wrote:
> gcc-cross is installed into a package architecture specific directory
> and is not meant to be machine specific. This patch replaces MACHINE_ARCH
> with PACKAGE_ARCH to ensure this is really the case.
>
> This was found by examining sstate checksums.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Acked-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc
> index 0b31a8c..6acf8c5 100644
> --- a/meta/recipes-devtools/gcc/gcc-cross.inc
> +++ b/meta/recipes-devtools/gcc/gcc-cross.inc
> @@ -87,12 +87,12 @@ then
> exit 1
> fi
> echo "lappend boards_dir [pwd]/../../.." > ${B}/site.exp
> - echo "load_generic_config \"unix\"" > ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info username \$user" >> ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info rsh_prog ssh" >> ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info rcp_prog scp" >> ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info hostname \$target" >> ${B}/${MACHINE_ARCH}.exp
> - DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${MACHINE_ARCH}\$@"
> + echo "load_generic_config \"unix\"" > ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info username \$user" >> ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info rsh_prog ssh" >> ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info rcp_prog scp" >> ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info hostname \$target" >> ${B}/${PACKAGE_ARCH}.exp
> + DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${PACKAGE_ARCH}\$@"
>
> STOP
>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-25 14:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-24 17:09 [PATCH] gcc-cross: Don't reference machine specific variables Richard Purdie
2012-01-24 17:11 ` Khem Raj
2012-01-25 13:57 ` Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.