All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
To: Patrice Mandin <mandin.patrice-1tsiiZ//OF9QFI55V6+gNQ@public.gmane.org>
Cc: Nouveau Dev List
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] nvfx: fix nv3x fallout from state validation changes
Date: Mon, 30 Jan 2012 19:35:00 +0100	[thread overview]
Message-ID: <1327948500.1722.6.camel@tellur> (raw)
In-Reply-To: <20120126205942.7416fabb.mandin.patrice-1tsiiZ//OF9QFI55V6+gNQ@public.gmane.org>

Am Donnerstag, den 26.01.2012, 20:59 +0100 schrieb Patrice Mandin:
> Le Tue, 24 Jan 2012 09:54:31 +0100
> Lucas Stach <dev@lynxeye.de> a écrit:
> 
> > From c998f732d42da5e962fe5da294493132c3e8dc5f Mon Sep 17 00:00:00 2001
> > From: Lucas Stach <dev@lynxeye.de>
> > Date: Tue, 24 Jan 2012 09:46:32 +0100
> > Subject: [PATCH] nvfx: fix nv3x fallout from state validation changes
> > 
> > Apparently nv3x needs some curde hacks to work properly. This
> > is clearly not the right fix, but it's the behaviour of the old
> > code and fixes regressions seen by users.
> 
> Hello,
> 
> Sorry Lucas, but I finally found a test case I have forgotten, that
> would maybe need reverting your patches.
> 
> In mesa-demos/src/demos you'll find fbo_firecube test program that have
> the scene misrenderered (the scene part that is rendered and used as
> texture on the cube).
> 
> As far as I remember now, render temp stuff was used to handle fbo
> combinations supported on nv40 but not on nv30, or something like that.
> 

Thanks for the hint. Now that I finally own a nv35 myself, I can
reproduce the issue and I'm investigating. I'm not yet sure why it
misrenders, normally we should just hit an assert in case of invalid
formats.

I will try to debug this, but I can't promise to get results before next
week, because FOSDEM wants my attention.

Thanks,
Lucas

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

      parent reply	other threads:[~2012-01-30 18:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-24  8:54 [PATCH] nvfx: fix nv3x fallout from state validation changes Lucas Stach
2012-01-26 19:59 ` Patrice Mandin
     [not found]   ` <20120126205942.7416fabb.mandin.patrice-1tsiiZ//OF9QFI55V6+gNQ@public.gmane.org>
2012-01-30 18:35     ` Lucas Stach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327948500.1722.6.camel@tellur \
    --to=dev-8ppwabl0hbeelga04laivw@public.gmane.org \
    --cc=mandin.patrice-1tsiiZ//OF9QFI55V6+gNQ@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.