Re: [PATCH] kvm tools: Fix segfault when failing to initialize KVM

[Sasha Levin <levinsasha928@gmail.com>]

On Wed, 2012-02-01 at 09:05 +0200, Pekka Enberg wrote:
> On Tue, 31 Jan 2012, Sasha Levin wrote:
> > Might happen when hardware virtualization is not supported.
> >
> > Reported-by: Ingo Molnar <mingo@elte.hu>
> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> > ---
> > tools/kvm/builtin-run.c |    4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
> > index 6ded1d2..a67faf8 100644
> > --- a/tools/kvm/builtin-run.c
> > +++ b/tools/kvm/builtin-run.c
> > @@ -997,6 +997,10 @@ static int kvm_cmd_run_init(int argc, const char **argv)
> > 	}
> >
> > 	kvm = kvm__init(dev, hugetlbfs_path, ram_size, guest_name);
> > +	if (IS_ERR_OR_NULL(kvm)) {
> > +		r = PTR_ERR(kvm);
> 
> How is this going to work when 'kvm' is NULL? It'd be best if kvm_init() 
> never returned NULL on error.

Actually, it never does, I'm not sure why I put IS_ERR_OR_NULL there.

I'll resend that one.

-- 

Sasha.