From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: Sasha Levin <levinsasha928@gmail.com>,
mingo@elte.hu, asias.hejun@gmail.com, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm tools: Fix segfault when failing to initialize KVM
Date: Wed, 1 Feb 2012 11:28:52 +0400 [thread overview]
Message-ID: <20120201072852.GB1924@moon> (raw)
In-Reply-To: <alpine.LFD.2.02.1202010924190.2450@tux.localdomain>
On Wed, Feb 01, 2012 at 09:26:00AM +0200, Pekka Enberg wrote:
> On Wed, 1 Feb 2012, Cyrill Gorcunov wrote:
> >I suspect we need something like
> >---
> >tools/kvm/builtin-run.c | 5 +++++
> >tools/kvm/kvm.c | 2 +-
> >2 files changed, 6 insertions(+), 1 deletion(-)
> >
> >Index: linux-2.6.git/tools/kvm/builtin-run.c
> >===================================================================
> >--- linux-2.6.git.orig/tools/kvm/builtin-run.c
> >+++ linux-2.6.git/tools/kvm/builtin-run.c
> >@@ -997,6 +997,11 @@ static int kvm_cmd_run_init(int argc, co
> > }
> >
> > kvm = kvm__init(dev, hugetlbfs_path, ram_size, guest_name);
> >+ if (IS_ERR(kvm)) {
> >+ r = (int)PTR_ERR(kvm);
>
> The cast is not needed.
>
Yeah, it's leftover from draft patch ;) Sasha, would you make
some new version or I should create new patch?
Cyrill
next prev parent reply other threads:[~2012-02-01 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 2:07 [PATCH] kvm tools: Fix segfault when failing to initialize KVM Sasha Levin
2012-02-01 7:05 ` Pekka Enberg
2012-02-01 7:19 ` Cyrill Gorcunov
2012-02-01 7:26 ` Pekka Enberg
2012-02-01 7:28 ` Cyrill Gorcunov [this message]
2012-02-01 12:48 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201072852.GB1924@moon \
--to=gorcunov@openvz.org \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.