From: Richard Laager <rlaager@wiktel.com>
To: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] diskfilter: Treat an unrecognized RAID level as an error
Date: Sat, 04 Feb 2012 17:00:55 -0600 [thread overview]
Message-ID: <1328396455.5007.89.camel@watermelon.coderich.net> (raw)
In-Reply-To: <4F2DB177.8080303@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
On Sat, 2012-02-04 at 23:30 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> On 04.02.2012 23:01, Richard Laager wrote:
> > disk/diskfilter.c: In function 'grub_diskfilter_make_raid':
> > disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in
> > this function [-Werror=uninitialized]
> >
> > Perhaps my patch should use assert() instead of return NULL?
> We don't use assert since assert failures are usually not fatal. And
> failing to boot just because some otherwise unused disk has a RAID-9
> isn't reasonable.
Noted. I see now that Grégoire Sutre already submitted the same fix. I
don't know how I missed that mail before. Sorry for the noise. At least
I learned about GRUB's take on assert().
--
Richard
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-02-04 23:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 22:01 [PATCH] diskfilter: Treat an unrecognized RAID level as an error Richard Laager
2012-02-04 22:30 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-04 23:00 ` Richard Laager [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328396455.5007.89.camel@watermelon.coderich.net \
--to=rlaager@wiktel.com \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.