From: Richard Laager <rlaager@wiktel.com>
To: Jordan Uggla <jordan.uggla@gmail.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Don't create grubenv on ZFS
Date: Sat, 04 Feb 2012 19:26:02 -0600 [thread overview]
Message-ID: <1328405162.5007.258.camel@watermelon.coderich.net> (raw)
In-Reply-To: <CAHh2SOQps3sbHNJ_hp-i7s2SBCbo6Vz=mLkhUO8S7Rfc1rjWjQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
You make good points. I don't have a problem with the idea that save_env
should throw an error when it can't actually *save* the grubenv.
So a better way to look at my problem is to say, "I don't want my
grub.cfg to call save_env by default."
This then becomes an downstream Ubuntu bug, because my grub.cfg is only
calling save_env by default for recordfail. I've submitted a patch to
Ubuntu which disables recordfail for these filesystems:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/913336/comments/7
So I withdraw zfs-no-grubenv.patch.
--
Richard
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-02-05 1:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 11:16 [PATCH] Don't create grubenv on ZFS Richard Laager
2012-02-03 10:05 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-03 10:07 ` Richard Laager
2012-02-03 10:22 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-03 11:59 ` Richard Laager
2012-02-04 22:34 ` Jordan Uggla
2012-02-05 1:26 ` Richard Laager [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328405162.5007.258.camel@watermelon.coderich.net \
--to=rlaager@wiktel.com \
--cc=grub-devel@gnu.org \
--cc=jordan.uggla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.