From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: scsi_error: do not allow IO errors with certain ILLEGAL_REQUEST sense to be retryable
Date: Mon, 13 Feb 2012 14:38:53 -0500 [thread overview]
Message-ID: <1329161933.20751.31.camel@dabdike> (raw)
In-Reply-To: <20120213193615.GA10349@redhat.com>
On Mon, 2012-02-13 at 14:36 -0500, Mike Snitzer wrote:
> On Mon, Feb 13 2012 at 2:16pm -0500,
> Martin K. Petersen <martin.petersen@oracle.com> wrote:
>
> > >>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
> >
> > >> I don't have a fundamental problem with your patch. But since we
> > >> explicitly handle ILLEGAL REQUEST with 0x20 and 0x24 in sd.c I wonder
> > >> what's broken? We should disable discard support if the WRITE SAME w/
> > >> UNMAP fails.
> >
> > Mike> Yeah, I thought the disabling would be sufficient too. But
> > Mike> unfortunately multipath doesn't inspect the request it is retrying
> > Mike> (after it fails the path the request just failed on).
> >
> > Well, we shouldn't be returning something that multipath should ever act
> > on.
> >
> > I think I understand what's going on. Can you try the following patch?
>
> Looks good to me (small nit below), it'll solve the immediate problem,
> I'll pass it on. Please add my:
>
> Acked-by: Mike Snitzer <snitzer@redhat.com>
>
> But I also think establishing a baseline of TARGET_ERROR for certain
> ILLEGAL REQUEST is still sane and should go in too...
So someone still needs to package up the final agreed version with a
nice changelog and send it to the list ...
James
next prev parent reply other threads:[~2012-02-13 19:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 20:31 [PATCH] scsi_error: do not allow IO errors with certain ILLEGAL_REQUEST sense to be retryable Mike Snitzer
2011-12-02 21:04 ` James Bottomley
2011-12-02 22:04 ` Mike Snitzer
2011-12-06 21:07 ` [PATCH] " Martin K. Petersen
2011-12-06 21:27 ` Mike Snitzer
2011-12-06 22:03 ` Martin K. Petersen
2011-12-06 22:42 ` Mike Snitzer
2012-02-13 16:29 ` Mike Snitzer
2012-02-13 17:53 ` Martin K. Petersen
2012-02-13 18:13 ` Mike Snitzer
2012-02-13 18:59 ` Mike Snitzer
2012-02-13 19:16 ` Martin K. Petersen
2012-02-13 19:36 ` Mike Snitzer
2012-02-13 19:38 ` James Bottomley [this message]
2012-02-13 23:35 ` [PATCH v2] [SCSI] scsi_error: classify some ILLEGAL_REQUEST sense as a permanent TARGET_ERROR Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329161933.20751.31.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.