From: Mike Snitzer <snitzer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org,
James Bottomley <jbottomley@parallels.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: scsi_error: do not allow IO errors with certain ILLEGAL_REQUEST sense to be retryable
Date: Tue, 6 Dec 2011 17:42:19 -0500 [thread overview]
Message-ID: <20111206224218.GA31543@redhat.com> (raw)
In-Reply-To: <yq1vcptpdch.fsf@sermon.lab.mkp.net>
On Tue, Dec 06 2011 at 5:03pm -0500,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
> >>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
>
> Mike> Regardless, shouldn't the SCSI midlayer classify such
> Mike> ILLEGAL_REQUEST sense, with an add. sense I listed in the patch,
> Mike> as a target error?
>
> Well, even SUCCESS should cause the I/O to be aborted.
As I replied to James, yes SUCCESS does cause the IO to fail, but the
discard gets retried by multipath.
Returning TARGET_ERROR enables the block layer to return -EREMOTEIO
which multipath will immediately pass up (rather than the normal fail
path and retry).
> I assume this is the RHEL6 kernel? Did you backport my provisioning
> updates that brings the heuristics in sync with SBC-3 (#c98a0e)?
Yes, that update was pulled in to RHEL6.2 (released today). But this
issue is a concern for both upstream and RHEL6 (and any other distro
with a recent kernel).
next prev parent reply other threads:[~2011-12-06 22:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 20:31 [PATCH] scsi_error: do not allow IO errors with certain ILLEGAL_REQUEST sense to be retryable Mike Snitzer
2011-12-02 21:04 ` James Bottomley
2011-12-02 22:04 ` Mike Snitzer
2011-12-06 21:07 ` [PATCH] " Martin K. Petersen
2011-12-06 21:27 ` Mike Snitzer
2011-12-06 22:03 ` Martin K. Petersen
2011-12-06 22:42 ` Mike Snitzer [this message]
2012-02-13 16:29 ` Mike Snitzer
2012-02-13 17:53 ` Martin K. Petersen
2012-02-13 18:13 ` Mike Snitzer
2012-02-13 18:59 ` Mike Snitzer
2012-02-13 19:16 ` Martin K. Petersen
2012-02-13 19:36 ` Mike Snitzer
2012-02-13 19:38 ` James Bottomley
2012-02-13 23:35 ` [PATCH v2] [SCSI] scsi_error: classify some ILLEGAL_REQUEST sense as a permanent TARGET_ERROR Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206224218.GA31543@redhat.com \
--to=snitzer@redhat.com \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.