All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 2/5] 4.0 tests: remove 1-second wait on client creation
Date: Wed, 15 Feb 2012 17:45:17 -0500	[thread overview]
Message-ID: <1329345920-16608-3-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1329345920-16608-1-git-send-email-bfields@redhat.com>

From: "J. Bruce Fields" <bfields@redhat.com>

I can't figure out why this wait is necessary, and it slows things down.
(Noticed while trying to write a race-condition reproducer requiring
more precise timing.)

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 nfs4.0/nfs4lib.py |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/nfs4.0/nfs4lib.py b/nfs4.0/nfs4lib.py
index c6d6781..7185057 100644
--- a/nfs4.0/nfs4lib.py
+++ b/nfs4.0/nfs4lib.py
@@ -293,7 +293,6 @@ class NFS4Client(rpc.RPCClient, nfs4_ops.NFS4Operations):
         self.cb_control = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
         while 1:
             try:
-                time.sleep(1)
                 self.cb_control.connect(('127.0.0.1', self.cb_server.port))
                 break
             except socket.error:
-- 
1.7.5.4


  parent reply	other threads:[~2012-02-15 22:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15 22:45 pynfs: cleanup and turn off some tests by default J. Bruce Fields
2012-02-15 22:45 ` [PATCH 1/5] 4.0 tests: kill "Starting Call Back server stub" printk J. Bruce Fields
2012-02-15 22:45 ` J. Bruce Fields [this message]
2012-02-15 22:45 ` [PATCH 3/5] 4.1 server tests: don't run pnfs tests by default J. Bruce Fields
2012-02-15 22:45 ` [PATCH 4/5] 4.1 server tests: don't run utf8 " J. Bruce Fields
2012-02-15 22:45 ` [PATCH 5/5] 4.0 server tests: remove RD12 (incorrect test) J. Bruce Fields
2012-02-16  0:28 ` pynfs: cleanup and turn off some tests by default Boaz Harrosh
2012-02-16  1:28   ` J. Bruce Fields
2012-02-16  3:31     ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329345920-16608-3-git-send-email-bfields@redhat.com \
    --to=bfields@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.