All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: <linux-nfs@vger.kernel.org>
Subject: Re: pynfs: cleanup and turn off some tests by default
Date: Wed, 15 Feb 2012 19:31:16 -0800	[thread overview]
Message-ID: <4F3C7884.5050802@panasas.com> (raw)
In-Reply-To: <20120216012805.GE19298@pad.fieldses.org>

On 02/15/2012 05:28 PM, J. Bruce Fields wrote:
> On Wed, Feb 15, 2012 at 04:28:01PM -0800, Boaz Harrosh wrote:
>> On 02/15/2012 02:45 PM, J. Bruce Fields wrote:
>>> I've committed the following to my pynfs repo.
>>>
>>> Fix a couple minor problems found while working on a bug, then turn off
>>> utf8 and pnfs tests by default (both can still be requested by adding
>>> "utf8" or "pnfs", respectively, on the commandline), and remove one
>>> incorrect test.
>>>
>>> I'd like to get to the point where the pynfs tests all pass against a
>>> reasonable server.  That means fixing the server where necessary, of
>>> course, but also not complaining about unimplemented optional features
>>> or about stuff we don't plan to fix.
>>>
>>
>> Can't we "auto detect" the pnfs option. Request a pnfs access if failed
>> proceed to the next set of tests, if successful continue to test "pnfs"
> 
> Good idea!  I think you'd still want "pnfs" and "nopnfs" options: "pnfs"
> for "I expect this server to support pnfs, and if it doesn't report that
> as a bug!", and "nopnfs" for: "this server claims to support  pnfs but
> please just don't even bother telling me how buggy it is, I already
> know".
> 

Sounds good

> But just turning it off by default was a minute's worth of
> search-and-replace for me, and I don't have the time for more right now.
> So that's a project looking for a volunteer.
> 

NP, thanks for the fixes so far. We'll probably add pynfs testing to our
Ganesha testing rig. When we do we'll look into it. That is if no one
bits us to it, (Hopefully ;-) )

> --b.

Thanks
Boaz

      reply	other threads:[~2012-02-16  3:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15 22:45 pynfs: cleanup and turn off some tests by default J. Bruce Fields
2012-02-15 22:45 ` [PATCH 1/5] 4.0 tests: kill "Starting Call Back server stub" printk J. Bruce Fields
2012-02-15 22:45 ` [PATCH 2/5] 4.0 tests: remove 1-second wait on client creation J. Bruce Fields
2012-02-15 22:45 ` [PATCH 3/5] 4.1 server tests: don't run pnfs tests by default J. Bruce Fields
2012-02-15 22:45 ` [PATCH 4/5] 4.1 server tests: don't run utf8 " J. Bruce Fields
2012-02-15 22:45 ` [PATCH 5/5] 4.0 server tests: remove RD12 (incorrect test) J. Bruce Fields
2012-02-16  0:28 ` pynfs: cleanup and turn off some tests by default Boaz Harrosh
2012-02-16  1:28   ` J. Bruce Fields
2012-02-16  3:31     ` Boaz Harrosh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3C7884.5050802@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=bfields@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.