From: Marcel Holtmann <marcel@holtmann.org>
To: Joe Perches <joe@perches.com>
Cc: "Gustavo F. Padovan" <padovan@profusion.mobi>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH V2 2/3] bluetooth: Convert BT_ERR/BT_INFO to bt_err/bt_info
Date: Fri, 17 Feb 2012 09:40:18 +0100 [thread overview]
Message-ID: <1329468018.28848.133.camel@aeonflux> (raw)
In-Reply-To: <6737e9dc6d2528f9c94c122709a40e4c23c9477a.1329461203.git.joe@perches.com>
Hi Joe,
> Use the more common kernel style functions rather than
> an upper case macro.
>
> Add newlines to end of formats.
> Coalesce formats, align arguments.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/bluetooth/ath3k.c | 46 +++++++-------
> drivers/bluetooth/bcm203x.c | 24 ++++----
> drivers/bluetooth/bfusb.c | 67 +++++++++++---------
> drivers/bluetooth/bluecard_cs.c | 17 +++---
> drivers/bluetooth/bpa10x.c | 18 +++---
> drivers/bluetooth/bt3c_cs.c | 36 ++++++-----
> drivers/bluetooth/btmrvl_debugfs.c | 2 +-
> drivers/bluetooth/btmrvl_main.c | 39 ++++++------
> drivers/bluetooth/btmrvl_sdio.c | 122 +++++++++++++++++-------------------
> drivers/bluetooth/btsdio.c | 2 +-
> drivers/bluetooth/btuart_cs.c | 23 ++++---
> drivers/bluetooth/btusb.c | 38 ++++++------
> drivers/bluetooth/btwilink.c | 29 ++++-----
> drivers/bluetooth/dtl1_cs.c | 19 +++---
> drivers/bluetooth/hci_ath.c | 6 +-
> drivers/bluetooth/hci_bcsp.c | 50 ++++++++-------
> drivers/bluetooth/hci_h4.c | 8 +-
> drivers/bluetooth/hci_ldisc.c | 14 ++--
> drivers/bluetooth/hci_ll.c | 33 ++++++----
> drivers/bluetooth/hci_vhci.c | 6 +-
> include/net/bluetooth/hci_core.h | 6 +-
> net/bluetooth/af_bluetooth.c | 4 +-
> net/bluetooth/bnep/core.c | 4 +-
> net/bluetooth/bnep/netdev.c | 2 +-
> net/bluetooth/bnep/sock.c | 4 +-
> net/bluetooth/cmtp/capi.c | 19 +++---
> net/bluetooth/cmtp/core.c | 8 +-
> net/bluetooth/cmtp/sock.c | 4 +-
> net/bluetooth/hci_core.c | 24 ++++----
> net/bluetooth/hci_event.c | 16 +++---
> net/bluetooth/hci_sock.c | 6 +-
> net/bluetooth/hci_sysfs.c | 2 +-
> net/bluetooth/hidp/core.c | 14 +++--
> net/bluetooth/hidp/sock.c | 4 +-
> net/bluetooth/l2cap_core.c | 32 +++++-----
> net/bluetooth/l2cap_sock.c | 6 +-
> net/bluetooth/mgmt.c | 6 +-
> net/bluetooth/rfcomm/core.c | 16 +++---
> net/bluetooth/rfcomm/sock.c | 8 +-
> net/bluetooth/rfcomm/tty.c | 18 +++---
> net/bluetooth/sco.c | 8 +-
> net/bluetooth/smp.c | 14 ++--
> 42 files changed, 419 insertions(+), 405 deletions(-)
I leave this up to Johan if he can get it merged without having to redo
the patch. Otherwise it might have to wait a little bit.
If you would split drivers/ from include/ and net/ I think it has more
likelihood that at least that one can be merged easily.
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2012-02-17 8:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 7:32 [PATCH V2 0/3] bluetooth: Shrink object size, use current logging style Joe Perches
2012-02-17 7:32 ` [PATCH V2 1/3] bluetooth: Add logging functions bt_info and bt_err Joe Perches
2012-02-17 8:37 ` Marcel Holtmann
2012-02-17 9:38 ` Johan Hedberg
2012-02-17 7:32 ` [PATCH V2 2/3] bluetooth: Convert BT_ERR/BT_INFO to bt_err/bt_info Joe Perches
2012-02-17 8:40 ` Marcel Holtmann [this message]
2012-02-17 9:41 ` Johan Hedberg
2012-02-17 9:41 ` Johan Hedberg
2012-02-17 18:12 ` Joe Perches
2012-02-17 7:32 ` [PATCH V2 3/3] bluetooth: Convert BT_DBG to pr_debug Joe Perches
2012-02-17 8:42 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329468018.28848.133.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.