From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Joe Perches <joe@perches.com>,
"Gustavo F. Padovan" <padovan@profusion.mobi>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/3] bluetooth: Add logging functions bt_info and bt_err
Date: Fri, 17 Feb 2012 11:38:47 +0200 [thread overview]
Message-ID: <20120217093847.GA12814@x220> (raw)
In-Reply-To: <1329467859.28848.130.camel@aeonflux>
Hi,
On Fri, Feb 17, 2012, Marcel Holtmann wrote:
> Hi Joe,
>
> > Use specific logging functions instead of a generic
> > bt_printk function can save some text.
> >
> > Remove now unused bt_printk function.
> > Add compatibility BT_INFO and BT_ERR macros.
> >
> > (compiled x86 and defconfig with bluetooth and all bluetooth drivers)
> >
> > $ size net/bluetooth/built-in.o*
> > text data bss dec hex filename
> > 381662 20072 100416 502150 7a986 net/bluetooth/built-in.o.allyesconfig.new
> > 382463 20072 100400 502935 7ac97 net/bluetooth/built-in.o.allyesconfig.old
> > 126635 1388 132 128155 1f49b net/bluetooth/built-in.o.defconfig.new
> > 127175 1388 132 128695 1f6b7 net/bluetooth/built-in.o.defconfig.old
> >
> > $ size drivers/bluetooth/built-in.o*
> > 127575 8976 29476 166027 2888b drivers/bluetooth/built-in.o.allyesconfig.new
> > 129512 8976 29516 168004 29044 drivers/bluetooth/built-in.o.allyesconfig.old
> > 52998 3292 156 56446 dc7e drivers/bluetooth/built-in.o.defconfig.new
> > 54358 3292 156 57806 e1ce drivers/bluetooth/built-in.o.defconfig.old
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > include/net/bluetooth/bluetooth.h | 14 ++++++++------
> > net/bluetooth/lib.c | 27 ++++++++++++++++++++++++---
> > 2 files changed, 32 insertions(+), 9 deletions(-)
>
> lets try to get at least this patch merged. I hope we don't have too
> many conflicts.
>
> Acked-by: Marcel Holtmann <marcel@holtmann.org>
Applied to my bluetooth-next tree. Thanks.
Johan
next prev parent reply other threads:[~2012-02-17 9:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 7:32 [PATCH V2 0/3] bluetooth: Shrink object size, use current logging style Joe Perches
2012-02-17 7:32 ` [PATCH V2 1/3] bluetooth: Add logging functions bt_info and bt_err Joe Perches
2012-02-17 8:37 ` Marcel Holtmann
2012-02-17 9:38 ` Johan Hedberg [this message]
2012-02-17 7:32 ` [PATCH V2 2/3] bluetooth: Convert BT_ERR/BT_INFO to bt_err/bt_info Joe Perches
2012-02-17 8:40 ` Marcel Holtmann
2012-02-17 9:41 ` Johan Hedberg
2012-02-17 9:41 ` Johan Hedberg
2012-02-17 18:12 ` Joe Perches
2012-02-17 7:32 ` [PATCH V2 3/3] bluetooth: Convert BT_DBG to pr_debug Joe Perches
2012-02-17 8:42 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217093847.GA12814@x220 \
--to=johan.hedberg@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.