From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Kautuk Consul <consul.kautuk@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rmap: Staticize page_referenced_file and page_referenced_anon
Date: Fri, 17 Feb 2012 16:15:08 +0100 [thread overview]
Message-ID: <1329491708.2293.277.camel@twins> (raw)
In-Reply-To: <1329488869-7270-1-git-send-email-consul.kautuk@gmail.com>
On Fri, 2012-02-17 at 09:27 -0500, Kautuk Consul wrote:
> Staticize the page_referenced_anon and page_referenced_file
> functions.
> These functions are called only from page_referenced.
Subject and changelog say: staticize, which I read to mean: make static.
Yet what the patch does is make them inline ?!?
Also, if they're static and there's only a single callsite, gcc will
already inline them, does this patch really make a difference?
> -static int page_referenced_anon(struct page *page,
> +static inline int page_referenced_anon(struct page *page,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Kautuk Consul <consul.kautuk@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rmap: Staticize page_referenced_file and page_referenced_anon
Date: Fri, 17 Feb 2012 16:15:08 +0100 [thread overview]
Message-ID: <1329491708.2293.277.camel@twins> (raw)
In-Reply-To: <1329488869-7270-1-git-send-email-consul.kautuk@gmail.com>
On Fri, 2012-02-17 at 09:27 -0500, Kautuk Consul wrote:
> Staticize the page_referenced_anon and page_referenced_file
> functions.
> These functions are called only from page_referenced.
Subject and changelog say: staticize, which I read to mean: make static.
Yet what the patch does is make them inline ?!?
Also, if they're static and there's only a single callsite, gcc will
already inline them, does this patch really make a difference?
> -static int page_referenced_anon(struct page *page,
> +static inline int page_referenced_anon(struct page *page,
next prev parent reply other threads:[~2012-02-17 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 14:27 [PATCH 1/2] rmap: Staticize page_referenced_file and page_referenced_anon Kautuk Consul
2012-02-17 14:27 ` Kautuk Consul
2012-02-17 15:15 ` Peter Zijlstra [this message]
2012-02-17 15:15 ` Peter Zijlstra
2012-02-17 15:19 ` Kautuk Consul
2012-02-17 15:19 ` Kautuk Consul
2012-02-17 15:27 ` Kautuk Consul
2012-02-17 15:27 ` Kautuk Consul
2012-02-17 18:07 ` Peter Zijlstra
2012-02-17 18:07 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329491708.2293.277.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=consul.kautuk@gmail.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.