All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: joro@8bytes.org, will@kernel.org, linux-rockchip@lists.infradead.org
Cc: iommu@lists.linux.dev, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, heiko@sntech.de,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH 0/3] Rockchip IOMMU fixes
Date: Fri, 14 Mar 2025 16:24:08 +0100	[thread overview]
Message-ID: <13295142.O9o76ZdvQC@workhorse> (raw)
In-Reply-To: <cover.1741886382.git.robin.murphy@arm.com>

On Thursday, 13 March 2025 18:31:03 Central European Standard Time Robin 
Murphy wrote:
> Hi all,
> 
> I was expecting my DT probing change to flush out issues, and it seems
> some weaknesses in rockchip-iommu were the first to show. The first two
> patches here get things working again for me on my RK3399 NanoPC-T4
> (with a console on HDMI exercising the VOP MMU), the 3rd patch just
> finishes the cleanup since I was there and could test it.
> 
> Thanks,
> Robin.
> 
> Robin Murphy (3):
>   iommu/rockchip: Allocate per-device data sensibly
>   iommu/rockchip: Register in a sensible order
>   iommu/rockchip: Retire global dma_dev workaround
> 
>  drivers/iommu/rockchip-iommu.c | 61 +++++++++++++++-------------------
>  1 file changed, 26 insertions(+), 35 deletions(-)

Tested this series on an RK3576, which indeed fixes the boot panic I get with 
next-20250314. After looking at the patches with the full function context, I 
can't see any obvious issues.

For the whole series:

Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Kind regards,
Nicolas Frattaroli




WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: joro@8bytes.org, will@kernel.org, linux-rockchip@lists.infradead.org
Cc: iommu@lists.linux.dev, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, heiko@sntech.de,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH 0/3] Rockchip IOMMU fixes
Date: Fri, 14 Mar 2025 16:24:08 +0100	[thread overview]
Message-ID: <13295142.O9o76ZdvQC@workhorse> (raw)
In-Reply-To: <cover.1741886382.git.robin.murphy@arm.com>

On Thursday, 13 March 2025 18:31:03 Central European Standard Time Robin 
Murphy wrote:
> Hi all,
> 
> I was expecting my DT probing change to flush out issues, and it seems
> some weaknesses in rockchip-iommu were the first to show. The first two
> patches here get things working again for me on my RK3399 NanoPC-T4
> (with a console on HDMI exercising the VOP MMU), the 3rd patch just
> finishes the cleanup since I was there and could test it.
> 
> Thanks,
> Robin.
> 
> Robin Murphy (3):
>   iommu/rockchip: Allocate per-device data sensibly
>   iommu/rockchip: Register in a sensible order
>   iommu/rockchip: Retire global dma_dev workaround
> 
>  drivers/iommu/rockchip-iommu.c | 61 +++++++++++++++-------------------
>  1 file changed, 26 insertions(+), 35 deletions(-)

Tested this series on an RK3576, which indeed fixes the boot panic I get with 
next-20250314. After looking at the patches with the full function context, I 
can't see any obvious issues.

For the whole series:

Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Kind regards,
Nicolas Frattaroli



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2025-03-14 15:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13 17:31 [PATCH 0/3] Rockchip IOMMU fixes Robin Murphy
2025-03-13 17:31 ` Robin Murphy
2025-03-13 17:31 ` [PATCH 1/3] iommu/rockchip: Allocate per-device data sensibly Robin Murphy
2025-03-13 17:31   ` Robin Murphy
2025-03-13 17:31 ` [PATCH 2/3] iommu/rockchip: Register in a sensible order Robin Murphy
2025-03-13 17:31   ` Robin Murphy
2025-03-13 17:31 ` [PATCH 3/3] iommu/rockchip: Retire global dma_dev workaround Robin Murphy
2025-03-13 17:31   ` Robin Murphy
2025-03-14 15:24 ` Nicolas Frattaroli [this message]
2025-03-14 15:24   ` [PATCH 0/3] Rockchip IOMMU fixes Nicolas Frattaroli
2025-03-16  5:03 ` Dang Huynh
2025-03-16  5:03   ` Dang Huynh
2025-03-17 11:55 ` Quentin Schulz
2025-03-17 11:55   ` Quentin Schulz
2025-03-20  7:58 ` Joerg Roedel
2025-03-20  7:58   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13295142.O9o76ZdvQC@workhorse \
    --to=nicolas.frattaroli@collabora.com \
    --cc=heiko@sntech.de \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.