From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH] regulator: Set delay to 0 if set_voltage_time_sel callback returns error
Date: Fri, 24 Feb 2012 15:17:46 +0800 [thread overview]
Message-ID: <1330067866.27530.1.camel@phoenix> (raw)
rdev->desc->ops->set_voltage_time_sel may return negative error code.
Set delay to 0 if we got error.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/core.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index beeeb7f..61448b6 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1892,6 +1892,8 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev,
old_selector = ret;
delay = rdev->desc->ops->set_voltage_time_sel(rdev,
old_selector, selector);
+ if (delay < 0)
+ delay = 0;
}
if (best_val != INT_MAX) {
--
1.7.5.4
next reply other threads:[~2012-02-24 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 7:17 Axel Lin [this message]
2012-02-24 14:51 ` [PATCH] regulator: Set delay to 0 if set_voltage_time_sel callback returns error Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330067866.27530.1.camel@phoenix \
--to=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.