From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] regulator: Set delay to 0 if set_voltage_time_sel callback returns error
Date: Fri, 24 Feb 2012 14:51:33 +0000 [thread overview]
Message-ID: <20120224145132.GO5450@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1330067866.27530.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
On Fri, Feb 24, 2012 at 03:17:46PM +0800, Axel Lin wrote:
> delay = rdev->desc->ops->set_voltage_time_sel(rdev,
> old_selector, selector);
> + if (delay < 0)
> + delay = 0;
We should complain if we get an error rather than silently ignore it,
possibly we'll end up returning prior to the ramp finishing which may
break things.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-24 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 7:17 [PATCH] regulator: Set delay to 0 if set_voltage_time_sel callback returns error Axel Lin
2012-02-24 14:51 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224145132.GO5450@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.