All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>,
	openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] bitbake/ConfHandler: Be more strict about variable quoting
Date: Sun, 26 Feb 2012 22:53:08 +0000	[thread overview]
Message-ID: <1330296788.31855.20.camel@ted> (raw)
In-Reply-To: <20120226212631.GA3859@jama.jama.net>

On Sun, 2012-02-26 at 22:26 +0100, Martin Jansa wrote:
> On Sun, Feb 26, 2012 at 01:04:25PM +0000, Richard Purdie wrote:
> > [cross posted to OE-Core since this is a major change in behaviour but
> > in my opinion, probably a good one]
> 
> Agreed, missing quotes are hard to notice and easy to fix in existing
> recipes with resonable error message provided by this.
>  
> > Currently, bitbake will accept variables in the forms:
> > 
> > X = 1
> > X = '1 \
> > 
> > X = "1"
> > X = '1'
> > 
> > which will all set X=1. This patch removes the first two possibilities
> > and makes quoting mandatory. There is little metadata out there which
> > doesn't quote properly and bitbake will exit with an error about the
> > exact line number and file with any problem so users can easily identify
> > and fix issues. OE-Core has already been checked/fixed.
> 
> Not completly true about OE-Core, but I'll send another patch fixing the
> rest and also meta-oe and meta-smartphone layers..

Right, it looks like I didn't trigger a full reparse. Thanks for the
patches, I've applied the OE-Core one.

Cheers,

Richard




WARNING: multiple messages have this Message-ID (diff)
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>,
	openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [bitbake-devel] [PATCH] bitbake/ConfHandler: Be more strict about variable quoting
Date: Sun, 26 Feb 2012 22:53:08 +0000	[thread overview]
Message-ID: <1330296788.31855.20.camel@ted> (raw)
In-Reply-To: <20120226212631.GA3859@jama.jama.net>

On Sun, 2012-02-26 at 22:26 +0100, Martin Jansa wrote:
> On Sun, Feb 26, 2012 at 01:04:25PM +0000, Richard Purdie wrote:
> > [cross posted to OE-Core since this is a major change in behaviour but
> > in my opinion, probably a good one]
> 
> Agreed, missing quotes are hard to notice and easy to fix in existing
> recipes with resonable error message provided by this.
>  
> > Currently, bitbake will accept variables in the forms:
> > 
> > X = 1
> > X = '1 \
> > 
> > X = "1"
> > X = '1'
> > 
> > which will all set X=1. This patch removes the first two possibilities
> > and makes quoting mandatory. There is little metadata out there which
> > doesn't quote properly and bitbake will exit with an error about the
> > exact line number and file with any problem so users can easily identify
> > and fix issues. OE-Core has already been checked/fixed.
> 
> Not completly true about OE-Core, but I'll send another patch fixing the
> rest and also meta-oe and meta-smartphone layers..

Right, it looks like I didn't trigger a full reparse. Thanks for the
patches, I've applied the OE-Core one.

Cheers,

Richard




  reply	other threads:[~2012-02-26 23:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-26 13:04 [PATCH] bitbake/ConfHandler: Be more strict about variable quoting Richard Purdie
2012-02-26 21:26 ` Martin Jansa
2012-02-26 21:26   ` [bitbake-devel] " Martin Jansa
2012-02-26 22:53   ` Richard Purdie [this message]
2012-02-26 22:53     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330296788.31855.20.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.