Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments

Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2097 bytes --]

On Wed, Feb 22, 2012 at 10:13:09PM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: c3d5800d2850a186f91b5a0db642aa5d1c20156b
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=c3d5800d2850a186f91b5a0db642aa5d1c20156b
> 
> Author: Joshua Lock <josh@linux.intel.com>
> Date:   Tue Feb 21 17:46:44 2012 -0800
> 
> netbase: remove redundant assignments
> 
> There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
> takes care of setting this value for us based on the interfaces for those
> machines being an OVERRIDE.

do_install () {
...
        # Disable network manager on machines that commonly do NFS booting
        case "${MACHINE}" in
                "qemuarm" | "qemux86" | "qemux86-64" | "qemumips" | "qemuppc" )

This causes do_install hash to depend on MACHINE variable for all MACHINEs, 
so making whole recipe MACHINE_ARCH would be more effective then rebuilding 
TARGET_ARCH package after every MACHINE switch.

Cheers,

> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> ---
> 
>  meta/recipes-core/netbase/netbase_4.47.bb |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/meta/recipes-core/netbase/netbase_4.47.bb b/meta/recipes-core/netbase/netbase_4.47.bb
> index ddfa8ad..3aa4915 100644
> --- a/meta/recipes-core/netbase/netbase_4.47.bb
> +++ b/meta/recipes-core/netbase/netbase_4.47.bb
> @@ -47,7 +47,3 @@ do_install () {
>  }
>  
>  CONFFILES_${PN} = "${sysconfdir}/hosts ${sysconfdir}/network/interfaces"
> -
> -PACKAGE_ARCH_qemuarm = "${MACHINE_ARCH}"
> -PACKAGE_ARCH_qemux86 = "${MACHINE_ARCH}"
> -PACKAGE_ARCH_qemux86-64 = "${MACHINE_ARCH}"
> 
> 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Koen Kooi]

Op 27 feb. 2012, om 11:33 heeft Martin Jansa het volgende geschreven:

> On Wed, Feb 22, 2012 at 10:13:09PM +0000, git@git.openembedded.org wrote:
>> Module: openembedded-core.git
>> Branch: master
>> Commit: c3d5800d2850a186f91b5a0db642aa5d1c20156b
>> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=c3d5800d2850a186f91b5a0db642aa5d1c20156b
>> 
>> Author: Joshua Lock <josh@linux.intel.com>
>> Date:   Tue Feb 21 17:46:44 2012 -0800
>> 
>> netbase: remove redundant assignments
>> 
>> There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
>> takes care of setting this value for us based on the interfaces for those
>> machines being an OVERRIDE.
> 
> do_install () {
> ...
>        # Disable network manager on machines that commonly do NFS booting
>        case "${MACHINE}" in
>                "qemuarm" | "qemux86" | "qemux86-64" | "qemumips" | "qemuppc" )
> 
> This causes do_install hash to depend on MACHINE variable for all MACHINEs, 
> so making whole recipe MACHINE_ARCH would be more effective then rebuilding 
> TARGET_ARCH package after every MACHINE switch.

That whole bit needs to go into the specific nfs image recipe, not into the recipe. Unless we decide nfs is the one and only way to boot qemu machines.

regards,

Koen

Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Richard Purdie]

On Mon, 2012-02-27 at 12:31 +0100, Koen Kooi wrote:
> Op 27 feb. 2012, om 11:33 heeft Martin Jansa het volgende geschreven:
> 
> > On Wed, Feb 22, 2012 at 10:13:09PM +0000, git@git.openembedded.org wrote:
> >> Module: openembedded-core.git
> >> Branch: master
> >> Commit: c3d5800d2850a186f91b5a0db642aa5d1c20156b
> >> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=c3d5800d2850a186f91b5a0db642aa5d1c20156b
> >> 
> >> Author: Joshua Lock <josh@linux.intel.com>
> >> Date:   Tue Feb 21 17:46:44 2012 -0800
> >> 
> >> netbase: remove redundant assignments
> >> 
> >> There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
> >> takes care of setting this value for us based on the interfaces for those
> >> machines being an OVERRIDE.
> > 
> > do_install () {
> > ...
> >        # Disable network manager on machines that commonly do NFS booting
> >        case "${MACHINE}" in
> >                "qemuarm" | "qemux86" | "qemux86-64" | "qemumips" | "qemuppc" )
> > 
> > This causes do_install hash to depend on MACHINE variable for all MACHINEs, 
> > so making whole recipe MACHINE_ARCH would be more effective then rebuilding 
> > TARGET_ARCH package after every MACHINE switch.
> 
> That whole bit needs to go into the specific nfs image recipe, not
> into the recipe. Unless we decide nfs is the one and only way to boot
> qemu machines.

Clearly the qemu machines boot on non-nfs setups just fine and the
comment is just a bit stale here.

For qemu we expect the IP address to be stable and consistent so we know
where to find it and we don't expect it to disappear. The problem was
that if network manager starts poking around the main ethernet
interface, anything can go wrong (e.g. random QA test failures if
networkmanager decided to change the interface at the wrong moment). We
therefore really do know better than network manager when it comes to
ethernet connectivity into our qemu images.

There are a few options here:

a) Whitelist the MACHINE variable in hashes apart from the qemu machines

b) Change the code to a do_install_append_qemu* which would mean the
hashes become stable.

c) Shove the information into a qemu specific package. 

The trouble with c) before everyone decides its the best is how/when do
you include that package. It really needs to be present whenever network
manager is present. I don't want to end up with someone installing it
from feeds and getting different behaviour as it would be a nightmare to
debug.

d) We could also decide we don't care about network manager any more and
just delete this I guess since we default to connman now.

Cheers,

Richard

Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3855 bytes --]

On Mon, Feb 27, 2012 at 12:13:48PM +0000, Richard Purdie wrote:
> On Mon, 2012-02-27 at 12:31 +0100, Koen Kooi wrote:
> > Op 27 feb. 2012, om 11:33 heeft Martin Jansa het volgende geschreven:
> > 
> > > On Wed, Feb 22, 2012 at 10:13:09PM +0000, git@git.openembedded.org wrote:
> > >> Module: openembedded-core.git
> > >> Branch: master
> > >> Commit: c3d5800d2850a186f91b5a0db642aa5d1c20156b
> > >> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=c3d5800d2850a186f91b5a0db642aa5d1c20156b
> > >> 
> > >> Author: Joshua Lock <josh@linux.intel.com>
> > >> Date:   Tue Feb 21 17:46:44 2012 -0800
> > >> 
> > >> netbase: remove redundant assignments
> > >> 
> > >> There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
> > >> takes care of setting this value for us based on the interfaces for those
> > >> machines being an OVERRIDE.
> > > 
> > > do_install () {
> > > ...
> > >        # Disable network manager on machines that commonly do NFS booting
> > >        case "${MACHINE}" in
> > >                "qemuarm" | "qemux86" | "qemux86-64" | "qemumips" | "qemuppc" )
> > > 
> > > This causes do_install hash to depend on MACHINE variable for all MACHINEs, 
> > > so making whole recipe MACHINE_ARCH would be more effective then rebuilding 
> > > TARGET_ARCH package after every MACHINE switch.
> > 
> > That whole bit needs to go into the specific nfs image recipe, not
> > into the recipe. Unless we decide nfs is the one and only way to boot
> > qemu machines.
> 
> Clearly the qemu machines boot on non-nfs setups just fine and the
> comment is just a bit stale here.
> 
> For qemu we expect the IP address to be stable and consistent so we know
> where to find it and we don't expect it to disappear. The problem was
> that if network manager starts poking around the main ethernet
> interface, anything can go wrong (e.g. random QA test failures if
> networkmanager decided to change the interface at the wrong moment). We
> therefore really do know better than network manager when it comes to
> ethernet connectivity into our qemu images.
> 
> There are a few options here:
> 
> a) Whitelist the MACHINE variable in hashes apart from the qemu machines
> 
> b) Change the code to a do_install_append_qemu* which would mean the
> hashes become stable.

I'm fine with this but maybe then return PACKAGE_ARCH setting for them
as we would be assuming that every machine with such append also have
own interfaces file in SRC_URI (this is now true better to see it
explicitly set above do_install_append_qemu* statement IMHO).


> 
> c) Shove the information into a qemu specific package. 
> 
> The trouble with c) before everyone decides its the best is how/when do
> you include that package. It really needs to be present whenever network
> manager is present. I don't want to end up with someone installing it
> from feeds and getting different behaviour as it would be a nightmare to
> debug.

Bit of off-topic, but do we really need
EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
in meta/conf/machine/include/qemu.inc?

My guess is that in many cases host running builds isn't the same box
where someone is using native qemu to test those images. (e.g. in my
case I'm running builds in minimal chroot, while using distribution qemu
to test resulting images).

Cheers,

> 
> d) We could also decide we don't care about network manager any more and
> just delete this I guess since we default to connman now.
> 
> Cheers,
> 
> Richard
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Richard Purdie]

On Mon, 2012-02-27 at 13:36 +0100, Martin Jansa wrote:
> On Mon, Feb 27, 2012 at 12:13:48PM +0000, Richard Purdie wrote:
> > On Mon, 2012-02-27 at 12:31 +0100, Koen Kooi wrote:
> > > Op 27 feb. 2012, om 11:33 heeft Martin Jansa het volgende geschreven:
> > > 
> > > > On Wed, Feb 22, 2012 at 10:13:09PM +0000, git@git.openembedded.org wrote:
> > > >> Module: openembedded-core.git
> > > >> Branch: master
> > > >> Commit: c3d5800d2850a186f91b5a0db642aa5d1c20156b
> > > >> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=c3d5800d2850a186f91b5a0db642aa5d1c20156b
> > > >> 
> > > >> Author: Joshua Lock <josh@linux.intel.com>
> > > >> Date:   Tue Feb 21 17:46:44 2012 -0800
> > > >> 
> > > >> netbase: remove redundant assignments
> > > >> 
> > > >> There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
> > > >> takes care of setting this value for us based on the interfaces for those
> > > >> machines being an OVERRIDE.
> > > > 
> > > > do_install () {
> > > > ...
> > > >        # Disable network manager on machines that commonly do NFS booting
> > > >        case "${MACHINE}" in
> > > >                "qemuarm" | "qemux86" | "qemux86-64" | "qemumips" | "qemuppc" )
> > > > 
> > > > This causes do_install hash to depend on MACHINE variable for all MACHINEs, 
> > > > so making whole recipe MACHINE_ARCH would be more effective then rebuilding 
> > > > TARGET_ARCH package after every MACHINE switch.
> > > 
> > > That whole bit needs to go into the specific nfs image recipe, not
> > > into the recipe. Unless we decide nfs is the one and only way to boot
> > > qemu machines.
> > 
> > Clearly the qemu machines boot on non-nfs setups just fine and the
> > comment is just a bit stale here.
> > 
> > For qemu we expect the IP address to be stable and consistent so we know
> > where to find it and we don't expect it to disappear. The problem was
> > that if network manager starts poking around the main ethernet
> > interface, anything can go wrong (e.g. random QA test failures if
> > networkmanager decided to change the interface at the wrong moment). We
> > therefore really do know better than network manager when it comes to
> > ethernet connectivity into our qemu images.
> > 
> > There are a few options here:
> > 
> > a) Whitelist the MACHINE variable in hashes apart from the qemu machines
> > 
> > b) Change the code to a do_install_append_qemu* which would mean the
> > hashes become stable.
> 
> I'm fine with this but maybe then return PACKAGE_ARCH setting for them
> as we would be assuming that every machine with such append also have
> own interfaces file in SRC_URI (this is now true better to see it
> explicitly set above do_install_append_qemu* statement IMHO).

Agreed.

> > c) Shove the information into a qemu specific package. 
> > 
> > The trouble with c) before everyone decides its the best is how/when do
> > you include that package. It really needs to be present whenever network
> > manager is present. I don't want to end up with someone installing it
> > from feeds and getting different behaviour as it would be a nightmare to
> > debug.
> 
> Bit of off-topic, but do we really need
> EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
> in meta/conf/machine/include/qemu.inc?
> 
> My guess is that in many cases host running builds isn't the same box
> where someone is using native qemu to test those images. (e.g. in my
> case I'm running builds in minimal chroot, while using distribution qemu
> to test resulting images).

We have a lot of manuals and user expectation that:

bitbake some-image
runqemu some-image

'just works'. That dependency is the only way we can ensure it :/

Cheers,

Richard

Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 4350 bytes --]

On Mon, Feb 27, 2012 at 12:47:13PM +0000, Richard Purdie wrote:
> On Mon, 2012-02-27 at 13:36 +0100, Martin Jansa wrote:
> > On Mon, Feb 27, 2012 at 12:13:48PM +0000, Richard Purdie wrote:
> > > On Mon, 2012-02-27 at 12:31 +0100, Koen Kooi wrote:
> > > > Op 27 feb. 2012, om 11:33 heeft Martin Jansa het volgende geschreven:
> > > > 
> > > > > On Wed, Feb 22, 2012 at 10:13:09PM +0000, git@git.openembedded.org wrote:
> > > > >> Module: openembedded-core.git
> > > > >> Branch: master
> > > > >> Commit: c3d5800d2850a186f91b5a0db642aa5d1c20156b
> > > > >> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=c3d5800d2850a186f91b5a0db642aa5d1c20156b
> > > > >> 
> > > > >> Author: Joshua Lock <josh@linux.intel.com>
> > > > >> Date:   Tue Feb 21 17:46:44 2012 -0800
> > > > >> 
> > > > >> netbase: remove redundant assignments
> > > > >> 
> > > > >> There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
> > > > >> takes care of setting this value for us based on the interfaces for those
> > > > >> machines being an OVERRIDE.
> > > > > 
> > > > > do_install () {
> > > > > ...
> > > > >        # Disable network manager on machines that commonly do NFS booting
> > > > >        case "${MACHINE}" in
> > > > >                "qemuarm" | "qemux86" | "qemux86-64" | "qemumips" | "qemuppc" )
> > > > > 
> > > > > This causes do_install hash to depend on MACHINE variable for all MACHINEs, 
> > > > > so making whole recipe MACHINE_ARCH would be more effective then rebuilding 
> > > > > TARGET_ARCH package after every MACHINE switch.
> > > > 
> > > > That whole bit needs to go into the specific nfs image recipe, not
> > > > into the recipe. Unless we decide nfs is the one and only way to boot
> > > > qemu machines.
> > > 
> > > Clearly the qemu machines boot on non-nfs setups just fine and the
> > > comment is just a bit stale here.
> > > 
> > > For qemu we expect the IP address to be stable and consistent so we know
> > > where to find it and we don't expect it to disappear. The problem was
> > > that if network manager starts poking around the main ethernet
> > > interface, anything can go wrong (e.g. random QA test failures if
> > > networkmanager decided to change the interface at the wrong moment). We
> > > therefore really do know better than network manager when it comes to
> > > ethernet connectivity into our qemu images.
> > > 
> > > There are a few options here:
> > > 
> > > a) Whitelist the MACHINE variable in hashes apart from the qemu machines
> > > 
> > > b) Change the code to a do_install_append_qemu* which would mean the
> > > hashes become stable.
> > 
> > I'm fine with this but maybe then return PACKAGE_ARCH setting for them
> > as we would be assuming that every machine with such append also have
> > own interfaces file in SRC_URI (this is now true better to see it
> > explicitly set above do_install_append_qemu* statement IMHO).
> 
> Agreed.
> 
> > > c) Shove the information into a qemu specific package. 
> > > 
> > > The trouble with c) before everyone decides its the best is how/when do
> > > you include that package. It really needs to be present whenever network
> > > manager is present. I don't want to end up with someone installing it
> > > from feeds and getting different behaviour as it would be a nightmare to
> > > debug.
> > 
> > Bit of off-topic, but do we really need
> > EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
> > in meta/conf/machine/include/qemu.inc?
> > 
> > My guess is that in many cases host running builds isn't the same box
> > where someone is using native qemu to test those images. (e.g. in my
> > case I'm running builds in minimal chroot, while using distribution qemu
> > to test resulting images).
> 
> We have a lot of manuals and user expectation that:
> 
> bitbake some-image
> runqemu some-image
> 
> 'just works'. That dependency is the only way we can ensure it :/

Isn't "bitbake meta-ide-support" also expected to be executed before
runqemu? At least runqemu-export-rootfs assumes it is and
meta-ide-support already depends on qemu-helper-native which in turn
RDEPENDS on qemu-native.

Or we can add mesa-native to provide libgl-native :).

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Koen Kooi]

Op 27 feb. 2012, om 13:13 heeft Richard Purdie het volgende geschreven:

> On Mon, 2012-02-27 at 12:31 +0100, Koen Kooi wrote:
>> Op 27 feb. 2012, om 11:33 heeft Martin Jansa het volgende geschreven:
>> 
>>> On Wed, Feb 22, 2012 at 10:13:09PM +0000, git@git.openembedded.org wrote:
>>>> Module: openembedded-core.git
>>>> Branch: master
>>>> Commit: c3d5800d2850a186f91b5a0db642aa5d1c20156b
>>>> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=c3d5800d2850a186f91b5a0db642aa5d1c20156b
>>>> 
>>>> Author: Joshua Lock <josh@linux.intel.com>
>>>> Date:   Tue Feb 21 17:46:44 2012 -0800
>>>> 
>>>> netbase: remove redundant assignments
>>>> 
>>>> There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
>>>> takes care of setting this value for us based on the interfaces for those
>>>> machines being an OVERRIDE.
>>> 
>>> do_install () {
>>> ...
>>>       # Disable network manager on machines that commonly do NFS booting
>>>       case "${MACHINE}" in
>>>               "qemuarm" | "qemux86" | "qemux86-64" | "qemumips" | "qemuppc" )
>>> 
>>> This causes do_install hash to depend on MACHINE variable for all MACHINEs, 
>>> so making whole recipe MACHINE_ARCH would be more effective then rebuilding 
>>> TARGET_ARCH package after every MACHINE switch.
>> 
>> That whole bit needs to go into the specific nfs image recipe, not
>> into the recipe. Unless we decide nfs is the one and only way to boot
>> qemu machines.
> 
> Clearly the qemu machines boot on non-nfs setups just fine and the
> comment is just a bit stale here.
> 
> For qemu we expect the IP address to be stable and consistent so we know
> where to find it and we don't expect it to disappear. The problem was
> that if network manager starts poking around the main ethernet
> interface, anything can go wrong (e.g. random QA test failures if
> networkmanager decided to change the interface at the wrong moment). We
> therefore really do know better than network manager when it comes to
> ethernet connectivity into our qemu images.
> 
> There are a few options here:
> 
> a) Whitelist the MACHINE variable in hashes apart from the qemu machines
> 
> b) Change the code to a do_install_append_qemu* which would mean the
> hashes become stable.

Both are hacks for the nfs use case.

> c) Shove the information into a qemu specific package. 
> 
> The trouble with c) before everyone decides its the best is how/when do
> you include that package. It really needs to be present whenever network
> manager is present. I don't want to end up with someone installing it
> from feeds and getting different behaviour as it would be a nightmare to
> debug.

If you put it in a seperate package it's becomes something people can opt-in to. If someone opts-in and it breaks because of that, that person gets to keep both pieces.

> d) We could also decide we don't care about network manager any more and
> just delete this I guess since we default to connman now.

You can load the networkmanager plugin (http://wiki.debian.org/NetworkManager#Wired_Networks_are_Unmanaged) that makes it ignore entries in /etc/network/interfaces to accomplish the same. Right now both connman and networkmanager ignore /etc/network/interfaces which leads to mass confusion. I discussed this with Josh at ELC but forgot to send an email about this. I think we should split netbase into:

1) a package with /etc/rpc, /etc/hosts, /etc/protocols and /etc/services
2) a package with /etc/network/interfaces
3) a package with the initscript (probably move that into the ifupdown package)

That way we can support the following without having unused config files in the filesystem:

* simple ifupdown style networking using /etc/network/interfaces
* networkmanager honouring devices managed by /etc/network/interfaces
* networkmanager handling everything
* connman handling everything
* no networking in userspace, boot with ip=dhcp

regards,

Koen

Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Otavio Salvador]

On Mon, Feb 27, 2012 at 10:26, Koen Kooi <koen@dominion.thruhere.net> wrote:
> 1) a package with /etc/rpc, /etc/hosts, /etc/protocols and /etc/services
> 2) a package with /etc/network/interfaces
> 3) a package with the initscript (probably move that into the ifupdown package)

I like this idea a lot :-D

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments

[Koen Kooi]

Op 27 feb. 2012, om 14:31 heeft Otavio Salvador het volgende geschreven:

> On Mon, Feb 27, 2012 at 10:26, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> 1) a package with /etc/rpc, /etc/hosts, /etc/protocols and /etc/services
>> 2) a package with /etc/network/interfaces
>> 3) a package with the initscript (probably move that into the ifupdown package)
> 
> I like this idea a lot :-D

Any suggestions on how to do the split? This is going to be a painfull change by the looks of it, so I'd like a lot of input before I go spin a patchset :)

regards,

Koen