From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Martyn Welch <martyn.welch@ge.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc: Move GE GPIO and PIC drivers
Date: Tue, 28 Feb 2012 08:32:26 +1100 [thread overview]
Message-ID: <1330378346.11728.5.camel@pasglop> (raw)
In-Reply-To: <4F4B8BB2.1060004@ge.com>
On Mon, 2012-02-27 at 13:57 +0000, Martyn Welch wrote:
> This patch (or one like it) has been around for a while now. Kumar wanted me
> to put them here rather than sysdev[1], but I'm easy either way.
Ah well, I disagree with Kumar here :-) One thing you can do is put all
your platforms files including the drivers in platforms/ge, that works
too. What I don't want is to have stray files at the top-level of
platforms.
> > Also, use git mv so that the file moves appear as such in the history,
> > this will make review easier by clearly separating the move from actual
> > changes to the files.
> >
>
> Hmm, thought I'd done that. Will try again.
Could be the way you exported the patch, I don't remember the git option
off the top of my head but there's a way to make it show the moves as
such.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Martyn Welch <martyn.welch@ge.com>
Cc: linuxppc-dev@lists.ozlabs.org, Wim Van Sebroeck <wim@iguana.be>,
Kumar Gala <galak@kernel.crashing.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc: Move GE GPIO and PIC drivers
Date: Tue, 28 Feb 2012 08:32:26 +1100 [thread overview]
Message-ID: <1330378346.11728.5.camel@pasglop> (raw)
In-Reply-To: <4F4B8BB2.1060004@ge.com>
On Mon, 2012-02-27 at 13:57 +0000, Martyn Welch wrote:
> This patch (or one like it) has been around for a while now. Kumar wanted me
> to put them here rather than sysdev[1], but I'm easy either way.
Ah well, I disagree with Kumar here :-) One thing you can do is put all
your platforms files including the drivers in platforms/ge, that works
too. What I don't want is to have stray files at the top-level of
platforms.
> > Also, use git mv so that the file moves appear as such in the history,
> > this will make review easier by clearly separating the move from actual
> > changes to the files.
> >
>
> Hmm, thought I'd done that. Will try again.
Could be the way you exported the patch, I don't remember the git option
off the top of my head but there's a way to make it show the moves as
such.
Cheers,
Ben.
next prev parent reply other threads:[~2012-02-27 22:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 11:28 [PATCH 0/2] powerpc: Add support for GE IMP3A Martyn Welch
2012-02-07 11:28 ` Martyn Welch
2012-02-07 11:28 ` [PATCH 1/2] powerpc: Move GE GPIO and PIC drivers Martyn Welch
2012-02-07 11:28 ` Martyn Welch
2012-02-26 23:37 ` Benjamin Herrenschmidt
2012-02-26 23:37 ` Benjamin Herrenschmidt
2012-02-27 13:57 ` Martyn Welch
2012-02-27 13:57 ` Martyn Welch
2012-02-27 21:32 ` Benjamin Herrenschmidt [this message]
2012-02-27 21:32 ` Benjamin Herrenschmidt
2012-02-07 11:28 ` [PATCH 2/2] powerpc: Board support for GE IMP3A Martyn Welch
2012-02-07 11:28 ` Martyn Welch
2012-02-26 23:42 ` Benjamin Herrenschmidt
2012-02-26 23:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330378346.11728.5.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martyn.welch@ge.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.