All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <rw@linutronix.de>
Cc: tglx@linutronix.de, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org, tim.bird@am.sony.com
Subject: Re: [RFC][PATCH 0/7] UBI checkpointing support
Date: Wed, 29 Feb 2012 13:35:22 +0200	[thread overview]
Message-ID: <1330515322.3545.99.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1329250006-22944-1-git-send-email-rw@linutronix.de>

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On Tue, 2012-02-14 at 21:06 +0100, Richard Weinberger wrote:
> The following patch set implements checkpointing support for
> UBI. Checkpointing is an optional feature which stores the physical to
> logical eraseblock relations in a checkpointing superblock to reduce
> the initialization time of UBI. The current init time of UBI is
> proportional to the number of physical erase blocks on the FLASH
> device. With checkpointing enabled the scan time is limited to a fixed
> number of blocks.

Notice, your patch-set has huge amount of checkpatch.pl complaints -
please fix them. This will also be consistent with the overall UBI
coding style where I honored checkpatch.pl limitations like identation
style and 80 chars per line.


-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <rw@linutronix.de>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, tim.bird@am.sony.com
Subject: Re: [RFC][PATCH 0/7] UBI checkpointing support
Date: Wed, 29 Feb 2012 13:35:22 +0200	[thread overview]
Message-ID: <1330515322.3545.99.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1329250006-22944-1-git-send-email-rw@linutronix.de>

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

On Tue, 2012-02-14 at 21:06 +0100, Richard Weinberger wrote:
> The following patch set implements checkpointing support for
> UBI. Checkpointing is an optional feature which stores the physical to
> logical eraseblock relations in a checkpointing superblock to reduce
> the initialization time of UBI. The current init time of UBI is
> proportional to the number of physical erase blocks on the FLASH
> device. With checkpointing enabled the scan time is limited to a fixed
> number of blocks.

Notice, your patch-set has huge amount of checkpatch.pl complaints -
please fix them. This will also be consistent with the overall UBI
coding style where I honored checkpatch.pl limitations like identation
style and 80 chars per line.


-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2012-02-29 11:32 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-14 20:06 [RFC][PATCH 0/7] UBI checkpointing support Richard Weinberger
2012-02-14 20:06 ` Richard Weinberger
2012-02-14 20:06 ` [RFC][PATCH 1/7] MTD: UBI: Add checkpoint on-chip layout Richard Weinberger
2012-02-14 20:06   ` Richard Weinberger
2012-03-07 16:09   ` Artem Bityutskiy
2012-03-07 16:09     ` Artem Bityutskiy
2012-03-07 21:02     ` Richard Weinberger
2012-03-07 22:09       ` Thomas Gleixner
2012-03-07 22:09         ` Thomas Gleixner
2012-03-07 22:23         ` Thomas Gleixner
2012-03-07 22:23           ` Thomas Gleixner
2012-02-14 20:06 ` [RFC][PATCH 2/7] MTD: UBI: Add checkpoint struct to ubi_device Richard Weinberger
2012-02-14 20:06   ` Richard Weinberger
2012-02-14 20:06 ` [RFC][PATCH 3/7] MTD: UBI: Export next_sqnum() Richard Weinberger
2012-02-14 20:06   ` Richard Weinberger
2012-02-14 20:06 ` [RFC][PATCH 4/7] MTD: UBI: Make wl subsystem checkpoint aware Richard Weinberger
2012-02-14 20:06   ` Richard Weinberger
2012-02-14 20:06 ` [RFC][PATCH 5/7] MTD: UBI: Make process_eb() " Richard Weinberger
2012-02-14 20:06   ` Richard Weinberger
2012-02-14 20:06 ` [RFC][PATCH 6/7] MTD: UBI: Implement checkpointing support Richard Weinberger
2012-02-14 20:06   ` Richard Weinberger
2012-02-20 16:31   ` Shmulik Ladkani
2012-02-20 16:31     ` Shmulik Ladkani
2012-02-14 20:06 ` [RFC][PATCH 7/7] MTD: UBI: wire up checkpointing Richard Weinberger
2012-02-14 20:06   ` Richard Weinberger
2012-02-19 13:57   ` Shmulik Ladkani
2012-02-19 13:57     ` Shmulik Ladkani
2012-02-19 14:08     ` Richard Weinberger
2012-02-19 14:08       ` Richard Weinberger
2012-02-19 14:40       ` Shmulik Ladkani
2012-02-19 14:40         ` Shmulik Ladkani
2012-02-19 15:08         ` Richard Weinberger
2012-02-19 15:08           ` Richard Weinberger
2012-02-29 11:35 ` Artem Bityutskiy [this message]
2012-02-29 11:35   ` [RFC][PATCH 0/7] UBI checkpointing support Artem Bityutskiy
2012-02-29 11:36   ` Artem Bityutskiy
2012-02-29 11:36     ` Artem Bityutskiy
2012-02-29 11:40   ` Richard Weinberger
2012-02-29 12:01     ` Artem Bityutskiy
2012-02-29 12:09     ` Artem Bityutskiy
2012-03-07 16:04 ` Artem Bityutskiy
2012-03-07 16:04   ` Artem Bityutskiy
2012-03-07 21:01   ` Richard Weinberger
2012-03-07 21:01     ` Richard Weinberger
2012-03-08 11:22     ` Artem Bityutskiy
2012-03-08 11:22       ` Artem Bityutskiy
2012-03-07 16:33 ` Artem Bityutskiy
2012-03-07 16:33   ` Artem Bityutskiy
2012-03-07 21:19   ` Richard Weinberger
2012-03-07 21:19     ` Richard Weinberger
2012-03-08  7:08     ` Shmulik Ladkani
2012-03-08  7:08       ` Shmulik Ladkani
2012-03-08  9:21       ` Richard Weinberger
2012-03-08  9:21         ` Richard Weinberger
2012-03-08 11:58         ` Artem Bityutskiy
2012-03-08 11:58           ` Artem Bityutskiy
2012-03-08 13:16           ` Shmulik Ladkani
2012-03-08 13:16             ` Shmulik Ladkani
2012-03-08 11:54     ` Artem Bityutskiy
2012-03-08 11:54       ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330515322.3545.99.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=rw@linutronix.de \
    --cc=tglx@linutronix.de \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.