All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Schwinge <thomas@codesourcery.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
	Paul Mundt <lethal@linux-sh.org>,
	linux-sh@vger.kernel.org, Heiko Schocher <hs@denx.de>,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-fbdev@vger.kernel.org, devicetree-discuss@ozlabs.org,
	Ben Dooks <ben@simtec.co.uk>,
	Vincent Sanders <vince@simtec.co.uk>,
	Randy Dunlap <rdunlap@xenotime.net>
Subject: [PATCH 7/7] sm501: restore big-endian operation.
Date: Fri, 09 Mar 2012 16:38:53 +0000	[thread overview]
Message-ID: <1331311133-26937-7-git-send-email-thomas@codesourcery.com> (raw)
In-Reply-To: <1331311133-26937-1-git-send-email-thomas@codesourcery.com>

On SH, as of 37b7a97884ba64bf7d403351ac2a9476ab4f1bba we have to use the
endianess-agnostic I/O accessor functions.

In commit bf5f0019046d596d613caf74722ba4994e153899, Heiko fixed this for 32-bit
PowerPC; my patch now generalizes upon that.

The device is now recognized correctly for both litte-endian and big-endian
sh7785lcr, but I have not tested this any further, as the board is situated in
a remote data center.

Signed-off-by: Thomas Schwinge <thomas@codesourcery.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org
Cc: Heiko Schocher <hs@denx.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-fbdev@vger.kernel.org
Cc: devicetree-discuss@ozlabs.org
Cc: Ben Dooks <ben@simtec.co.uk>
Cc: Vincent Sanders <vince@simtec.co.uk>
Cc: Randy Dunlap <rdunlap@xenotime.net>
---
 include/linux/sm501.h |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/include/linux/sm501.h b/include/linux/sm501.h
index 02fde50..0312e3c 100644
--- a/include/linux/sm501.h
+++ b/include/linux/sm501.h
@@ -173,10 +173,5 @@ struct sm501_platdata {
 	unsigned int			 gpio_i2c_nr;
 };
 
-#if defined(CONFIG_PPC32)
-#define smc501_readl(addr)		ioread32be((addr))
-#define smc501_writel(val, addr)	iowrite32be((val), (addr))
-#else
-#define smc501_readl(addr)		readl(addr)
-#define smc501_writel(val, addr)	writel(val, addr)
-#endif
+#define smc501_readl(addr)		__raw_readl(addr)
+#define smc501_writel(val, addr)	__raw_writel(val, addr)
-- 
1.7.4.1


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Schwinge <thomas@codesourcery.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
	Paul Mundt <lethal@linux-sh.org>,
	linux-sh@vger.kernel.org, Heiko Schocher <hs@denx.de>,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-fbdev@vger.kernel.org, devicetree-discuss@ozlabs.org,
	Ben Dooks <ben@simtec.co.uk>,
	Vincent Sanders <vince@simtec.co.uk>,
	Randy Dunlap <rdunlap@xenotime.net>
Subject: [PATCH 7/7] sm501: restore big-endian operation.
Date: Fri, 9 Mar 2012 17:38:53 +0100	[thread overview]
Message-ID: <1331311133-26937-7-git-send-email-thomas@codesourcery.com> (raw)
In-Reply-To: <1331311133-26937-1-git-send-email-thomas@codesourcery.com>

On SH, as of 37b7a97884ba64bf7d403351ac2a9476ab4f1bba we have to use the
endianess-agnostic I/O accessor functions.

In commit bf5f0019046d596d613caf74722ba4994e153899, Heiko fixed this for 32-bit
PowerPC; my patch now generalizes upon that.

The device is now recognized correctly for both litte-endian and big-endian
sh7785lcr, but I have not tested this any further, as the board is situated in
a remote data center.

Signed-off-by: Thomas Schwinge <thomas@codesourcery.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org
Cc: Heiko Schocher <hs@denx.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-fbdev@vger.kernel.org
Cc: devicetree-discuss@ozlabs.org
Cc: Ben Dooks <ben@simtec.co.uk>
Cc: Vincent Sanders <vince@simtec.co.uk>
Cc: Randy Dunlap <rdunlap@xenotime.net>
---
 include/linux/sm501.h |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/include/linux/sm501.h b/include/linux/sm501.h
index 02fde50..0312e3c 100644
--- a/include/linux/sm501.h
+++ b/include/linux/sm501.h
@@ -173,10 +173,5 @@ struct sm501_platdata {
 	unsigned int			 gpio_i2c_nr;
 };
 
-#if defined(CONFIG_PPC32)
-#define smc501_readl(addr)		ioread32be((addr))
-#define smc501_writel(val, addr)	iowrite32be((val), (addr))
-#else
-#define smc501_readl(addr)		readl(addr)
-#define smc501_writel(val, addr)	writel(val, addr)
-#endif
+#define smc501_readl(addr)		__raw_readl(addr)
+#define smc501_writel(val, addr)	__raw_writel(val, addr)
-- 
1.7.4.1


  parent reply	other threads:[~2012-03-09 16:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-09 16:38 [PATCH 1/7] SH: sh7785lcr board: restore big-endian operation Thomas Schwinge
2012-03-09 16:38 ` [PATCH 3/7] serial: sh-sci: " Thomas Schwinge
2012-03-09 16:38   ` Thomas Schwinge
2012-03-09 17:10   ` Greg KH
2012-03-09 17:10     ` Greg KH
2012-03-09 20:23     ` Thomas Schwinge
2012-03-09 20:23       ` Thomas Schwinge
2012-03-09 16:38 ` [PATCH 5/7] USB: r8a66597-hcd: " Thomas Schwinge
2012-03-09 16:38   ` Thomas Schwinge
2012-03-09 16:38   ` Thomas Schwinge
2012-03-09 16:38   ` Thomas Schwinge
2012-03-10 11:02   ` Sergei Shtylyov
2012-03-10 11:02     ` Sergei Shtylyov
2012-03-10 11:02     ` Sergei Shtylyov
2012-03-10 11:02     ` Sergei Shtylyov
2012-03-09 16:38 ` Thomas Schwinge [this message]
2012-03-09 16:38   ` [PATCH 7/7] sm501: " Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331311133-26937-7-git-send-email-thomas@codesourcery.com \
    --to=thomas@codesourcery.com \
    --cc=ben@simtec.co.uk \
    --cc=devicetree-discuss@ozlabs.org \
    --cc=hs@denx.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sameo@linux.intel.com \
    --cc=vince@simtec.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.