All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: Tabi Timur-B04825 <B04825@freescale.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 2/2] ASoC: DAPM - Make sure DAPM widget IO ops hold the component mutex.
Date: Fri, 09 Mar 2012 18:14:13 +0000	[thread overview]
Message-ID: <1331316853.3789.4.camel@odin> (raw)
In-Reply-To: <CAOZdJXUy-hCOEk6beBrjv16iknsMWTHc+AxSyw-L8-hLEXQYSw@mail.gmail.com>

On Fri, 2012-03-09 at 17:26 +0000, Tabi Timur-B04825 wrote:
> On Tue, Mar 6, 2012 at 12:16 PM, Liam Girdwood <lrg@ti.com> wrote:
> > Currently not all DAPM widget IO ops are holding their component mutex
> > (codec or platform). Make sure this is now held for DAPM widget IO operations.
> >
> > Signed-off-by: Liam Girdwood <lrg@ti.com>
> 
> This patch breaks the P1022DS, which uses the WM8776 as a codec.  The
> MPC8610HPCD, which is identical to the P1022DS but uses the CS4270
> codec instead, works fine.
> 
> I'm guessing it's some kind of deadlock, because as soon as I start
> playback, the system halts.  Not even Ctrl-C works.
> 

Can you switch on the mutex debugging kernel config here.  I've just had
a quick look and the WM8776 and its not holding the codec mutex or
calling snd_soc_update_bits_locked() so it must deadlock via another
path.

Thanks

Liam

  reply	other threads:[~2012-03-09 18:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 18:16 [PATCH 1/2] ASoC: core - Add platform component mutex Liam Girdwood
2012-03-06 18:16 ` [PATCH 2/2] ASoC: DAPM - Make sure DAPM widget IO ops hold the " Liam Girdwood
2012-03-06 20:03   ` Mark Brown
2012-03-07 10:11     ` Liam Girdwood
2012-03-07 10:54       ` Mark Brown
2012-03-07 11:13         ` Liam Girdwood
2012-03-07 20:00           ` Mark Brown
2012-03-09 17:26   ` Tabi Timur-B04825
2012-03-09 18:14     ` Liam Girdwood [this message]
2012-03-09 19:11       ` Timur Tabi
2012-03-11 12:55         ` Mark Brown
2012-03-11 13:58           ` Tabi Timur-B04825
2012-03-12  9:12           ` Shawn Guo
2012-03-12  9:27             ` Liam Girdwood
2012-03-12 10:42               ` Mark Brown
2012-03-06 20:09 ` [PATCH 1/2] ASoC: core - Add platform " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331316853.3789.4.camel@odin \
    --to=lrg@ti.com \
    --cc=B04825@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.