All of lore.kernel.org
 help / color / mirror / Atom feed
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] clk: fix orphan list iterator to be safe
Date: Tue, 13 Mar 2012 18:22:21 -0500	[thread overview]
Message-ID: <1331680947-29861-2-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1331680947-29861-1-git-send-email-robherring2@gmail.com>

From: Rob Herring <rob.herring@calxeda.com>

__clk_reparent can remove orphans, so the list iterator needs to be the
safe from removal version.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
 drivers/clk/clk.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index c7c3bc5..802eda4 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1172,7 +1172,7 @@ void __clk_init(struct device *dev, struct clk *clk)
 {
 	int i;
 	struct clk *orphan;
-	struct hlist_node *tmp;
+	struct hlist_node *tmp, *tmp2;
 
 	if (!clk)
 		return;
@@ -1246,7 +1246,7 @@ void __clk_init(struct device *dev, struct clk *clk)
 	 * walk the list of orphan clocks and reparent any that are children of
 	 * this clock
 	 */
-	hlist_for_each_entry(orphan, tmp, &clk_orphan_list, child_node)
+	hlist_for_each_entry_safe(orphan, tmp, tmp2, &clk_orphan_list, child_node)
 		__clk_reparent(orphan, __clk_init_parent(orphan));
 
 	/*
-- 
1.7.5.4

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org
Cc: Grant Likely <grant.likely@secretlab.ca>,
	Mike Turquette <mturquette@linaro.org>,
	Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH 1/7] clk: fix orphan list iterator to be safe
Date: Tue, 13 Mar 2012 18:22:21 -0500	[thread overview]
Message-ID: <1331680947-29861-2-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1331680947-29861-1-git-send-email-robherring2@gmail.com>

From: Rob Herring <rob.herring@calxeda.com>

__clk_reparent can remove orphans, so the list iterator needs to be the
safe from removal version.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
 drivers/clk/clk.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index c7c3bc5..802eda4 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1172,7 +1172,7 @@ void __clk_init(struct device *dev, struct clk *clk)
 {
 	int i;
 	struct clk *orphan;
-	struct hlist_node *tmp;
+	struct hlist_node *tmp, *tmp2;
 
 	if (!clk)
 		return;
@@ -1246,7 +1246,7 @@ void __clk_init(struct device *dev, struct clk *clk)
 	 * walk the list of orphan clocks and reparent any that are children of
 	 * this clock
 	 */
-	hlist_for_each_entry(orphan, tmp, &clk_orphan_list, child_node)
+	hlist_for_each_entry_safe(orphan, tmp, tmp2, &clk_orphan_list, child_node)
 		__clk_reparent(orphan, __clk_init_parent(orphan));
 
 	/*
-- 
1.7.5.4

  reply	other threads:[~2012-03-13 23:22 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13 23:22 [PATCH 0/7] Highbank clock support using DT Rob Herring
2012-03-13 23:22 ` Rob Herring
2012-03-13 23:22 ` Rob Herring [this message]
2012-03-13 23:22   ` [PATCH 1/7] clk: fix orphan list iterator to be safe Rob Herring
2012-03-14  2:10   ` Turquette, Mike
2012-03-14  2:10     ` Turquette, Mike
2012-03-13 23:22 ` [PATCH 2/7] of: add clock providers Rob Herring
2012-03-13 23:22   ` Rob Herring
2012-03-14  7:07   ` Thierry Reding
2012-03-14  7:07     ` Thierry Reding
2012-03-14  7:55   ` Shawn Guo
2012-03-14  7:55     ` Shawn Guo
2012-04-07  4:18   ` Grant Likely
2012-04-07  4:18     ` Grant Likely
2012-04-07 19:04     ` Rob Herring
2012-04-07 19:04       ` Rob Herring
2012-04-09 11:55   ` Shawn Guo
2012-04-09 11:55     ` Shawn Guo
2012-04-09 13:52     ` Rob Herring
2012-04-09 13:52       ` Rob Herring
2012-04-09 14:13       ` Shawn Guo
2012-04-09 14:13         ` Shawn Guo
2012-04-09 14:34         ` Rob Herring
2012-04-09 14:34           ` Rob Herring
2012-04-09 23:42           ` Shawn Guo
2012-04-09 23:42             ` Shawn Guo
2012-03-13 23:22 ` [PATCH 3/7] of: Add of_property_match_string() to find index into a string list Rob Herring
2012-03-13 23:22   ` Rob Herring
2012-04-07  4:22   ` Grant Likely
2012-04-07  4:22     ` Grant Likely
2012-03-13 23:22 ` [PATCH 4/7] dt/clock: Add handling for fixed clocks and a clock node setup iterator Rob Herring
2012-03-13 23:22   ` Rob Herring
2012-03-14  7:59   ` Shawn Guo
2012-03-14  7:59     ` Shawn Guo
2012-03-14 13:26     ` Rob Herring
2012-03-14 13:26       ` Rob Herring
2012-03-14 13:45       ` Shawn Guo
2012-03-14 13:45         ` Shawn Guo
2012-04-08 14:48     ` Rob Herring
2012-04-08 14:48       ` Rob Herring
2012-04-09  8:49       ` Shawn Guo
2012-04-09  8:49         ` Shawn Guo
2012-04-09 14:18         ` Rob Herring
2012-04-09 14:18           ` Rob Herring
2012-04-09 23:27           ` Shawn Guo
2012-04-09 23:27             ` Shawn Guo
2012-04-15  3:04             ` Rob Herring
2012-04-15  3:04               ` Rob Herring
2012-04-15  7:01               ` Shawn Guo
2012-04-15  7:01                 ` Shawn Guo
2012-03-13 23:22 ` [PATCH 5/7] dt/clock: add a simple provider get function Rob Herring
2012-03-13 23:22   ` Rob Herring
2012-04-07  4:26   ` Grant Likely
2012-04-07  4:26     ` Grant Likely
2012-03-13 23:22 ` [PATCH 6/7] dt/clock: add function to get parent clock name Rob Herring
2012-03-13 23:22   ` Rob Herring
2012-03-13 23:22 ` [PATCH 7/7] clk: add highbank clock support Rob Herring
2012-03-13 23:22   ` Rob Herring
2012-04-10  2:06   ` Shawn Guo
2012-04-10  2:06     ` Shawn Guo
2012-04-10 13:17     ` Rob Herring
2012-04-10 13:17       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331680947-29861-2-git-send-email-robherring2@gmail.com \
    --to=robherring2@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.