All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gianluca Gennari <gennarone@gmail.com>
To: linux-media@vger.kernel.org, mchehab@redhat.com
Cc: crope@iki.fi, Gianluca Gennari <gennarone@gmail.com>
Subject: [PATCH 2/3] em28xx-dvb: enable LNA for cxd2820r in DVB-T mode
Date: Thu, 15 Mar 2012 18:33:48 +0100	[thread overview]
Message-ID: <1331832829-4580-3-git-send-email-gennarone@gmail.com> (raw)
In-Reply-To: <1331832829-4580-1-git-send-email-gennarone@gmail.com>

Enable the LNA amplifier also for DVB-T (like for DVB-T2 and DVB-C);
this greatly improves reception of weak signals without affecting the reception
of the strong ones.

Experimental data (collected with the mipsel STB) on the weakest frequencies
available in my area:

LNA OFF:

MUX          level   BER     picture

RAI mux 4    72%     32000   corrupted
TIMB 2       75%     14      OK
TVA Vicenza  68%     32000   corrupted
RAI mux 2    78%     14      OK

LNA ON:

MUX          level   BER     picture

RAI mux 4    73%     1500    OK
TIMB 2       76%     0       OK
TVA Vicenza  69%     0       OK
RAI mux 2    79%     0       OK

Moreover, with LNA enabled, the PCTV 290e was able to pick up 2 new frequencies
matching the integrated tuner of my Panasonic G20 TV, which is really good.

Signed-off-by: Gianluca Gennari <gennarone@gmail.com>
---
 drivers/media/video/em28xx/em28xx-dvb.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/em28xx/em28xx-dvb.c b/drivers/media/video/em28xx/em28xx-dvb.c
index fbd9010..4917b71 100644
--- a/drivers/media/video/em28xx/em28xx-dvb.c
+++ b/drivers/media/video/em28xx/em28xx-dvb.c
@@ -502,7 +502,8 @@ static struct cxd2820r_config em28xx_cxd2820r_config = {
 	.i2c_address = (0xd8 >> 1),
 	.ts_mode = CXD2820R_TS_SERIAL,
 
-	/* enable LNA for DVB-T2 and DVB-C */
+	/* enable LNA for DVB-T, DVB-T2 and DVB-C */
+	.gpio_dvbt[0] = CXD2820R_GPIO_E | CXD2820R_GPIO_O | CXD2820R_GPIO_L,
 	.gpio_dvbt2[0] = CXD2820R_GPIO_E | CXD2820R_GPIO_O | CXD2820R_GPIO_L,
 	.gpio_dvbc[0] = CXD2820R_GPIO_E | CXD2820R_GPIO_O | CXD2820R_GPIO_L,
 };
-- 
1.7.5.4


  parent reply	other threads:[~2012-03-15 17:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15 17:33 [PATCH 0/3] cxd2820r: tweak search algorithm, enable LNA in DVB-T mode Gianluca Gennari
2012-03-15 17:33 ` [PATCH 1/3] cxd2820r: tweak search algorithm behavior Gianluca Gennari
2012-03-23 12:49   ` Antti Palosaari
2012-03-15 17:33 ` Gianluca Gennari [this message]
2012-03-23 12:55   ` [PATCH 2/3] em28xx-dvb: enable LNA for cxd2820r in DVB-T mode Antti Palosaari
     [not found]     ` <CACOeW9MNoRZOs5yruTSEqcj_576ih6cnpW-j0HzKCs0Qyy=P4w@mail.gmail.com>
2012-03-23 14:45       ` Mauro Carvalho Chehab
2012-03-15 17:33 ` [PATCH 3/3] cxd2820r: delete unused function cxd2820r_init_t2 Gianluca Gennari
2012-03-23 12:50   ` Antti Palosaari
2012-03-15 17:41 ` [PATCH 0/3] cxd2820r: tweak search algorithm, enable LNA in DVB-T mode Mauro Carvalho Chehab
2012-03-15 17:49   ` Antti Palosaari
2012-03-15 18:06     ` Mauro Carvalho Chehab
2012-03-15 18:07   ` Gianluca Gennari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331832829-4580-3-git-send-email-gennarone@gmail.com \
    --to=gennarone@gmail.com \
    --cc=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.