* [PATCH] Fix c6x's entry.S
@ 2012-03-15 17:52 David Howells
2012-03-15 18:34 ` Mark Salter
0 siblings, 1 reply; 2+ messages in thread
From: David Howells @ 2012-03-15 17:52 UTC (permalink / raw)
To: msalter, a-jacquiot; +Cc: linux-c6x-dev, linux-kernel, David Howells
The ENDPROC() on sys_fadvise64_c6x() in arch/c6x/kernel/entry.S needs to be
transposed with the preceding #endif so that it's in the same conditional
block as the matching ENTRY() macro.
Without this, I see:
/tmp/ccGZBaPT.s: Assembler messages:
/tmp/ccGZBaPT.s: Error: .size expression for sys_fadvise64_c6x does not evaluate to a constant
Signed-off-by: David Howells <dhowells@redhat.com>
---
arch/c6x/kernel/entry.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/c6x/kernel/entry.S b/arch/c6x/kernel/entry.S
index 3e977cc..91b2e79 100644
--- a/arch/c6x/kernel/entry.S
+++ b/arch/c6x/kernel/entry.S
@@ -741,8 +741,8 @@ ENTRY(sys_fadvise64_c6x)
#endif
MV .D1X B6,A6
MV .D2X A8,B6
-#endif
ENDPROC(sys_fadvise64_c6x)
+#endif
;; On Entry
;; A4 - fd
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix c6x's entry.S
2012-03-15 17:52 [PATCH] Fix c6x's entry.S David Howells
@ 2012-03-15 18:34 ` Mark Salter
0 siblings, 0 replies; 2+ messages in thread
From: Mark Salter @ 2012-03-15 18:34 UTC (permalink / raw)
To: David Howells; +Cc: a-jacquiot, linux-c6x-dev, linux-kernel
On Thu, 2012-03-15 at 17:52 +0000, David Howells wrote:
> The ENDPROC() on sys_fadvise64_c6x() in arch/c6x/kernel/entry.S needs to be
> transposed with the preceding #endif so that it's in the same conditional
> block as the matching ENTRY() macro.
>
> Without this, I see:
>
> /tmp/ccGZBaPT.s: Assembler messages:
> /tmp/ccGZBaPT.s: Error: .size expression for sys_fadvise64_c6x does not evaluate to a constant
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> arch/c6x/kernel/entry.S | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/c6x/kernel/entry.S b/arch/c6x/kernel/entry.S
> index 3e977cc..91b2e79 100644
> --- a/arch/c6x/kernel/entry.S
> +++ b/arch/c6x/kernel/entry.S
> @@ -741,8 +741,8 @@ ENTRY(sys_fadvise64_c6x)
> #endif
> MV .D1X B6,A6
> MV .D2X A8,B6
> -#endif
> ENDPROC(sys_fadvise64_c6x)
> +#endif
Thanks! Actually, I'll delete sys_fadvise64_c6x altogether. It is
leftover cruft since we no longer support __ARCH_WANT_SYSCALL_OFF_T.
As an aside, the build tools I'm using didn't catch that. I definitely
need to upgrade...
--Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-15 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-15 17:52 [PATCH] Fix c6x's entry.S David Howells
2012-03-15 18:34 ` Mark Salter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.