All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/3] mac80211: do not scan and monitor connection in parallel
Date: Fri, 16 Mar 2012 14:21:58 +0100	[thread overview]
Message-ID: <1331904118.6753.11.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120316131322.GA10844@redhat.com>

On Fri, 2012-03-16 at 14:13 +0100, Stanislaw Gruszka wrote:
> On Fri, Mar 16, 2012 at 01:52:58PM +0100, Johannes Berg wrote:
> > On Fri, 2012-03-16 at 13:02 +0100, Stanislaw Gruszka wrote:
> > > Before we send probes in connection monitoring we check if scan is not
> > > pending. But we do that check without locking. Fix that and also do not
> > > start scan if connection monitoring is in progress.
> > 
> > Wouldn't it be easier to just abort the check instead of deferring the
> > scan?
> 
> It would be easier. However we already defer scan on
> !list_empty(&local->work_list) case. Also random failures of
> scan request can not be well seen from user-space perspective.

Ah, I didn't mean aborting the scan request, but rather the connection
monitor check. But yeah, I guess you're right about already deferring.

johannes


      reply	other threads:[~2012-03-16 13:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 12:02 [RFC 1/3] mac80211: do not scan and monitor connection in parallel Stanislaw Gruszka
2012-03-16 12:02 ` [RFC 2/3] mac80211: protect ->scanning by mutex in ieee80211_work_work() Stanislaw Gruszka
2012-03-16 12:54   ` Johannes Berg
2012-03-16 13:16     ` Stanislaw Gruszka
2012-03-16 13:38       ` Johannes Berg
2012-03-16 12:02 ` [RFC 3/3] mac80211: synchronize channel switch and scan Stanislaw Gruszka
2012-03-16 12:52 ` [RFC 1/3] mac80211: do not scan and monitor connection in parallel Johannes Berg
2012-03-16 13:13   ` Stanislaw Gruszka
2012-03-16 13:21     ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331904118.6753.11.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.