From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/3] mac80211: protect ->scanning by mutex in ieee80211_work_work()
Date: Fri, 16 Mar 2012 14:38:52 +0100 [thread overview]
Message-ID: <1331905132.6753.12.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120316131644.GB10844@redhat.com>
On Fri, 2012-03-16 at 14:16 +0100, Stanislaw Gruszka wrote:
> On Fri, Mar 16, 2012 at 01:54:13PM +0100, Johannes Berg wrote:
> > I don't really see the point in this. It seems that this doesn't really
> > help, you'd actually have to protect all the work stuff here with the
> > mutex so the scanning can also be excluded or so?
>
> You mean some other work stuff than ieee80211_work_work() ?
>
> We have almost all ieee80211_work_work() code protected by local->mtx
> already, I just moved local->scanning check after the mutex_lock.
Oh, ok. I thought it wasn't really protected, I guess then this makes
some sense.
johannes
next prev parent reply other threads:[~2012-03-16 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 12:02 [RFC 1/3] mac80211: do not scan and monitor connection in parallel Stanislaw Gruszka
2012-03-16 12:02 ` [RFC 2/3] mac80211: protect ->scanning by mutex in ieee80211_work_work() Stanislaw Gruszka
2012-03-16 12:54 ` Johannes Berg
2012-03-16 13:16 ` Stanislaw Gruszka
2012-03-16 13:38 ` Johannes Berg [this message]
2012-03-16 12:02 ` [RFC 3/3] mac80211: synchronize channel switch and scan Stanislaw Gruszka
2012-03-16 12:52 ` [RFC 1/3] mac80211: do not scan and monitor connection in parallel Johannes Berg
2012-03-16 13:13 ` Stanislaw Gruszka
2012-03-16 13:21 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331905132.6753.12.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.