From: Marcel Holtmann <marcel@holtmann.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-input@vger.kernel.org, jkosina@suse.cz, chen.ganir@ti.com,
claudio.takahasi@openbossa.org, jprvita@openbossa.org,
linux-bluetooth@vger.kernel.org, Vijaykumar.Dadmode@csr.com
Subject: Re: [RFC 1/1] HID: User-space I/O driver support for HID subsystem
Date: Fri, 16 Mar 2012 13:51:00 -0700 [thread overview]
Message-ID: <1331931060.14217.190.camel@aeonflux> (raw)
In-Reply-To: <CANq1E4ROxW_XfkP8=s9FsHuxXMYGXomqRhsuAc4Ow5uBSAE6Gg@mail.gmail.com>
Hi David,
> >> new file mode 100644
> >> index 0000000..1a7df0d
> >> --- /dev/null
> >> +++ b/include/linux/uhid.h
> >> @@ -0,0 +1,71 @@
> >> +#ifndef __UHID_H_
> >> +#define __UHID_H_
> >> +
> >> +/*
> >> + * User-space I/O driver support for HID subsystem
> >> + * Copyright (c) 2012 David Herrmann
> >> + */
> >> +
> >> +/*
> >> + * This program is free software; you can redistribute it and/or modify it
> >> + * under the terms of the GNU General Public License as published by the Free
> >> + * Software Foundation; either version 2 of the License, or (at your option)
> >> + * any later version.
> >> + */
> >> +
> >> +#include <linux/input.h>
> >> +#include <linux/types.h>
> >> +
> >> +enum uhid_event_type {
> >> + UHID_CREATE,
> >> + UHID_DESTROY,
> >> + UHID_START,
> >> + UHID_STOP,
> >> + UHID_OPEN,
> >> + UHID_CLOSE,
> >> + UHID_OUTPUT,
> >> + UHID_OUTPUT_EV,
> >> + UHID_INPUT,
> >> +};
> >> +
> >> +struct uhid_create_req {
> >> + __u8 __user name[128];
> >> + __u8 __user *rd_data;
> >> + __u16 rd_size;
> >> +
> >
> > we need the bus here as well. With HIDP it was implicit, but here it is
> > no longer implicit.
>
> Uh, yeah, I will add that, thanks. I also need to find a proper way to
> get a hid->dev.parent pointer.
>
> >> + __u16 vendor;
> >> + __u16 product;
> >> + __u16 version;
> >> + __u8 country;
> >
> > What are we using country for these days?
>
> I copied it from HIDP. If we don't need this, I can remove it. USBHID
> doesn't use it as far as I can see.
in USB it is the hdesc->bCountryCode. And in Bluetooth BR/EDR it comes
from the SDP record. So it makes sense to keep it.
Regards
Marcel
next prev parent reply other threads:[~2012-03-16 20:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 14:53 [RFC 0/1] User-space I/O driver for HID subsystem (Bluetooth-LE HIDP) David Herrmann
2012-03-16 14:53 ` [RFC 1/1] HID: User-space I/O driver support for HID subsystem David Herrmann
2012-03-16 16:00 ` Marcel Holtmann
2012-03-16 16:00 ` Marcel Holtmann
2012-03-16 18:51 ` David Herrmann
2012-03-16 18:51 ` David Herrmann
2012-03-16 20:51 ` Marcel Holtmann [this message]
2012-03-16 17:00 ` Andre Guedes
2012-03-16 17:00 ` Andre Guedes
2012-03-16 17:15 ` Marcel Holtmann
2012-03-16 19:01 ` David Herrmann
2012-03-16 19:01 ` David Herrmann
2012-03-16 20:45 ` Marcel Holtmann
2012-03-16 23:38 ` Vinicius Costa Gomes
2012-03-26 17:38 ` David Herrmann
2012-03-26 17:38 ` David Herrmann
2012-03-16 14:58 ` [RFC 0/1] User-space I/O driver for HID subsystem (Bluetooth-LE HIDP) Jiri Kosina
2012-03-16 14:58 ` Jiri Kosina
2012-03-16 16:03 ` Marcel Holtmann
2012-03-16 16:03 ` Marcel Holtmann
2012-03-16 16:04 ` Anderson Lizardo
2012-03-16 16:04 ` Anderson Lizardo
2012-03-16 17:28 ` Joao Paulo Rechi Vita
2012-03-16 17:28 ` Joao Paulo Rechi Vita
2012-03-16 17:50 ` Joao Paulo Rechi Vita
2012-03-16 17:50 ` Joao Paulo Rechi Vita
2012-03-16 17:57 ` Marcel Holtmann
2012-03-16 18:09 ` Dmitry Torokhov
2012-03-16 18:09 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331931060.14217.190.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=Vijaykumar.Dadmode@csr.com \
--cc=chen.ganir@ti.com \
--cc=claudio.takahasi@openbossa.org \
--cc=dh.herrmann@googlemail.com \
--cc=jkosina@suse.cz \
--cc=jprvita@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.