From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Joao Paulo Rechi Vita <jprvita@openbossa.org>,
David Herrmann <dh.herrmann@googlemail.com>,
linux-input@vger.kernel.org, jkosina@suse.cz, chen.ganir@ti.com,
claudio.takahasi@openbossa.org, linux-bluetooth@vger.kernel.org,
Vijaykumar.Dadmode@csr.com
Subject: Re: [RFC 0/1] User-space I/O driver for HID subsystem (Bluetooth-LE HIDP)
Date: Fri, 16 Mar 2012 11:09:07 -0700 [thread overview]
Message-ID: <2581566.JBjJTljkE9@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <1331920658.14217.180.camel@aeonflux>
On Friday, March 16, 2012 10:57:38 AM Marcel Holtmann wrote:
> Hi Joao,
>
> > > I have hacked together a small driver which allows user-space I/O
> > > drivers to provide HID devices. This is needed for
> > > Bluetooth-Low-Energy HID devices as the Bluetooth-LE protocol is
> > > parsed in user-space.
> > >
> > > I have only compile-tested this driver, I haven't run it yet. It's
> > > just an proposal how this could be implemented. It should also work
> > > as hint to the BT-LE developers how such an interface will
> > > look-like.
> >
> > First of all, thanks for your effort. I haven't looked at the code
> > yet, but thinking again about the problem and since it's very similar
> > to uinput, would adding another ioctl to uinput that receives the HID
> > descriptor and put uinput in a "HID mode" be sufficient? This way we
> > could increase code reuse and ease maintainance, I guess. What do you
> > think?
>
> I am really against this. Input subsystem and HID subsystem are two
> different things. Don't try to combine them.
>
> You would also mess up the layering here. HID uses input, but input does
> not require HID.
>
Completely agree with Marcel here.
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
Cc: Joao Paulo Rechi Vita
<jprvita-430g2QfJUUCGglJvpFV4uA@public.gmane.org>,
David Herrmann
<dh.herrmann-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jkosina-AlSwsSmVLrQ@public.gmane.org,
chen.ganir-l0cyMroinI0@public.gmane.org,
claudio.takahasi-430g2QfJUUCGglJvpFV4uA@public.gmane.org,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vijaykumar.Dadmode-kQvG35nSl+M@public.gmane.org
Subject: Re: [RFC 0/1] User-space I/O driver for HID subsystem (Bluetooth-LE HIDP)
Date: Fri, 16 Mar 2012 11:09:07 -0700 [thread overview]
Message-ID: <2581566.JBjJTljkE9@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <1331920658.14217.180.camel@aeonflux>
On Friday, March 16, 2012 10:57:38 AM Marcel Holtmann wrote:
> Hi Joao,
>
> > > I have hacked together a small driver which allows user-space I/O
> > > drivers to provide HID devices. This is needed for
> > > Bluetooth-Low-Energy HID devices as the Bluetooth-LE protocol is
> > > parsed in user-space.
> > >
> > > I have only compile-tested this driver, I haven't run it yet. It's
> > > just an proposal how this could be implemented. It should also work
> > > as hint to the BT-LE developers how such an interface will
> > > look-like.
> >
> > First of all, thanks for your effort. I haven't looked at the code
> > yet, but thinking again about the problem and since it's very similar
> > to uinput, would adding another ioctl to uinput that receives the HID
> > descriptor and put uinput in a "HID mode" be sufficient? This way we
> > could increase code reuse and ease maintainance, I guess. What do you
> > think?
>
> I am really against this. Input subsystem and HID subsystem are two
> different things. Don't try to combine them.
>
> You would also mess up the layering here. HID uses input, but input does
> not require HID.
>
Completely agree with Marcel here.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-03-16 18:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 14:53 [RFC 0/1] User-space I/O driver for HID subsystem (Bluetooth-LE HIDP) David Herrmann
2012-03-16 14:53 ` [RFC 1/1] HID: User-space I/O driver support for HID subsystem David Herrmann
2012-03-16 16:00 ` Marcel Holtmann
2012-03-16 16:00 ` Marcel Holtmann
2012-03-16 18:51 ` David Herrmann
2012-03-16 18:51 ` David Herrmann
2012-03-16 20:51 ` Marcel Holtmann
2012-03-16 17:00 ` Andre Guedes
2012-03-16 17:00 ` Andre Guedes
2012-03-16 17:15 ` Marcel Holtmann
2012-03-16 19:01 ` David Herrmann
2012-03-16 19:01 ` David Herrmann
2012-03-16 20:45 ` Marcel Holtmann
2012-03-16 23:38 ` Vinicius Costa Gomes
2012-03-26 17:38 ` David Herrmann
2012-03-26 17:38 ` David Herrmann
2012-03-16 14:58 ` [RFC 0/1] User-space I/O driver for HID subsystem (Bluetooth-LE HIDP) Jiri Kosina
2012-03-16 14:58 ` Jiri Kosina
2012-03-16 16:03 ` Marcel Holtmann
2012-03-16 16:03 ` Marcel Holtmann
2012-03-16 16:04 ` Anderson Lizardo
2012-03-16 16:04 ` Anderson Lizardo
2012-03-16 17:28 ` Joao Paulo Rechi Vita
2012-03-16 17:28 ` Joao Paulo Rechi Vita
2012-03-16 17:50 ` Joao Paulo Rechi Vita
2012-03-16 17:50 ` Joao Paulo Rechi Vita
2012-03-16 17:57 ` Marcel Holtmann
2012-03-16 18:09 ` Dmitry Torokhov [this message]
2012-03-16 18:09 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2581566.JBjJTljkE9@dtor-d630.eng.vmware.com \
--to=dmitry.torokhov@gmail.com \
--cc=Vijaykumar.Dadmode@csr.com \
--cc=chen.ganir@ti.com \
--cc=claudio.takahasi@openbossa.org \
--cc=dh.herrmann@googlemail.com \
--cc=jkosina@suse.cz \
--cc=jprvita@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.