All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liming Wang <walimisdev@gmail.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH 2/2] hw/pflash_cfi01: change print method to avoid complaint
Date: Tue, 20 Mar 2012 22:48:58 +0800	[thread overview]
Message-ID: <1332254938-31023-2-git-send-email-walimisdev@gmail.com> (raw)
In-Reply-To: <1332254938-31023-1-git-send-email-walimisdev@gmail.com>

Linux guest os often writes invalid cmd data to reset into read mode,
which leads many qemu complaint. Here we place all the debug
message into macro PFLASH_DEBUG. We can turn on the all debug info by
define PFLASH_DEBUG if we want to debug pflash_cfi01.

Signed-off-by: Liming Wang <walimisdev@gmail.com>
---
 hw/pflash_cfi01.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c
index 2e6fa71..4e39ea6 100644
--- a/hw/pflash_cfi01.c
+++ b/hw/pflash_cfi01.c
@@ -433,7 +433,7 @@ static void pflash_write(pflash_t *pfl, target_phys_addr_t offset,
     return;
 
  error_flash:
-    printf("%s: Unimplemented flash cmd sequence "
+    DPRINTF("%s: Unimplemented flash cmd sequence "
            "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)\n",
            __func__, offset, pfl->wcycle, pfl->cmd, value);
 
-- 
1.7.0.4

  reply	other threads:[~2012-03-20 14:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20 14:48 [Qemu-devel] [PATCH 1/2] hw/pflash_cfi01: add "0xf0" to select and deselect read mode Liming Wang
2012-03-20 14:48 ` Liming Wang [this message]
2012-03-20 23:43   ` [Qemu-devel] [PATCH 2/2] hw/pflash_cfi01: change print method to avoid complaint Stefan Weil
2012-03-21  1:59     ` walimis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332254938-31023-2-git-send-email-walimisdev@gmail.com \
    --to=walimisdev@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.