Re: [Qemu-devel] [PATCH 2/2] hw/pflash_cfi01: change print method to avoid complaint

[Stefan Weil <sw@weilnetz.de>]

Am 20.03.2012 15:48, schrieb Liming Wang:
> Linux guest os often writes invalid cmd data to reset into read mode,
> which leads many qemu complaint. Here we place all the debug
> message into macro PFLASH_DEBUG. We can turn on the all debug info by
> define PFLASH_DEBUG if we want to debug pflash_cfi01.
>
> Signed-off-by: Liming Wang <walimisdev@gmail.com>
> ---
> hw/pflash_cfi01.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c
> index 2e6fa71..4e39ea6 100644
> --- a/hw/pflash_cfi01.c
> +++ b/hw/pflash_cfi01.c
> @@ -433,7 +433,7 @@ static void pflash_write(pflash_t *pfl, 
> target_phys_addr_t offset,
> return;
>
> error_flash:
> - printf("%s: Unimplemented flash cmd sequence "
> + DPRINTF("%s: Unimplemented flash cmd sequence "
> "(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)\n",
> __func__, offset, pfl->wcycle, pfl->cmd, value);

Using the trace mechanism of QEMU might be better here than DPRINTF
It allows users to enable trace messages without recompilation.
See docs/tracing.txt for details.

I personally like this special printf statement, because it shows me
since several years that there _are_ flash command sequences which should
be implemented (just boot MIPS Malta with Linux). Maybe one day I'll fix
them. With DPRINTF, I'll never again get a reminder.

Regards,
Stefan Weil