From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christopher Li <sparse@chrisli.org>
Cc: penberg@cs.helsinki.fi, linux-sparse@vger.kernel.org,
Pekka Enberg <penberg@kernel.org>,
Jeff Garzik <jgarzik@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Frederic Crozat <fcrozat@suse.com>
Subject: Re: [RFC/PATCH 1/2] sparse: Fix including glibc headers on x86-64
Date: Fri, 23 Mar 2012 20:01:49 +1100 [thread overview]
Message-ID: <1332493309.2882.6.camel@pasglop> (raw)
In-Reply-To: <CANeU7Q=h1egUD1cSpNwmAnemXPTa0k0OrKQOY6Rhow_5hb1hYA@mail.gmail.com>
On Fri, 2012-03-23 at 01:59 -0700, Christopher Li wrote:
>
> I just realized that this patch has the unwanted side effect that,
> even if you try to define 32 bit compile in 64 bit Linux, the
> __x86_64__ will
> still be there. The weak define only avoid the conflict of defining
> the __x86_64__
> the second time. It does not solve the case where __x86_64__ shouldn't
> be there.
>
> The better way seems to be parsing -m32 and -m64 then set the
> __x86_64__ accordingly.
That reminds me we should also have a way to pass the arch triplet and
have a good way to find a "default". On debian sid you need it to get
all your standard includes for userspace, and we should really pass it
to llvm in sparse-llvm.
Cheers,
Ben.
next prev parent reply other threads:[~2012-03-23 9:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 12:36 [RFC/PATCH 1/2] sparse: Fix including glibc headers on x86-64 penberg
2011-10-23 12:37 ` [RFC/PATCH 2/2] sparse: Use native sizes for data types penberg
2011-10-23 15:53 ` Jeff Garzik
2011-10-23 17:13 ` Josh Triplett
2011-10-24 7:06 ` Pekka Enberg
2012-03-23 8:59 ` [RFC/PATCH 1/2] sparse: Fix including glibc headers on x86-64 Christopher Li
2012-03-23 9:01 ` Benjamin Herrenschmidt [this message]
2012-03-23 9:13 ` Christopher Li
2012-03-23 10:03 ` Christopher Li
2012-03-23 18:03 ` Josh Triplett
2012-03-23 18:29 ` Christopher Li
2012-03-23 18:47 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332493309.2882.6.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=fcrozat@suse.com \
--cc=jgarzik@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.