From: Josh Triplett <josh@joshtriplett.org>
To: Christopher Li <sparse@chrisli.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
penberg@cs.helsinki.fi, linux-sparse@vger.kernel.org,
Pekka Enberg <penberg@kernel.org>,
Jeff Garzik <jgarzik@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Frederic Crozat <fcrozat@suse.com>
Subject: Re: [RFC/PATCH 1/2] sparse: Fix including glibc headers on x86-64
Date: Fri, 23 Mar 2012 11:03:20 -0700 [thread overview]
Message-ID: <20120323180320.GA17003@leaf> (raw)
In-Reply-To: <CANeU7QkzM-ZLZ_NgstAjpZdSe-eSgj+-SxEqUX-g5kXBTHrCvg@mail.gmail.com>
On Fri, Mar 23, 2012 at 03:03:51AM -0700, Christopher Li wrote:
> --- a/lib.c
> +++ b/lib.c
> @@ -224,6 +224,15 @@ static enum { STANDARD_C89,
> STANDARD_GNU89,
> STANDARD_GNU99, } standard = STANDARD_GNU89;
>
> +#ifdef __x86_64__
> +#define ARCH_M64_DEFAULT 1
> +#else
> +#define ARCH_M64_DEFAULT 0
> +#endif
Ideally this should work on other 64-bit architectures as well.
Other than that, the rest of the patch looks reasonable.
- Josh Triplett
next prev parent reply other threads:[~2012-03-23 18:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 12:36 [RFC/PATCH 1/2] sparse: Fix including glibc headers on x86-64 penberg
2011-10-23 12:37 ` [RFC/PATCH 2/2] sparse: Use native sizes for data types penberg
2011-10-23 15:53 ` Jeff Garzik
2011-10-23 17:13 ` Josh Triplett
2011-10-24 7:06 ` Pekka Enberg
2012-03-23 8:59 ` [RFC/PATCH 1/2] sparse: Fix including glibc headers on x86-64 Christopher Li
2012-03-23 9:01 ` Benjamin Herrenschmidt
2012-03-23 9:13 ` Christopher Li
2012-03-23 10:03 ` Christopher Li
2012-03-23 18:03 ` Josh Triplett [this message]
2012-03-23 18:29 ` Christopher Li
2012-03-23 18:47 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323180320.GA17003@leaf \
--to=josh@joshtriplett.org \
--cc=benh@kernel.crashing.org \
--cc=fcrozat@suse.com \
--cc=jgarzik@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.