From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/3] drm/i915: the intel gtt is _not_ an agp bridge!
Date: Mon, 26 Mar 2012 09:49:36 +0100 [thread overview]
Message-ID: <1332751786_97030@CP5-2952> (raw)
In-Reply-To: <1332747942-2143-2-git-send-email-daniel.vetter@ffwll.ch>
On Mon, 26 Mar 2012 09:45:41 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> So don't call it like that.
>
> Also rip out a confusing comment and instead explain what's really
> going on.
>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> +/*
> + * This is really ugly: Because old userspace abused the linux agp interface to
> + * manage the gtt, we need to claim that all intel devices are agp. For
> + * otherwise the drm core refuses to initialize the agp support code.
> */
So no new device entries, right?
For the patch itself,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-03-26 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 7:45 [PATCH 1/3] drm/i915: s/i915_gem_do_init/i915_gem_init_global_gtt Daniel Vetter
2012-03-26 7:45 ` [PATCH 2/3] drm/i915: the intel gtt is _not_ an agp bridge! Daniel Vetter
2012-03-26 8:49 ` Chris Wilson [this message]
2012-03-26 9:03 ` Daniel Vetter
2012-03-27 11:15 ` Daniel Vetter
2012-03-26 7:45 ` [PATCH 3/3] drm/i915: clear the entire gtt when using gem Daniel Vetter
2012-03-26 8:48 ` [PATCH 1/3] drm/i915: s/i915_gem_do_init/i915_gem_init_global_gtt Chris Wilson
2012-03-26 8:58 ` Daniel Vetter
2012-03-28 19:39 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332751786_97030@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.