* [PATCH 1/2] regulator: ad5398: show changing current in uA
@ 2012-03-27 2:08 Axel Lin
2012-03-27 2:09 ` [PATCH 2/2] regulator: ad5398: Use devm_kzalloc Axel Lin
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Axel Lin @ 2012-03-27 2:08 UTC (permalink / raw)
To: linux-kernel; +Cc: Sonic Zhang, Liam Girdwood, Mark Brown
Integer division may truncate the result.
Current code shows changing current is 0mA when selector is 1 ... 8.
For example:
selector = 1
ad5398_calc_current returns 117, debug message shows 117/1000 = 0mA
selector = 2
ad5398_calc_current returns 234, debug message shows 234/1000 = 0mA
selector = 3
ad5398_calc_current returns 351, debug message shows 351/1000 = 0mA
............
selector = 8
ad5398_calc_current returns 937, debug message shows 937/1000 = 0mA
Show the changing current in uA makes it easier for debugging.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/ad5398.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
index 26d23ad..ed58798 100644
--- a/drivers/regulator/ad5398.c
+++ b/drivers/regulator/ad5398.c
@@ -99,8 +99,8 @@ static int ad5398_set_current_limit(struct regulator_dev *rdev, int min_uA, int
if (ad5398_calc_current(chip, selector) > max_uA)
return -EINVAL;
- dev_dbg(&client->dev, "changing current %dmA\n",
- ad5398_calc_current(chip, selector) / 1000);
+ dev_dbg(&client->dev, "changing current %duA\n",
+ ad5398_calc_current(chip, selector));
/* read chip enable bit */
ret = ad5398_read_reg(client, &data);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] regulator: ad5398: Use devm_kzalloc
2012-03-27 2:08 [PATCH 1/2] regulator: ad5398: show changing current in uA Axel Lin
@ 2012-03-27 2:09 ` Axel Lin
2012-03-27 2:42 ` Zhang, Sonic
2012-03-27 3:01 ` [PATCH 1/2] regulator: ad5398: show changing current in uA Zhang, Sonic
2012-03-28 11:01 ` Mark Brown
2 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2012-03-27 2:09 UTC (permalink / raw)
To: linux-kernel; +Cc: Sonic Zhang, Liam Girdwood, Mark Brown
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/ad5398.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
index ed58798..7d51793 100644
--- a/drivers/regulator/ad5398.c
+++ b/drivers/regulator/ad5398.c
@@ -220,7 +220,7 @@ static int __devinit ad5398_probe(struct i2c_client *client,
if (!init_data)
return -EINVAL;
- chip = kzalloc(sizeof(*chip), GFP_KERNEL);
+ chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
if (!chip)
return -ENOMEM;
@@ -246,7 +246,6 @@ static int __devinit ad5398_probe(struct i2c_client *client,
return 0;
err:
- kfree(chip);
return ret;
}
@@ -255,8 +254,6 @@ static int __devexit ad5398_remove(struct i2c_client *client)
struct ad5398_chip_info *chip = i2c_get_clientdata(client);
regulator_unregister(chip->rdev);
- kfree(chip);
-
return 0;
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH 2/2] regulator: ad5398: Use devm_kzalloc
2012-03-27 2:09 ` [PATCH 2/2] regulator: ad5398: Use devm_kzalloc Axel Lin
@ 2012-03-27 2:42 ` Zhang, Sonic
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Sonic @ 2012-03-27 2:42 UTC (permalink / raw)
To: Axel Lin, linux-kernel@vger.kernel.org; +Cc: Liam Girdwood, Mark Brown
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1473 bytes --]
Acked-by: Sonic Zhang <sonic.zhang@analog.com>
-----Original Message-----
From: Axel Lin [mailto:axel.lin@gmail.com]
Sent: Tuesday, March 27, 2012 10:10 AM
To: linux-kernel@vger.kernel.org
Cc: Zhang, Sonic; Liam Girdwood; Mark Brown
Subject: [PATCH 2/2] regulator: ad5398: Use devm_kzalloc
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/ad5398.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
index ed58798..7d51793 100644
--- a/drivers/regulator/ad5398.c
+++ b/drivers/regulator/ad5398.c
@@ -220,7 +220,7 @@ static int __devinit ad5398_probe(struct i2c_client *client,
if (!init_data)
return -EINVAL;
- chip = kzalloc(sizeof(*chip), GFP_KERNEL);
+ chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
if (!chip)
return -ENOMEM;
@@ -246,7 +246,6 @@ static int __devinit ad5398_probe(struct i2c_client *client,
return 0;
err:
- kfree(chip);
return ret;
}
@@ -255,8 +254,6 @@ static int __devexit ad5398_remove(struct i2c_client *client)
struct ad5398_chip_info *chip = i2c_get_clientdata(client);
regulator_unregister(chip->rdev);
- kfree(chip);
-
return 0;
}
--
1.7.5.4
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH 1/2] regulator: ad5398: show changing current in uA
2012-03-27 2:08 [PATCH 1/2] regulator: ad5398: show changing current in uA Axel Lin
2012-03-27 2:09 ` [PATCH 2/2] regulator: ad5398: Use devm_kzalloc Axel Lin
@ 2012-03-27 3:01 ` Zhang, Sonic
2012-03-28 11:01 ` Mark Brown
2 siblings, 0 replies; 5+ messages in thread
From: Zhang, Sonic @ 2012-03-27 3:01 UTC (permalink / raw)
To: Axel Lin, linux-kernel@vger.kernel.org; +Cc: Liam Girdwood, Mark Brown
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1810 bytes --]
Acked-by: Sonic Zhang <sonic.zhang@analog.com>
-----Original Message-----
From: Axel Lin [mailto:axel.lin@gmail.com]
Sent: Tuesday, March 27, 2012 10:08 AM
To: linux-kernel@vger.kernel.org
Cc: Zhang, Sonic; Liam Girdwood; Mark Brown
Subject: [PATCH 1/2] regulator: ad5398: show changing current in uA
Integer division may truncate the result.
Current code shows changing current is 0mA when selector is 1 ... 8.
For example:
selector = 1
ad5398_calc_current returns 117, debug message shows 117/1000 = 0mA
selector = 2
ad5398_calc_current returns 234, debug message shows 234/1000 = 0mA
selector = 3
ad5398_calc_current returns 351, debug message shows 351/1000 = 0mA
............
selector = 8
ad5398_calc_current returns 937, debug message shows 937/1000 = 0mA
Show the changing current in uA makes it easier for debugging.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/ad5398.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
index 26d23ad..ed58798 100644
--- a/drivers/regulator/ad5398.c
+++ b/drivers/regulator/ad5398.c
@@ -99,8 +99,8 @@ static int ad5398_set_current_limit(struct regulator_dev *rdev, int min_uA, int
if (ad5398_calc_current(chip, selector) > max_uA)
return -EINVAL;
- dev_dbg(&client->dev, "changing current %dmA\n",
- ad5398_calc_current(chip, selector) / 1000);
+ dev_dbg(&client->dev, "changing current %duA\n",
+ ad5398_calc_current(chip, selector));
/* read chip enable bit */
ret = ad5398_read_reg(client, &data);
--
1.7.5.4
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] regulator: ad5398: show changing current in uA
2012-03-27 2:08 [PATCH 1/2] regulator: ad5398: show changing current in uA Axel Lin
2012-03-27 2:09 ` [PATCH 2/2] regulator: ad5398: Use devm_kzalloc Axel Lin
2012-03-27 3:01 ` [PATCH 1/2] regulator: ad5398: show changing current in uA Zhang, Sonic
@ 2012-03-28 11:01 ` Mark Brown
2 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2012-03-28 11:01 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Sonic Zhang, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
On Tue, Mar 27, 2012 at 10:08:25AM +0800, Axel Lin wrote:
> Integer division may truncate the result.
> Current code shows changing current is 0mA when selector is 1 ... 8.
Applied both, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-28 11:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-27 2:08 [PATCH 1/2] regulator: ad5398: show changing current in uA Axel Lin
2012-03-27 2:09 ` [PATCH 2/2] regulator: ad5398: Use devm_kzalloc Axel Lin
2012-03-27 2:42 ` Zhang, Sonic
2012-03-27 3:01 ` [PATCH 1/2] regulator: ad5398: show changing current in uA Zhang, Sonic
2012-03-28 11:01 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.