All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Goode <emilgoode@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Disregard my patch: x86, vsyscall: Fix sparse warning: Using plain integer as NULL
Date: Sun, 01 Apr 2012 14:18:11 +0000	[thread overview]
Message-ID: <1333289891.2531.5.camel@debian> (raw)

Please disregard my previous patch. 
I missed the comment saying "0 is a valid user pointer".

Best regards,
Emil Goode

On Sun, 2012-04-01 at 01:59 +0200, Emil Goode wrote:
> This patch silences the following sparse warning:
> arch/x86/kernel/vsyscall_64.c:250:34:
>        warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
>  arch/x86/kernel/vsyscall_64.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
> index f386dc4..6170ff9 100644
> --- a/arch/x86/kernel/vsyscall_64.c
> +++ b/arch/x86/kernel/vsyscall_64.c
> @@ -247,7 +247,7 @@ bool emulate_vsyscall(struct pt_regs *regs, unsigned long address)
>  
>  		ret = sys_getcpu((unsigned __user *)regs->di,
>  				 (unsigned __user *)regs->si,
> -				 0);
> +				 NULL);
>  		break;
>  	}
>  



             reply	other threads:[~2012-04-01 14:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-01 14:18 Emil Goode [this message]
2012-04-01 16:49 ` Disregard my patch: x86, vsyscall: Fix sparse warning: Using plain integer as NULL Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333289891.2531.5.camel@debian \
    --to=emilgoode@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.