Disregard my patch: x86, vsyscall: Fix sparse warning: Using plain integer as NULL

Disregard my patch: x86, vsyscall: Fix sparse warning: Using plain integer as NULL

[Emil Goode]

Please disregard my previous patch. 
I missed the comment saying "0 is a valid user pointer".

Best regards,
Emil Goode

On Sun, 2012-04-01 at 01:59 +0200, Emil Goode wrote:
> This patch silences the following sparse warning:
> arch/x86/kernel/vsyscall_64.c:250:34:
>        warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
>  arch/x86/kernel/vsyscall_64.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
> index f386dc4..6170ff9 100644
> --- a/arch/x86/kernel/vsyscall_64.c
> +++ b/arch/x86/kernel/vsyscall_64.c
> @@ -247,7 +247,7 @@ bool emulate_vsyscall(struct pt_regs *regs, unsigned long address)
>  
>  		ret = sys_getcpu((unsigned __user *)regs->di,
>  				 (unsigned __user *)regs->si,
> -				 0);
> +				 NULL);
>  		break;
>  	}
>  

Re: Disregard my patch: x86, vsyscall: Fix sparse warning: Using plain integer as NULL

[Andy Lutomirski]

On Sun, Apr 1, 2012 at 7:18 AM, Emil Goode <emilgoode@gmail.com> wrote:
> Please disregard my previous patch.
> I missed the comment saying "0 is a valid user pointer".

The comment could be changed to "NULL", though.

--Andy

>
> Best regards,
> Emil Goode
>
> On Sun, 2012-04-01 at 01:59 +0200, Emil Goode wrote:
>> This patch silences the following sparse warning:
>> arch/x86/kernel/vsyscall_64.c:250:34:
>>        warning: Using plain integer as NULL pointer
>>
>> Signed-off-by: Emil Goode <emilgoode@gmail.com>
>> ---
>>  arch/x86/kernel/vsyscall_64.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
>> index f386dc4..6170ff9 100644
>> --- a/arch/x86/kernel/vsyscall_64.c
>> +++ b/arch/x86/kernel/vsyscall_64.c
>> @@ -247,7 +247,7 @@ bool emulate_vsyscall(struct pt_regs *regs, unsigned long address)
>>
>>               ret = sys_getcpu((unsigned __user *)regs->di,
>>                                (unsigned __user *)regs->si,
>> -                              0);
>> +                              NULL);
>>               break;
>>       }
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html