All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Airlie <airlied@redhat.com>
Cc: Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	David@freedesktop.org, Anton Vorontsov <cbou@mail.ru>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: broken nouveau dependency on power supply
Date: Mon, 02 Apr 2012 19:48:36 +1000	[thread overview]
Message-ID: <1333360116.30734.50.camel@pasglop> (raw)
In-Reply-To: <6373b480-2185-4651-b12d-8498c806ff69@zmail16.collab.prod.int.phx2.redhat.com>

On Mon, 2012-04-02 at 05:00 -0400, David Airlie wrote:
> >  - Better: Just make the bloody thing a bool :-) The power supply
> > framework itself is small enough, just make it a boolean option and
> > avoid the problem entirely. The actual power supply sub drivers can
> > remain modular of course.
> 
> We can just do select POWER_SUPPLY.

Well, select'ing otherwise user configurable options was still frowned
on last we discussed that... and it makes the whole inline stubs in
power_supply.h totally pointless :-)

> Yes it reduces the option range for some stupid corner case but really
> I don't care, removing features from the kernel that a driver depends
> on is just leading to insane state combination and QA problems.

Well, the power supply stuff only works if you have a backend for it,
which not all platforms are, and it's fairly safe to assume AC whenever
it's not actually supported.

(Talking of which, we should be able to do a PowerBook backend
reasonably easily).

I don't care which solution you guys end up choosing though, just fix
it :-)

Cheers,
Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Airlie <airlied@redhat.com>
Cc: Anton Vorontsov <cbou@mail.ru>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Woodhouse <dwmw2@infradead.org>,
	dri-devel@lists.freedesktop.org, David@freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: broken nouveau dependency on power supply
Date: Mon, 02 Apr 2012 19:48:36 +1000	[thread overview]
Message-ID: <1333360116.30734.50.camel@pasglop> (raw)
In-Reply-To: <6373b480-2185-4651-b12d-8498c806ff69@zmail16.collab.prod.int.phx2.redhat.com>

On Mon, 2012-04-02 at 05:00 -0400, David Airlie wrote:
> >  - Better: Just make the bloody thing a bool :-) The power supply
> > framework itself is small enough, just make it a boolean option and
> > avoid the problem entirely. The actual power supply sub drivers can
> > remain modular of course.
> 
> We can just do select POWER_SUPPLY.

Well, select'ing otherwise user configurable options was still frowned
on last we discussed that... and it makes the whole inline stubs in
power_supply.h totally pointless :-)

> Yes it reduces the option range for some stupid corner case but really
> I don't care, removing features from the kernel that a driver depends
> on is just leading to insane state combination and QA problems.

Well, the power supply stuff only works if you have a backend for it,
which not all platforms are, and it's fairly safe to assume AC whenever
it's not actually supported.

(Talking of which, we should be able to do a PowerBook backend
reasonably easily).

I don't care which solution you guys end up choosing though, just fix
it :-)

Cheers,
Ben.



  reply	other threads:[~2012-04-02  9:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02  1:06 broken nouveau dependency on power supply Benjamin Herrenschmidt
2012-04-02  3:53 ` Benjamin Herrenschmidt
2012-04-02  3:53   ` Benjamin Herrenschmidt
2012-04-02  9:00   ` David Airlie
2012-04-02  9:00     ` David Airlie
2012-04-02  9:48     ` Benjamin Herrenschmidt [this message]
2012-04-02  9:48       ` Benjamin Herrenschmidt
2012-05-05  4:29   ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333360116.30734.50.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=David@freedesktop.org \
    --cc=airlied@redhat.com \
    --cc=cbou@mail.ru \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.