All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1][Resend] meta-yocto fix
@ 2012-04-02  9:23 Shane Wang
  2012-04-02  9:23 ` [PATCH 1/1] meta-yocto/local.conf.sample: change = to ?= for BB_NUMBER_THREADS and PARALLEL_MAKE Shane Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Shane Wang @ 2012-04-02  9:23 UTC (permalink / raw)
  To: yocto

The patch is to change local.conf to allow Hob change BB threads and pmake. Please review.
In the current local.conf, BB_NUMBER_THREADS and PARALLEL_MAKE are assigned
by '=', which overwrites the values set from the Hob. To avoid that, use '?='
instead.

The following changes since commit 8691a588267472eb5a32b978a0eb9ddfd0c91733:

  cross-canadian.bbclass: fix rpath for sdk executables (2012-03-31 18:00:59 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib shane/meta-yocto
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/meta-yocto

Shane Wang (1):
  meta-yocto/local.conf.sample: change = to ?= for BB_NUMBER_THREADS
    and PARALLEL_MAKE

 meta-yocto/conf/local.conf.sample |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.7.6



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] meta-yocto/local.conf.sample: change = to ?= for BB_NUMBER_THREADS and PARALLEL_MAKE
  2012-04-02  9:23 [PATCH 0/1][Resend] meta-yocto fix Shane Wang
@ 2012-04-02  9:23 ` Shane Wang
  2012-04-02 12:38   ` Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Shane Wang @ 2012-04-02  9:23 UTC (permalink / raw)
  To: yocto

In the current local.conf, BB_NUMBER_THREADS and PARALLEL_MAKE are assigned
by '=', which overwrites the values set from the Hob. To avoid that, use '?='
instead.

[Yocto #2210]

Signed-off-by: Shane Wang <shane.wang@intel.com>
---
 meta-yocto/conf/local.conf.sample |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-yocto/conf/local.conf.sample b/meta-yocto/conf/local.conf.sample
index 38507e3..a4a8192 100644
--- a/meta-yocto/conf/local.conf.sample
+++ b/meta-yocto/conf/local.conf.sample
@@ -17,12 +17,12 @@
 # These two options control how much parallelism BitBake should use. The first 
 # option determines how many tasks bitbake should run in parallel:
 #
-#BB_NUMBER_THREADS = "4"
+#BB_NUMBER_THREADS ?= "4"
 # 
 # The second option controls how many processes make should run in parallel when
 # running compile tasks:
 #
-#PARALLEL_MAKE = "-j 4"
+#PARALLEL_MAKE ?= "-j 4"
 #
 # For a quad-core machine, BB_NUMBER_THREADS = "4", PARALLEL_MAKE = "-j 4" would
 # be appropriate for example.
-- 
1.7.6



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] meta-yocto/local.conf.sample: change = to ?= for BB_NUMBER_THREADS and PARALLEL_MAKE
  2012-04-02  9:23 ` [PATCH 1/1] meta-yocto/local.conf.sample: change = to ?= for BB_NUMBER_THREADS and PARALLEL_MAKE Shane Wang
@ 2012-04-02 12:38   ` Richard Purdie
  0 siblings, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2012-04-02 12:38 UTC (permalink / raw)
  To: Shane Wang; +Cc: yocto

On Mon, 2012-04-02 at 17:23 +0800, Shane Wang wrote:
> In the current local.conf, BB_NUMBER_THREADS and PARALLEL_MAKE are assigned
> by '=', which overwrites the values set from the Hob. To avoid that, use '?='
> instead.
> 
> [Yocto #2210]
> 
> Signed-off-by: Shane Wang <shane.wang@intel.com>
> ---
>  meta-yocto/conf/local.conf.sample |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

If the user has used "=" in their configuration files, hob needs to deal
with this. It is not acceptable to patch the world to revolve around
hob.

So, no, I'm not going to take this patch, sorry.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-02 12:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-02  9:23 [PATCH 0/1][Resend] meta-yocto fix Shane Wang
2012-04-02  9:23 ` [PATCH 1/1] meta-yocto/local.conf.sample: change = to ?= for BB_NUMBER_THREADS and PARALLEL_MAKE Shane Wang
2012-04-02 12:38   ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.