From: Steven Whitehouse <swhiteho@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
xfs@oss.sgi.com, jack@suse.cz, hch@infradead.org
Subject: Re: [PATCH 3/7] gfs2: Use generic handlers of O_SYNC AIO DIO
Date: Mon, 02 Apr 2012 15:29:31 +0100 [thread overview]
Message-ID: <1333376971.2701.26.camel@menhir> (raw)
In-Reply-To: <1333058705-31512-4-git-send-email-jmoyer@redhat.com>
Hi,
On Thu, 2012-03-29 at 18:05 -0400, Jeff Moyer wrote:
> From: Jan Kara <jack@suse.cz>
>
> Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC
> file.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Steve.
> ---
> fs/gfs2/aops.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
> index 38b7a74..2589781 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -1034,7 +1034,7 @@ static ssize_t gfs2_direct_IO(int rw, struct kiocb *iocb,
>
> rv = __blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov,
> offset, nr_segs, gfs2_get_block_direct,
> - NULL, NULL, 0);
> + NULL, NULL, DIO_SYNC_WRITES);
> out:
> gfs2_glock_dq_m(1, &gh);
> gfs2_holder_uninit(&gh);
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org,
linux-ext4@vger.kernel.org, jack@suse.cz, xfs@oss.sgi.com
Subject: Re: [PATCH 3/7] gfs2: Use generic handlers of O_SYNC AIO DIO
Date: Mon, 02 Apr 2012 15:29:31 +0100 [thread overview]
Message-ID: <1333376971.2701.26.camel@menhir> (raw)
In-Reply-To: <1333058705-31512-4-git-send-email-jmoyer@redhat.com>
Hi,
On Thu, 2012-03-29 at 18:05 -0400, Jeff Moyer wrote:
> From: Jan Kara <jack@suse.cz>
>
> Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC
> file.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Steve.
> ---
> fs/gfs2/aops.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
> index 38b7a74..2589781 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -1034,7 +1034,7 @@ static ssize_t gfs2_direct_IO(int rw, struct kiocb *iocb,
>
> rv = __blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov,
> offset, nr_segs, gfs2_get_block_direct,
> - NULL, NULL, 0);
> + NULL, NULL, DIO_SYNC_WRITES);
> out:
> gfs2_glock_dq_m(1, &gh);
> gfs2_holder_uninit(&gh);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-04-02 14:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 22:04 [PATCH 0/7, v3] fs: fix up AIO+DIO+O_SYNC to actually do the sync part Jeff Moyer
2012-03-29 22:04 ` Jeff Moyer
2012-03-29 22:04 ` [PATCH 1/7] vfs: Handle O_SYNC AIO DIO in generic code properly Jeff Moyer
2012-03-29 22:04 ` Jeff Moyer
2012-03-29 22:05 ` [PATCH 2/7] ocfs2: Use generic handlers of O_SYNC AIO DIO Jeff Moyer
2012-03-29 22:05 ` Jeff Moyer
2012-03-29 22:05 ` [PATCH 3/7] gfs2: " Jeff Moyer
2012-03-29 22:05 ` Jeff Moyer
2012-04-02 14:29 ` Steven Whitehouse [this message]
2012-04-02 14:29 ` Steven Whitehouse
2012-03-29 22:05 ` [PATCH 4/7] btrfs: " Jeff Moyer
2012-03-29 22:05 ` Jeff Moyer
2012-03-29 22:05 ` [PATCH 5/7] xfs: honor the O_SYNC flag for aysnchronous direct I/O requests Jeff Moyer
2012-03-29 22:05 ` Jeff Moyer
2012-03-29 22:57 ` Dave Chinner
2012-03-29 22:57 ` Dave Chinner
2012-03-30 14:50 ` Jeff Moyer
2012-03-30 14:50 ` Jeff Moyer
2012-03-30 19:45 ` Jeff Moyer
2012-03-30 19:45 ` Jeff Moyer
2012-04-19 15:04 ` Jeff Moyer
2012-04-19 15:04 ` Jeff Moyer
2012-03-30 18:18 ` Eric Sandeen
2012-03-30 18:18 ` Eric Sandeen
2012-03-29 22:05 ` [PATCH 6/7] ext4: " Jeff Moyer
2012-03-29 22:05 ` Jeff Moyer
2012-03-29 22:05 ` [PATCH 7/7] filemap: don't call generic_write_sync for -EIOCBQUEUED Jeff Moyer
2012-03-29 22:05 ` Jeff Moyer
-- strict thread matches above, loose matches on Subject: below --
2012-03-02 19:56 [PATCH 0/7, v2] fs: fix up AIO+DIO+O_SYNC to actually do the sync part Jeff Moyer
2012-03-02 19:56 ` [PATCH 3/7] gfs2: Use generic handlers of O_SYNC AIO DIO Jeff Moyer
2012-03-02 19:56 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333376971.2701.26.camel@menhir \
--to=swhiteho@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.