* [PATCH] Revert "drm/i915: reenable gmbus on gen3+ again" @ 2012-04-09 19:10 Daniel Vetter 2012-04-09 19:31 ` Chris Wilson 0 siblings, 1 reply; 3+ messages in thread From: Daniel Vetter @ 2012-04-09 19:10 UTC (permalink / raw) To: Intel Graphics Development; +Cc: Daniel Vetter This reverts commit c3dfefa0a6d235bd465309e12f4c56ea16e71111. gmbus in 3.4 has simply too many known issues: - gmbus is too noisy, we need to rework the logging: https://bugs.freedesktop.org/show_bug.cgi?id=48248 - zero-lenght writes cause an OOPS, and they are userspace-triggerable: https://lkml.org/lkml/2012/3/30/176 - same for zero-lenght reads: https://bugs.freedesktop.org/show_bug.cgi?id=48269 We can try again for 3.5. Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/i915/intel_i2c.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c index 601c86e..8fdc957 100644 --- a/drivers/gpu/drm/i915/intel_i2c.c +++ b/drivers/gpu/drm/i915/intel_i2c.c @@ -390,7 +390,7 @@ int intel_setup_gmbus(struct drm_device *dev) bus->has_gpio = intel_gpio_setup(bus, i); /* XXX force bit banging until GMBUS is fully debugged */ - if (bus->has_gpio && IS_GEN2(dev)) + if (bus->has_gpio) bus->force_bit = true; } -- 1.7.9.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "drm/i915: reenable gmbus on gen3+ again" 2012-04-09 19:10 [PATCH] Revert "drm/i915: reenable gmbus on gen3+ again" Daniel Vetter @ 2012-04-09 19:31 ` Chris Wilson 2012-04-11 10:11 ` Daniel Vetter 0 siblings, 1 reply; 3+ messages in thread From: Chris Wilson @ 2012-04-09 19:31 UTC (permalink / raw) To: Intel Graphics Development; +Cc: Daniel Vetter On Mon, 9 Apr 2012 21:10:38 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > This reverts commit c3dfefa0a6d235bd465309e12f4c56ea16e71111. > > gmbus in 3.4 has simply too many known issues: > - gmbus is too noisy, we need to rework the logging: > https://bugs.freedesktop.org/show_bug.cgi?id=48248 > - zero-lenght writes cause an OOPS, and they are s/lenght/length/ > userspace-triggerable: > https://lkml.org/lkml/2012/3/30/176 > - same for zero-lenght reads: s/lenght/length/ > https://bugs.freedesktop.org/show_bug.cgi?id=48269 > > We can try again for 3.5. > > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Acked-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "drm/i915: reenable gmbus on gen3+ again" 2012-04-09 19:31 ` Chris Wilson @ 2012-04-11 10:11 ` Daniel Vetter 0 siblings, 0 replies; 3+ messages in thread From: Daniel Vetter @ 2012-04-11 10:11 UTC (permalink / raw) To: Chris Wilson; +Cc: Daniel Vetter, Intel Graphics Development On Mon, Apr 09, 2012 at 08:31:20PM +0100, Chris Wilson wrote: > On Mon, 9 Apr 2012 21:10:38 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > This reverts commit c3dfefa0a6d235bd465309e12f4c56ea16e71111. > > > > gmbus in 3.4 has simply too many known issues: > > - gmbus is too noisy, we need to rework the logging: > > https://bugs.freedesktop.org/show_bug.cgi?id=48248 > > - zero-lenght writes cause an OOPS, and they are > s/lenght/length/ > > > userspace-triggerable: > > https://lkml.org/lkml/2012/3/30/176 > > - same for zero-lenght reads: > s/lenght/length/ > > https://bugs.freedesktop.org/show_bug.cgi?id=48269 > > > > We can try again for 3.5. > > > > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > Acked-by: Chris Wilson <chris@chris-wilson.co.uk> I've picked this one for -fixes. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-11 10:11 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-04-09 19:10 [PATCH] Revert "drm/i915: reenable gmbus on gen3+ again" Daniel Vetter 2012-04-09 19:31 ` Chris Wilson 2012-04-11 10:11 ` Daniel Vetter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.