All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/radeon: disable MSI on RV515
@ 2012-04-13 14:19 Dave Airlie
  2012-04-13 14:27 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Airlie @ 2012-04-13 14:19 UTC (permalink / raw)
  To: dri-devel

From: Dave Airlie <airlied@redhat.com>

My rv515 card is very flaky with msi enabled. Every so often it loses a rearm
and never comes back, manually banging the rearm brings it back.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/radeon/radeon_irq_kms.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c b/drivers/gpu/drm/radeon/radeon_irq_kms.c
index 66d5fe1..65060b7 100644
--- a/drivers/gpu/drm/radeon/radeon_irq_kms.c
+++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c
@@ -147,6 +147,12 @@ static bool radeon_msi_ok(struct radeon_device *rdev)
 	    (rdev->pdev->subsystem_device == 0x01fd))
 		return true;
 
+	/* RV515 seems to have MSI issues where it loses
+	 * MSI rearms occasionally. This leads to lockups and freezes.
+	 * disable it by default.
+	 */
+	if (rdev->family == CHIP_RV515)
+		return false;
 	if (rdev->flags & RADEON_IS_IGP) {
 		/* APUs work fine with MSIs */
 		if (rdev->family >= CHIP_PALM)
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/radeon: disable MSI on RV515
  2012-04-13 14:19 [PATCH] drm/radeon: disable MSI on RV515 Dave Airlie
@ 2012-04-13 14:27 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2012-04-13 14:27 UTC (permalink / raw)
  To: Dave Airlie; +Cc: dri-devel

On Fri, Apr 13, 2012 at 10:19 AM, Dave Airlie <airlied@gmail.com> wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> My rv515 card is very flaky with msi enabled. Every so often it loses a rearm
> and never comes back, manually banging the rearm brings it back.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/radeon/radeon_irq_kms.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c b/drivers/gpu/drm/radeon/radeon_irq_kms.c
> index 66d5fe1..65060b7 100644
> --- a/drivers/gpu/drm/radeon/radeon_irq_kms.c
> +++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c
> @@ -147,6 +147,12 @@ static bool radeon_msi_ok(struct radeon_device *rdev)
>            (rdev->pdev->subsystem_device == 0x01fd))
>                return true;
>
> +       /* RV515 seems to have MSI issues where it loses
> +        * MSI rearms occasionally. This leads to lockups and freezes.
> +        * disable it by default.
> +        */
> +       if (rdev->family == CHIP_RV515)
> +               return false;
>        if (rdev->flags & RADEON_IS_IGP) {
>                /* APUs work fine with MSIs */
>                if (rdev->family >= CHIP_PALM)
> --
> 1.7.7.6
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-13 14:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-13 14:19 [PATCH] drm/radeon: disable MSI on RV515 Dave Airlie
2012-04-13 14:27 ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.