From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Always flush tiling changes before accessing through the GTT
Date: Sat, 14 Apr 2012 22:59:25 +0100 [thread overview]
Message-ID: <1334440777_831@CP5-2952> (raw)
In-Reply-To: <20120414215452.GC4215@phenom.ffwll.local>
On Sat, 14 Apr 2012 23:54:52 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sat, Apr 14, 2012 at 09:55:50AM +0100, Chris Wilson wrote:
> > As we defer updating the fence register from set-tiling to the point of
> > use, we need to declare every access through the GTT as either fenced or
> > unfenced.
> >
> > This patches fixes up a couple of freshly introduced GTT accesses which
> > missed the fence flush.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Actually no, this set_to_gtt is actually just a flush+wait_rendering
> because the shmem pwrite/pread afters does clever in-line clflushing.
> Abuse of interfaces, I know ...
Probably best to leave a note, so the next time I do a grep looking for
use of set-to-gtt without a following fence declaration, I don't submit
another patch. :-)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-14 21:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 8:55 [PATCH 1/5] drm/i915: Suppress EIO during set-to-gtt Chris Wilson
2012-04-14 8:55 ` [PATCH 2/5] drm/i915: Suppress EIO through fence-flushing Chris Wilson
2012-04-14 9:02 ` Chris Wilson
2012-04-14 8:55 ` [PATCH 3/5] drm/i915: Suppress EIO during i915_gem_idle() Chris Wilson
2012-04-18 8:51 ` Daniel Vetter
2012-04-18 9:03 ` Chris Wilson
2012-04-14 8:55 ` [PATCH 4/5] drm/i915: Always flush tiling changes before accessing through the GTT Chris Wilson
2012-04-14 21:54 ` Daniel Vetter
2012-04-14 21:59 ` Chris Wilson [this message]
2012-04-14 8:55 ` [PATCH 5/5] " Chris Wilson
2012-04-14 22:00 ` Daniel Vetter
2012-04-18 8:48 ` Daniel Vetter
2012-04-14 9:02 ` [PATCH 1/5] drm/i915: Suppress EIO during set-to-gtt Chris Wilson
2012-04-18 9:03 ` Daniel Vetter
2012-04-18 9:10 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334440777_831@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.